security: remove client-controlled coordinator URL (SSRF)#122
Open
antojoseph wants to merge 1 commit into
Open
security: remove client-controlled coordinator URL (SSRF)#122antojoseph wants to merge 1 commit into
antojoseph wants to merge 1 commit into
Conversation
All five console API proxy routes read x-coordinator-url from the request and forwarded Privy session tokens or cookies to that arbitrary URL. An attacker could exfiltrate bearer tokens to any server they control. Remove the header read; always use DEFAULT_COORD (the server-side env var).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-coordinator-urlfrom the request and forwarded Privy session tokens / cookies to that arbitrary URLDEFAULT_COORD(server-side env var)Affected routes:
POST /api/payments/withdraw/stripePOST /api/payments/stripe/checkoutPOST /api/payments/stripe/onboardGET /api/payments/stripe/statusPOST /api/telemetryTest plan
x-coordinator-url: https://evil.example.comin a request no longer causes auth headers to be forwarded there