Skip to content

security: remove client-controlled coordinator URL (SSRF) #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antojoseph wants to merge 1 commit into
base: master
Choose a base branch
from
Open

security: remove client-controlled coordinator URL (SSRF) #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion console-ui/src/app/api/payments/stripe/checkout/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { NextRequest, NextResponse } from "next/server";
const DEFAULT_COORD = process.env.NEXT_PUBLIC_COORDINATOR_URL || "https://api.darkbloom.dev";

export async function POST(req: NextRequest) {
const coordUrl = req.headers.get("x-coordinator-url") || DEFAULT_COORD;
const coordUrl = DEFAULT_COORD;

let authHeader = req.headers.get("authorization") || "";
if (!authHeader) {
Expand Down
2 changes: 1 addition & 1 deletion console-ui/src/app/api/payments/stripe/onboard/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { NextRequest, NextResponse } from "next/server";
const DEFAULT_COORD = process.env.NEXT_PUBLIC_COORDINATOR_URL || "https://api.darkbloom.dev";

export async function POST(req: NextRequest) {
const coordUrl = req.headers.get("x-coordinator-url") || DEFAULT_COORD;
const coordUrl = DEFAULT_COORD;

let authHeader = req.headers.get("authorization") || "";
if (!authHeader) {
Expand Down
2 changes: 1 addition & 1 deletion console-ui/src/app/api/payments/stripe/status/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
const DEFAULT_COORD = process.env.NEXT_PUBLIC_COORDINATOR_URL || "https://api.darkbloom.dev";

export async function GET(req: NextRequest) {
const coordUrl = req.headers.get("x-coordinator-url") || DEFAULT_COORD;
const coordUrl = DEFAULT_COORD;

let authHeader = req.headers.get("authorization") || "";
if (!authHeader) {
Expand All @@ -16,7 +16,7 @@

const url = new URL(req.url);
const refresh = url.searchParams.get("refresh");
const upstream = `${coordUrl}/v1/billing/stripe/status${refresh ? `?refresh=${refresh}` : ""}`;

Check warning on line 19 in console-ui/src/app/api/payments/stripe/status/route.ts

View workflow job for this annotation

GitHub Actions / Console UI Lint & Build 

Refactor this code to not use nested template literals

const res = await fetch(upstream, {
headers: { ...(authHeader ? { Authorization: authHeader } : {}) },
Expand Down
2 changes: 1 addition & 1 deletion console-ui/src/app/api/payments/withdraw/stripe/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { NextRequest, NextResponse } from "next/server";
const DEFAULT_COORD = process.env.NEXT_PUBLIC_COORDINATOR_URL || "https://api.darkbloom.dev";

export async function POST(req: NextRequest) {
const coordUrl = req.headers.get("x-coordinator-url") || DEFAULT_COORD;
const coordUrl = DEFAULT_COORD;

let authHeader = req.headers.get("authorization") || "";
if (!authHeader) {
Expand Down
2 changes: 1 addition & 1 deletion console-ui/src/app/api/telemetry/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const MAX_BODY = 64 * 1024;
export const runtime = "nodejs";

export async function POST(req: NextRequest) {
const coordUrl = req.headers.get("x-coordinator-url") || DEFAULT_COORD;
const coordUrl = DEFAULT_COORD;

// Read with explicit size cap.
const raw = await req.text();
Expand Down
Loading