Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display author information concisely and update it correctly #14

Closed
wants to merge 1 commit into from

Conversation

notartom
Copy link
Member

If an author has 0 completed books, that information is not worth being
displayed. Same for 0 books in progress. Use correct plural forms for
the above information (book/books).

Authors that had "Completed: 0 books | In progress: 0 books" before do
not have any information at all now. This can later be extended to count
the sections instead of the projects, for those authors that only appear
in collective works.

When updating the book statistics, also update those authors that don't
have any books at all. Without this extra cleanup, these authors will
keep the previous count of their books, which is wrong. To see the wrong
behavior:

UPDATE authors SET meta_complete = -1, meta_in_progress = -1;

https://librivox.org/cron/project_status_stats/author

https://librivox.org/search

Now some of the authors still have the -1 count.

If an author has 0 completed books, that information is not worth being
displayed. Same for 0 books in progress. Use correct plural forms for
the above information (book/books).

Authors that had "Completed: 0 books | In progress: 0 books" before do
not have any information at all now. This can later be extended to count
the sections instead of the projects, for those authors that only appear
in collective works.

When updating the book statistics, also update those authors that don't
have any books at all. Without this extra cleanup, these authors will
keep the previous count of their books, which is wrong. To see the wrong
behavior:

    UPDATE authors SET meta_complete = -1, meta_in_progress = -1;

    https://librivox.org/cron/project_status_stats/author

    https://librivox.org/search

Now some of the authors still have the -1 count.
@notartom
Copy link
Member Author

Replaced by #242

@notartom notartom closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants