Update author stats correctly, and show plurality #242
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notartom
requested changes
Sep 7, 2024
When updating the book statistics, also update those authors that don't have any books at all. Without this extra cleanup, these authors will keep the previous count of their books, which is wrong. Co-authored-by: Roland Illig <roland.illig@gmx.de>
Co-authored-by: Roland Illig <roland.illig@gmx.de>
redrun45
force-pushed
the
fix-author-stats
branch
from
c7941bb to
1cb5b82
Compare
|
I think this should cover those comments! I was just focused on getting @rillig's work into the code-base, now that I am sure I understand what it was doing. I didn't want to mess with a scheduled job until I had to, otherwise. 😄 |
notartom
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #14 - we may as well benefit from fixing the in-progress statistic, and showing plurality for "book" vs "books". Removing the statistics line isn't something we're sure we want. Better to add to it instead, when we get around to that. 😉