Skip to content

refactor: try catch a more specific exception during log_metrics. #21271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

refactor: try catch a more specific exception during log_metrics. #21271

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ecc6a9b
refactor: try catch a more specific exception during log_metrics.
GdoongMathew Oct 6, 2025
e7d5cb2
fix test.
GdoongMathew Oct 7, 2025
e5c3f14
Apply suggestion from @GdoongMathew
GdoongMathew Oct 8, 2025
ca835f2
Merge branch 'master' into refactor/tensorboard_log_metrics_handling
deependujha Oct 14, 2025
c0ebb3b
Merge branch 'master' into refactor/tensorboard_log_metrics_handling
GdoongMathew Oct 24, 2025
1e5e593
Merge branch 'master' into refactor/tensorboard_log_metrics_handling
GdoongMathew Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/lightning/fabric/loggers/tensorboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,11 @@ def log_metrics(self, metrics: Mapping[str, float], step: Optional[int] = None)
else:
try:
self.experiment.add_scalar(k, v, step)
except (NotImplementedError, ValueError) as ex:
except (
NotImplementedError,
ValueError,
ModuleNotFoundError, # https://github.com/pytorch/pytorch/issues/24175
) as ex:
raise ValueError(
f"\n you tried to log {v} which is currently not supported. Try a dict or a scalar/tensor."
) from ex
Expand Down
Loading