Skip to content

Conversation

@fschlatt
Copy link
Contributor

@fschlatt fschlatt commented Dec 30, 2025

What does this PR do?

Fixes #17654

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21462.org.readthedocs.build/en/21462/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 30, 2025
@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79%. Comparing base (027455b) to head (2644173).
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (027455b) and HEAD (2644173). Click for more details.

HEAD has 2271 uploads less than BASE
Flag BASE (027455b) HEAD (2644173)
python3.10 54 3
cpu 537 29
lightning 270 15
pytest 269 0
lightning_fabric 134 0
python3.12 161 8
python3.12.7 160 9
python3.11 108 6
python 54 3
pytorch_lightning 133 14
pytorch2.6 26 3
pytest-full 268 29
pytorch2.1 54 6
pytorch2.9 26 2
pytorch2.3 27 3
pytorch2.8 27 3
pytorch2.2.2 27 3
pytorch2.5.1 27 3
pytorch2.4.1 27 3
pytorch2.7 27 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21462     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         270      267      -3     
  Lines       24059    24009     -50     
=========================================
- Hits        20862    18957   -1905     
- Misses       3197     5052   +1855     

Copy link
Contributor Author

@fschlatt fschlatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not ready to merge. I've reverted fixing the tests, because I misinterpreted what the save_dir argument did. Implementing proper tests is a bit more involved and is something I will try to solve soon.

@bhimrazy bhimrazy marked this pull request as draft January 4, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wandb checkpoints are not logged in experiment's directory

1 participant