Skip to content

Use Wandb experiment's files directory as save directory #21462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fschlatt wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Use Wandb experiment's files directory as save directory #21462

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1f6aefc
use wandb directory as save directory
fschlatt Dec 30, 2025
1487325
update default value of save_dir
fschlatt Dec 30, 2025
2644173
fix wandb tests
fschlatt Dec 30, 2025
fcbecc8
Revert "update default value of save_dir"
fschlatt Jan 2, 2026
55e5791
Revert "fix wandb tests"
fschlatt Jan 2, 2026
21f6d5f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lightning/pytorch/loggers/wandb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
from torch import Tensor
from typing_extensions import override

from lightning.fabric.loggers.logger import _DummyExperiment
from lightning.fabric.utilities.logger import (
_add_prefix,
_convert_json_serializable,
Expand Down Expand Up @@ -562,7 +563,9 @@ def save_dir(self) -> Optional[str]:
The path to the save directory.

"""
return self._save_dir
if isinstance(self.experiment, _DummyExperiment):
return None
return self.experiment.dir

@property
@override
Expand Down
Loading