Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Jul 19, 2024

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

We do not use any real test in the notebooks as added notebooks are without any output so there is nothing to match except just all cells are passing, but there is some issue with cell's timeout

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (d047ff8) to head (54196f3).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #324   +/-   ##
===================================
- Coverage    71%    71%   -0%     
===================================
  Files         2      2           
  Lines       399    401    +2     
===================================
  Hits        285    285           
- Misses      114    116    +2     

@Borda Borda marked this pull request as ready for review July 19, 2024 15:32
@Borda Borda requested a review from ethanwharris as a code owner July 19, 2024 15:32
@Borda Borda merged commit 65710b9 into main Jul 19, 2024
@Borda Borda deleted the c/ipython branch July 19, 2024 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant