Skip to content

Conversation

@SayakaOno
Copy link
Collaborator

@SayakaOno SayakaOno commented Oct 24, 2025

Description

Disable the "Save product" button in ProductForm while an API call is in progress using the isSaving state.
Regardless of whether the API call succeeds or fails,isSaving is reset to false.

Jira link: https://lite-farm.atlassian.net/browse/LF-5026

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have ordered translation keys alphabetically (optional: run pnpm i18n to help with this)
  • I have added the GNU General Public License to all new files

@SayakaOno SayakaOno self-assigned this Oct 24, 2025
@SayakaOno SayakaOno requested review from a team as code owners October 24, 2025 16:57
@SayakaOno SayakaOno requested review from Duncan-Brain and removed request for a team October 24, 2025 16:58
@SayakaOno SayakaOno added the bug Something isn't working label Oct 24, 2025
@SayakaOno SayakaOno changed the title LF-4530: The user is able to create duplicating animals simply by clicking save button 2 or more times LF-5026: Duplicate product created when "Save Product" button is clicked twice quickly for specific product names Oct 27, 2025
@Duncan-Brain
Copy link
Collaborator

I was not able to duplicate the selector putting the product into state twice, but the fix looks good for at least the double submission and snackbar.

@Duncan-Brain Duncan-Brain added this pull request to the merge queue Oct 29, 2025
Merged via the queue into integration with commit b791c43 Oct 29, 2025
5 checks passed
@SayakaOno SayakaOno deleted the LF-4530/The_user_is_able_to_create_duplicating_animals_simply_by_clicking_Save_button_2_or_more_times branch October 29, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants