Update node min version to v22 for electron/fuses requirement#1508
Update node min version to v22 for electron/fuses requirement#1508mitchcapper wants to merge 1 commit intoMCPJam:mainfrom
Conversation
dosubot
bot
added
the
size:XS
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis pull request upgrades Node.js references for mcpjam-inspector to 22.12.0 across the project: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@mcpjam-inspector/.nvmrc`:
- Line 1: The .nvmrc currently contains a loose "22" which allows any 22.x Node
and may violate `@electron/fuses` >=22.12.0; update the .nvmrc value to the
minimum required exact version "22.12.0" (pin Node to 22.12.0) so installs are
deterministic and satisfy the engine requirement.
mitchcapper
force-pushed
the
update_node_to_v22_min
branch
from
41cc318 to
36e889f
Compare
|
Not sure if this was waiting for the ai change but if so I have updated it to the specific node version. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@mcpjam-inspector/package.json`:
- Line 178: Add an explicit Node runtime contract by setting engines.node to
">=22.12.0" in package.json (so the package declares the required Node version),
and update the project environment specs to match: change the Node base
image/tag in the Dockerfile and update Node versions used in GitHub workflows
(lint.yml, test.yml, windows-release.yml) to 22.12.0 or later so all
CI/Docker/dev environments align with the `@electron/fuses` requirement and the
bumped `@types/node`.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 497885c6-65d7-4b8b-acff-5e11dd480ca7
📒 Files selected for processing (2)
mcpjam-inspector/.nvmrcmcpjam-inspector/package.json
🚧 Files skipped from review as they are similar to previous changes (1)
- mcpjam-inspector/.nvmrc
added specific version per PR ai request
mitchcapper
force-pushed
the
update_node_to_v22_min
branch
from
36e889f to
37f4aac
Compare
dosubot
bot
added
size:S
2 participants
the electron/fuses currently requires node v22, but the nvmrc forces v20.