Skip to content

Update node min version to v22 for electron/fuses requirement #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mitchcapper wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update node min version to v22 for electron/fuses requirement #1508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: "20"
node-version: "22.12.0"

- name: Install dependencies
run: |
Expand Down Expand Up @@ -55,7 +55,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: "20"
node-version: "22.12.0"

- name: Install dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: "20"
node-version: "22.12.0"

- name: Install dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 22.12.0

- name: Clean dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion mcpjam-inspector/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20
22.12.0
5 changes: 2 additions & 3 deletions mcpjam-inspector/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# Use specific Node.js version to avoid vulnerabilities in older versions
# CVE fixes require Node.js 20.20.0+ (race condition, symlink following, uncaught exception)
ARG NODE_VERSION=20.20.0
# Use specific Node.js version to satisfy @electron/fuses and @types/node runtime requirements
ARG NODE_VERSION=22.12.0

FROM node:${NODE_VERSION}-alpine AS base

Expand Down
5 changes: 4 additions & 1 deletion mcpjam-inspector/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
"productName": "MCPJam Inspector",
"version": "2.0.2",
"type": "module",
"engines": {
"node": ">=22.12.0"
},
"description": "MCPJam Inspector",
"license": "Apache-2.0",
"author": "MCPJam (https://mcpjam.com)",
Expand Down Expand Up @@ -175,7 +178,7 @@
"@testing-library/jest-dom": "^6.9.1",
"@testing-library/react": "^16.3.1",
"@testing-library/user-event": "^14.6.1",
"@types/node": "^20",
"@types/node": "^22",
"@types/react": "^19",
"@types/react-dom": "^19",
"@vitejs/plugin-react": "^4.3.4",
Expand Down
Loading