Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some logging to debug timestamp selection for REFRESH MVs #30793

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

ggevay
Copy link
Contributor

@ggevay ggevay commented Dec 10, 2024

Logging for https://github.com/MaterializeInc/database-issues/issues/8821
as discussed at
https://materializeinc.slack.com/archives/C0761MZ3QD9/p1733845868029119?thread_ts=1733597183.408179&cid=C0761MZ3QD9
so that we'll have more info the next time it happens in CI.

The placement of the log in appends.rs is @jkosh44's suggestion on Slack.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ggevay ggevay added A-ADAPTER Topics related to the ADAPTER layer A-CLUSTER Topics related to the CLUSTER layer labels Dec 10, 2024
@ggevay ggevay requested a review from teskje December 10, 2024 16:58
@ggevay ggevay requested a review from a team as a code owner December 10, 2024 16:58
@ggevay ggevay requested a review from jkosh44 December 10, 2024 16:58
@ggevay ggevay merged commit 6238158 into MaterializeInc:main Dec 10, 2024
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ADAPTER Topics related to the ADAPTER layer A-CLUSTER Topics related to the CLUSTER layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants