Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some logging to debug timestamp selection for REFRESH MVs #30793

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Add some logging to debug timestamp selection for REFRESH MVs #30793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/adapter/src/coord/appends.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ use mz_sql::session::metadata::SessionMetadata;
use mz_storage_client::client::TimestamplessUpdate;
use mz_timestamp_oracle::WriteTimestamp;
use tokio::sync::{oneshot, Notify, OwnedMutexGuard, OwnedSemaphorePermit, Semaphore};
use tracing::{debug_span, warn, Instrument, Span};
use tracing::{debug_span, info, warn, Instrument, Span};

use crate::catalog::BuiltinTableUpdate;
use crate::coord::{Coordinator, Message, PendingTxn, PlanValidity};
Expand Down Expand Up @@ -520,6 +520,7 @@ impl Coordinator {
.metrics
.append_table_duration_seconds
.with_label_values(&[]);
info!("Appending to tables at {timestamp}, advancing to {advance_to}");
let append_fut = self
.controller
.storage
Expand Down
3 changes: 2 additions & 1 deletion src/adapter/src/coord/command_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ use mz_sql_parser::ast::{
use mz_storage_types::sources::Timeline;
use opentelemetry::trace::TraceContextExt;
use tokio::sync::{mpsc, oneshot};
use tracing::{debug_span, warn, Instrument};
use tracing::{debug_span, info, warn, Instrument};
use tracing_opentelemetry::OpenTelemetrySpanExt;

use crate::command::{
Expand Down Expand Up @@ -1149,6 +1149,7 @@ impl Coordinator {
warn!(%cmvs.name, %oracle_timestamp, %timestamp, "REFRESH MV's inputs are not readable at the oracle read ts");
}

info!("Resolved `mz_now()` to {timestamp} for REFRESH MV");
Ok(Some(timestamp))
} else {
Ok(None)
Expand Down
Loading