[copy_from] AWS source #31144
Merged
[copy_from] AWS source #31144
+676
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParkMyCar
force-pushed
the
copy/aws-source
branch
7 times, most recently
from
7defd19 to
58f62b2
Compare
5 tasks
5 tasks
ParkMyCar
force-pushed
the
copy/aws-source
branch
from
58f62b2 to
b9715b2
Compare
jkosh44
approved these changes
Jan 28, 2025
src/aws-util/src/s3.rs
Outdated
| use aws_types::sdk_config::SdkConfig; | ||
|
|
||
| pub use aws_sdk_s3::Client; | ||
| use bytes::Bytes; |
There was a problem hiding this comment.
I think this is meant to go in the other import block?
There was a problem hiding this comment.
ahh yeah I should move this up, thanks!
* add a new OneshotSource implementation * support the FILES and PATTERN options for COPY FROM
ParkMyCar
force-pushed
the
copy/aws-source
branch
from
b9715b2 to
4f8ab12
Compare
I have a bunch of tests in a stacked PR, will get those up for review! |
ParkMyCar
added a commit
that referenced
this pull request
Jan 30, 2025
_Stacked on top of_ #31144 This PR refactors ranged get requests so the logic for forming the header value is shared for both the HTTP and S3 source. It also fixes a bug where sometimes `HEAD` requests (which we use to get metadata for a file) are not supported, so we fallback to a `GET` request but quickly drop the body. ### Motivation Fix a bug in ranged HTTP requests I found in the demo today ### Tips for reviewer review only the final commit, the one titled "start, fix ranged requests" ### Checklist - [x] This PR has adequate test coverage / QA involvement has been duly considered. ([trigger-ci for additional test/nightly runs](https://trigger-ci.dev.materialize.com/)) - [x] This PR has an associated up-to-date [design doc](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/README.md), is a design doc ([template](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/00000000_template.md)), or is sufficiently small to not require a design. <!-- Reference the design in the description. --> - [x] If this PR evolves [an existing `$T ⇔ Proto$T` mapping](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/command-and-response-binary-encoding.md) (possibly in a backwards-incompatible way), then it is tagged with a `T-proto` label. - [x] If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label ([example](MaterializeInc/cloud#5021)). <!-- Ask in #team-cloud on Slack if you need help preparing the cloud PR. --> - [x] If this PR includes major [user-facing behavior changes](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/guide-changes.md#what-changes-require-a-release-note), I have pinged the relevant PM to schedule a changelog post.
ParkMyCar
added a commit
that referenced
this pull request
Jan 30, 2025
_Stacked on top of_ #31144 This PR adds a new implementation of a `OneshotFormat` that supports reading in Parquet files. The decoding is built on top of the `ArrowReader` implemented in #30958. The strategy we use for reading and decoding Parquet files is the "split work" stage of a oneshot source will read the footer metadata from a Parquet file to determine the [Row Group](https://parquet.apache.org/docs/concepts/) boundaries. The Row Groups are then distributed among timely works for fetching and eventual decoding. Note: Through experimentation I found that Row Groups seem to typically be 10s of MB large, which makes them a pretty good unit of parallelization. ### Motivation Fixes MaterializeInc/database-issues#8853 ### Tips for reviewer Review on the final commit, the one titled "start, support Parquet for COPY FROM" ### Checklist - [x] This PR has adequate test coverage / QA involvement has been duly considered. ([trigger-ci for additional test/nightly runs](https://trigger-ci.dev.materialize.com/)) - [x] This PR has an associated up-to-date [design doc](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/README.md), is a design doc ([template](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/00000000_template.md)), or is sufficiently small to not require a design. <!-- Reference the design in the description. --> - [x] If this PR evolves [an existing `$T ⇔ Proto$T` mapping](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/command-and-response-binary-encoding.md) (possibly in a backwards-incompatible way), then it is tagged with a `T-proto` label. - [x] If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label ([example](MaterializeInc/cloud#5021)). <!-- Ask in #team-cloud on Slack if you need help preparing the cloud PR. --> - [x] If this PR includes major [user-facing behavior changes](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/guide-changes.md#what-changes-require-a-release-note), I have pinged the relevant PM to schedule a changelog post.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of: #30956
This PR implements a new AwsS3
OneshotSourcethat allows copying in files from S3, e.g.Along with
FILES = [<files>]we also support aPATTERN = <glob>option which allows copying multiple files all at once.Motivation
Fixes https://github.com/MaterializeInc/database-issues/issues/8860
Fixes https://github.com/MaterializeInc/database-issues/issues/8855
Tips for reviewer
Review only the final commit, the one titled "start, implementation of an S3 oneshot source"
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.