avoid nested ifs to reduce cognitive complexity #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On aurait juste pu virer le if(cmd.cmd.startsWith("Motor")), il permettais de sortir rapidement de la fonction |
Godeffroy
force-pushed
the
fix-codesmell-nested-ifs-S134
branch
from
27c873f to
eff48ed
Compare
|
En revanche les build failed sur Github alors que sur mon PC tous les build de chaque environnement fonctionnent |
|
C'est à cause des sous dossiers que j'ai fait pour la Path Planning ! |
PercevalSA
force-pushed
the
fix-codesmell-nested-ifs-S134
branch
from
2bf7f5b to
673e7e2
Compare
|
t'as cassé tout ce que j'avais fait !!! |
Godeffroy
force-pushed
the
fix-codesmell-nested-ifs-S134
branch
from
cbcbfe4 to
d4a13cf
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
le principe ce que les ifs gèrent les edges case et non pas le déroulement classique.
Le comportement de base de ta fonction doit se trouver au premier niveau. Ensuite tu gères les exceptions et les erreurs avec des ifs ou autre.
Cela permet une meilleure lecture de la fonction, ça réduit ce qu'on appelle la complexité cognitive. ça rend le code plus simple à lire pour les développeurs.
Dans l'absolu on évite plus de 3 niveau d'imbrications de if/while/for
closes AZURSD9JeGf3pN8qsa09