Skip to content

Remove finalise method from adjoint lookup tables #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DrTVockerodtMO wants to merge 7 commits into from
Closed

Remove finalise method from adjoint lookup tables #311

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a493cb
Added clearing of member integer fields
DrTVockerodtMO Mar 3, 2026
d8069be
No need for the lookup table finaliser routine as the default destruc…
DrTVockerodtMO Mar 3, 2026
d3557ae
Merge branch 'main' into lu_cache_memory_leak_fix
DrTVockerodtMO Mar 5, 2026
6ed3f65
Merge branch 'main' into lu_cache_memory_leak_fix
DrTVockerodtMO Mar 5, 2026
3231554
Merge branch 'main' into lu_cache_memory_leak_fix
DrTVockerodtMO Mar 6, 2026
213740a
Merge branch 'main' into lu_cache_memory_leak_fix
DrTVockerodtMO Mar 10, 2026
28bb2be
Merge branch 'main' into lu_cache_memory_leak_fix
DrTVockerodtMO Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion science/adjoint/source/algorithm/lookup/adj_lookup_table_mod.x90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,8 @@ module adj_lookup_table_mod
! Arguments
class(adj_lookup_table_type), intent(inout) :: self

! Pass
call self%lookup_field%clear()
call self%set_count_field%clear()
Copy link
Collaborator

@andrewcoughtrie andrewcoughtrie Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the subroutine a finaliser as described (see my other comment) and you shouldn't need to call any of this. In fact you shouldn't be calling clear (they are only for pFUnit tests - don't ask)

Suggested change
call self%lookup_field%clear()
call self%set_count_field%clear()

Copy link
Collaborator

@andrewcoughtrie andrewcoughtrie Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned earlier you don't need this subroutine at all.


end subroutine adj_lookup_table_finaliser

Expand Down
Loading