Skip to content

Mesh stretching - Linked PR for lfric core#344

Open
cjohnson-pi wants to merge 2 commits intoMetOffice:mainfrom
cjohnson-pi:stretching
Open

Mesh stretching - Linked PR for lfric core#344
cjohnson-pi wants to merge 2 commits intoMetOffice:mainfrom
cjohnson-pi:stretching

Conversation

@cjohnson-pi
Copy link
Contributor

@cjohnson-pi cjohnson-pi commented Mar 6, 2026

PR Summary

Sci/Tech Reviewer: @jameskent-metoffice
Code Reviewer: @mo-rickywong

linked MetOffice/lfric_core#270

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - test_stretch/run1

Suite Information

Item Value
Suite Name test_stretch/run1
Suite User christine.johnson
Workflow Start 2026-03-13T14:53:08
Groups Run suite_default
Dependency Reference Main Like
casim MetOffice/[email protected] True
jules MetOffice/[email protected] True
lfric_apps cjohnson-pi/lfric_apps@stretching False
lfric_core cjohnson-pi/lfric_core@stretching True
moci MetOffice/[email protected] True
SimSys_Scripts MetOffice/[email protected] True
socrates MetOffice/[email protected] True
socrates-spectral MetOffice/[email protected] True
ukca MetOffice/[email protected] True

Task Information

❌ failed tasks - 47
Task State
check_gravity_wave_limited_300x4-BiP300x4-1000x2000_azspice_gnu_fast-debug-64bit failed
check_gravity_wave_limited_300x4-BiP300x4-1000x2000_ex1a_gnu_fast-debug-64bit failed
check_gravity_wave_limited_spherical_50x50_LAM50x50-2x2_azspice_gnu_fast-debug-64bit failed
check_gravity_wave_limited_spherical_50x50_LAM50x50-2x2_ex1a_gnu_fast-debug-64bit failed
check_gravity_wave_p1_75x4-BiP75x4-4000x2000_azspice_gnu_fast-debug-64bit failed
check_gravity_wave_p1_75x4-BiP75x4-4000x2000_ex1a_gnu_fast-debug-64bit failed
check_gungho_model_agnesi_hyd_cart-BiP120x8-2000x2000_azspice_gnu_fast-debug-64bit failed
check_gungho_model_agnesi_hyd_cart-BiP120x8-2000x2000_ex1a_gnu_fast-debug-64bit failed
check_gungho_model_bryan_fritsch-dry-BiP200x10-100x100_azspice_gnu_fast-debug-64bit failed
check_gungho_model_bryan_fritsch-dry-BiP200x10-100x100_ex1a_gnu_fast-debug-64bit failed
check_gungho_model_robert-moist-lam-BiP100x8-10x10_azspice_gnu_fast-debug-64bit failed
check_gungho_model_robert-moist-lam-BiP100x8-10x10_ex1a_gnu_fast-debug-64bit failed
check_gungho_model_robert-moist-smag-BiP100x8-10x10_azspice_gnu_fast-debug-64bit failed
check_gungho_model_robert-moist-smag-BiP100x8-10x10_ex1a_gnu_fast-debug-64bit failed
check_gungho_model_sbr_lam-n96_MG_lam_azspice_gnu_fast-debug-64bit failed
check_gungho_model_sbr_lam-n96_MG_lam_ex1a_gnu_fast-debug-64bit failed
check_gungho_model_sbr_lam-n96_MG_lam_rotate_azspice_gnu_fast-debug-64bit failed
check_gungho_model_sbr_lam-n96_MG_lam_rotate_ex1a_gnu_fast-debug-64bit failed
check_gungho_model_schar_cart-BiP200x8-500x500_azspice_gnu_fast-debug-64bit failed
check_gungho_model_schar_cart-BiP200x8-500x500_ex1a_gnu_fast-debug-64bit failed
check_gungho_model_schar_cart-alt2-BiP100x4-1000x1000_azspice_gnu_fast-debug-64bit failed
check_gungho_model_schar_cart-alt2-BiP100x4-1000x1000_ex1a_gnu_fast-debug-64bit failed
check_gungho_model_skamarock_klemp_gw_p0-BiP300x8-1000x2000_azspice_gnu_fast-debug-64bit failed
check_gungho_model_skamarock_klemp_gw_p0-BiP300x8-1000x2000_ex1a_gnu_fast-debug-64bit failed
check_gungho_model_skamarock_klemp_gw_p1-BiP75x4-4000x2000_azspice_gnu_fast-debug-64bit failed
check_gungho_model_skamarock_klemp_gw_p1-BiP75x4-4000x2000_ex1a_gnu_fast-debug-64bit failed
check_gungho_model_skamarock_klemp_gw_ph0pv1-BiP75x4-4000x2000_azspice_gnu_fast-debug-64bit failed
check_gungho_model_skamarock_klemp_gw_ph0pv1-BiP75x4-4000x2000_ex1a_gnu_fast-debug-64bit failed
check_gungho_model_skamarock_klemp_gw_ph1pv0-BiP75x4-4000x2000_azspice_gnu_fast-debug-64bit failed
check_gungho_model_skamarock_klemp_gw_ph1pv0-BiP75x4-4000x2000_ex1a_gnu_fast-debug-64bit failed
check_lfric2lfric_oasis_clim_gal9_C12-ral_seuk_C16_lam-lbc_azspice_gnu_fast-debug-64bit failed
check_lfric2lfric_oasis_clim_gal9_C12-ral_seuk_C16_lam-lbc_ex1a_cce_fast-debug-64bit failed
check_lfric2lfric_oasis_clim_gal9_C12-ral_seuk_C16_lam_azspice_gnu_fast-debug-64bit failed
check_lfric2lfric_oasis_clim_gal9_C12-ral_seuk_C16_lam_ex1a_cce_fast-debug-64bit failed
check_lfric2lfric_oasis_ral_seuk-C32_lam_MG_azspice_gnu_fast-debug-64bit failed
check_lfric2lfric_oasis_ral_seuk-C32_lam_MG_ex1a_cce_fast-debug-64bit failed
check_lfric2lfric_ral3-seuk_azspice_gnu_fast-debug-64bit failed
check_lfric2lfric_ral3-seuk_ex1a_cce_fast-debug-64bit failed
check_lfric2lfric_ral_seuk-C32_lam_MG_azspice_gnu_fast-debug-64bit failed
check_lfric2lfric_ral_seuk-C32_lam_MG_ex1a_cce_fast-debug-64bit failed
check_name_transport_sbr_hori_lam-n96_lam_azspice_gnu_fast-debug-64bit failed
check_name_transport_sbr_hori_lam-n96_lam_ex1a_gnu_fast-debug-64bit failed
check_transport_cylinder_xz_ffsl-BiP100x10-20x20_azspice_gnu_fast-debug-64bit failed
check_transport_cylinder_xz_ffsl-BiP100x10-20x20_azspice_gnu_full-debug-64bit failed
check_transport_cylinder_xz_ffsl-BiP100x10-20x20_ex1a_cce_fast-debug-64bit failed
kgo_groups_checker failed
validate_rose_meta failed
✅ succeeded tasks - 1116
⌛ waiting tasks - 2
Task State
housekeep_azspice waiting
housekeep_ex1a waiting

validate_rose_meta error message is regarding extra optional configurations that are not committed to this branch (i.e. left over from a git switch. Apologies).

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@cjohnson-pi cjohnson-pi added this to the Summer 2026 milestone Mar 6, 2026
@cjohnson-pi cjohnson-pi added Linked Core This PR is linked to a MetOffice/lfric_core PR KGO This PR contains changes to KGO labels Mar 6, 2026
@cjohnson-pi cjohnson-pi marked this pull request as ready for review March 6, 2026 17:02
Copy link
Contributor

@thomasmelvin thomasmelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with these changes from a code owner view point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

KGO This PR contains changes to KGO Linked Core This PR is linked to a MetOffice/lfric_core PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants