Mesh stretching - Linked PR for lfric core#344
Open
cjohnson-pi wants to merge 2 commits intoMetOffice:mainfrom
Open
Mesh stretching - Linked PR for lfric core#344cjohnson-pi wants to merge 2 commits intoMetOffice:mainfrom
cjohnson-pi wants to merge 2 commits intoMetOffice:mainfrom
Conversation
29 tasks
Contributor
thomasmelvin
left a comment
There was a problem hiding this comment.
I'm happy with these changes from a code owner view point
thomasmelvin
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @jameskent-metoffice
Code Reviewer: @mo-rickywong
linked MetOffice/lfric_core#270
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - test_stretch/run1
Suite Information
Task Information
❌ failed tasks - 47
⌛ waiting tasks - 2
validate_rose_meta error message is regarding extra optional configurations that are not committed to this branch (i.e. left over from a git switch. Apologies).
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review