Skip to content

Add new stretching transformation to mesh tools#270

Open
cjohnson-pi wants to merge 24 commits intoMetOffice:mainfrom
cjohnson-pi:stretching
Open

Add new stretching transformation to mesh tools#270
cjohnson-pi wants to merge 24 commits intoMetOffice:mainfrom
cjohnson-pi:stretching

Conversation

@cjohnson-pi
Copy link

@cjohnson-pi cjohnson-pi commented Feb 10, 2026

PR Summary

Sci/Tech Reviewer: @jameskent-metoffice
Code Reviewer: @mo-rickywong

Documentation:
#270 (comment)

linked MetOffice/lfric_apps#344

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

LFRic Apps Testing still to be completed.

trac.log

Test Suite Results - lfric_core - test_stretching/run11

Suite Information

Item Value
Suite Name test_stretching/run11
Suite User christine.johnson
Workflow Start 2026-03-13T14:48:49
Groups Run suite_default
Dependency Reference Main Like
lfric_core cjohnson-pi/lfric_core@stretching False
SimSys_Scripts MetOffice/SimSys_Scripts@2025.12.1 True

Task Information

✅ succeeded tasks - 390

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Feb 10, 2026
@cjohnson-pi cjohnson-pi added the KGO This PR contains changes to KGO label Feb 18, 2026
@cjohnson-pi
Copy link
Author

poly_power

@cjohnson-pi
Copy link
Author

Document describing the new stretching function and its implementation stretch.pdf

@cjohnson-pi cjohnson-pi marked this pull request as ready for review March 4, 2026 10:46
@cjohnson-pi cjohnson-pi requested review from a team and mo-rickywong as code owners March 4, 2026 10:46
@cjohnson-pi cjohnson-pi added this to the Summer 2026 milestone Mar 4, 2026
@github-actions github-actions bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Mar 5, 2026
@cjohnson-pi cjohnson-pi added the Linked Apps This PR is linked to a MetOffice/lfric_apps PR label Mar 6, 2026
@cjohnson-pi
Copy link
Author

cjohnson-pi commented Mar 6, 2026

The coordinates and the cell spacing for the new method (with various polynomial powers) and the old 'inflation' method that is currently used in the UM (in black).

with_inflation

So the new method gives similar answers to the UM inflation method.

@cjohnson-pi
Copy link
Author

The ratio of the cell spacing between neighbouring cells.

ratio

@cjohnson-pi
Copy link
Author

A non-symmetrical mesh, where the centre of the high resolution region is at (30,10).

mesh

Relevant Configuration is:
edge_cells_x = 24
edge_cells_y = 24
domain_centre = 30.0, 10.0
cell_size_inner = 0.0135,0.0135
cell_size_outer = 0.036,0.036
n_cells_outer_nsew = 1, 8, 5, 1
n_cells_stretch_nsew = 1, 1, 1, 1
poly_power = 3

@cjohnson-pi
Copy link
Author

Updated documentation (including non-symmetrical meshes) stretch.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA KGO This PR contains changes to KGO Linked Apps This PR is linked to a MetOffice/lfric_apps PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant