Skip to content

Add initial QA checks to CI/CD pipeline. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pierre-siddall wants to merge 3 commits into
base: main
Choose a base branch
from
+24 −1
Open

Add initial QA checks to CI/CD pipeline. #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae4350b
Add initial fortitude linting
Pierre-siddall Mar 11, 2026
190159a
Sign contributers agreement
Pierre-siddall Mar 11, 2026
b22d845
ignore explict interfaces error
Pierre-siddall Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/lint-fortran.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# -----------------------------------------------------------------------------
# (C) Crown copyright Met Office. All rights reserved.
# The file LICENCE, distributed with this code, contains details of the terms
# under which the code may be used.
# -----------------------------------------------------------------------------

name: Lint Fortran

on:
pull_request:

jobs:
fortitude-lint:
uses: MetOffice/growss/.github/workflows/fortran-lint.yaml@main
with:
runner: "ubuntu-24.04"
3 changes: 2 additions & 1 deletion CONTRIBUTORS.md
View file
Open in desktop
Copy link
Collaborator

@yaswant yaswant Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit-picking really: Please format the the Markdown properly.

Copy link
Author

@Pierre-siddall Pierre-siddall Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly to my comment in #24 this markdown should be fine as users with long usernames would have to add loads of spacing to the names above them.

Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@
| ----------- | --------- | ----------- | ---- |
| james-bruten-mo | James Bruten | Met Office | 2025-12-09 |
| mo-jmanners | James Manners | Met Office | 2025-12-18 |
| t00sa | Sam Clarke-Green | Met Office | 20226-03-02 |
| t00sa | Sam Clarke-Green | Met Office | 2026-03-02 |
| Pierre-siddall| Pierre Siddall | Met Office | 2026-03-11|
6 changes: 6 additions & 0 deletions fortitude.toml
View file
Open in desktop
Copy link
Collaborator

@yaswant yaswant Mar 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"C082" pointer-initialisation-in-declaration is currently in preview for fortitude-v0.8.0 (stable), which means it's only active when the --preview flag (or preview = true in config file) is used. Since we're still using v0.7.3 in growss, there may be other rules in this list that are also in preview.

Also, can you check if renaming the config file to .fortitude.toml works with v0.7.3

Copy link
Author

@Pierre-siddall Pierre-siddall Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this by using fortitude check with the preview rules removed maybe addition of preview rules could be added as an input option in the growss action? But given that the preview rules are not failing the pipeline and are skipped over with warnings the current configuration of the fortitude.toml should be fine, and I'll rename the file as it looks safe to do so in the current documentation.

Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[check]
select=["E000","C031","C032","C043","C051",
"C082","C141","OB011","OB021","OB051",
"OB061","MOD001","PORT011","PORT012","PORT021",
"FORT001","FORT002","FORT003","FORT004","FORT005"]
ignore=["C091"]
Loading