Add initial QA checks to CI/CD pipeline.#23
Open
Pierre-siddall wants to merge 3 commits intoMetOffice:mainfrom
Open
Add initial QA checks to CI/CD pipeline.#23Pierre-siddall wants to merge 3 commits intoMetOffice:mainfrom
Pierre-siddall wants to merge 3 commits intoMetOffice:mainfrom
Conversation
Author
|
Given that the C091 checks raised warnings about the implementation of 22 different interfaces. It was decided for now this rule will be switched off in order to avoid large big bang style code changes. |
25 tasks
yaswant
reviewed
Mar 17, 2026
Collaborator
There was a problem hiding this comment.
Nit-picking really: Please format the the Markdown properly.
Collaborator
There was a problem hiding this comment.
"C082" pointer-initialisation-in-declaration is currently in preview for fortitude-v0.8.0 (stable), which means it's only active when the --preview flag (or preview = true in config file) is used. Since we're still using v0.7.3 in growss, there may be other rules in this list that are also in preview.
Also, can you check if renaming the config file to .fortitude.toml works with v0.7.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: @yaswant
Similarly to MetOffice/lfric_apps#200 and MetOffice/lfric_core#258 ukca needs some initial code quality checks to be performed. With the move to fortitude to lint fortran this PR uses the growss repository to invoke a reusable workflow which lints a predefined set of rules outlined in a
fortitude.tomlfile.closes #2
is blocked-by #24
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
readability of the code
Testing
stem suites
acceptable (eg. kgo changes)
tests, unit tests, etc.)
trac.log
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review