Open
Conversation
25 tasks
yaswant
reviewed
Mar 17, 2026
Collaborator
yaswant
left a comment
There was a problem hiding this comment.
This looks good to me. Perhaps worth getting a quick nod from @mo-jmanners
Collaborator
There was a problem hiding this comment.
Please format markdown properly.
Member
|
Thanks Yash, looks fine to me. Could you please add me as code owner for everything except the src/cosp_control and src/cosp_github directories which are owned by Stephan Havemann (@Petzi1). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: @yaswant
This PR fixes labeling issues found by the fortitude linter to ensure that the pipeline for #23 can pass.
is related to #2
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
readability of the code
Testing
stem suites
acceptable (eg. kgo changes)
tests, unit tests, etc.)
trac.log
Test Suite Results - um - test-socrates-fortitude/run1
Suite Information
Approvals
Code Owners
Config Owners
No UM Config Owners Required
Task Information
✅ succeeded tasks - 881
Test Suite Results - lfric_apps - test-socrates-fortitude-lfric/run1
Suite Information
Task Information
✅ succeeded tasks - 1164
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review