Skip to content

Fix fortitude linting issues#24

Open
Pierre-siddall wants to merge 2 commits intoMetOffice:mainfrom
Pierre-siddall:fix-fortitude-errors
Open

Fix fortitude linting issues#24
Pierre-siddall wants to merge 2 commits intoMetOffice:mainfrom
Pierre-siddall:fix-fortitude-errors

Conversation

@Pierre-siddall
Copy link

@Pierre-siddall Pierre-siddall commented Mar 16, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer: @yaswant

This PR fixes labeling issues found by the fortitude linter to ensure that the pipeline for #23 can pass.

is related to #2

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid undertanding and enhance the
    readability of the code
  • My changes generate no new warnings

Testing

  • If shared files have been modified, I have run the UM and LFRic Apps rose
    stem suites
  • If any tests fail (rose-stem or CI) the reason is understood and
    acceptable (eg. kgo changes)
  • I have added tests to cover new functionality as appropriate (eg. system
    tests, unit tests, etc.)

trac.log

Test Suite Results - um - test-socrates-fortitude/run1

Suite Information

Item Value
Suite Name test-socrates-fortitude/run1
Suite User pierre.siddall
Workflow Start 2026-03-16T09:01:11
Groups Run developer
Dependency Reference Main Like
casim MetOffice/casim@2026.03.1 True
jules MetOffice/jules@2026.03.1 True
moci MetOffice/moci@2026.03.1 True
mule MetOffice/mule@2026.03.1 True
shumlib MetOffice/shumlib@2026.03.1 True
socrates Pierre-siddall/socrates@fix-fortitude-errors False
SimSys_Scripts MetOffice/SimSys_Scripts@2026.03.1 True
ukca MetOffice/ukca@2026.03.1 True
um Pierre-siddall/um@f32cbf4 True
um_aux MetOffice/um_aux@2026.03.1 True
um_meta MetOffice/um_meta@2026.03.1 True

Approvals

Code Owners

  • No UM Code Owners Required

Config Owners

No UM Config Owners Required

Task Information

✅ succeeded tasks - 881

Test Suite Results - lfric_apps - test-socrates-fortitude-lfric/run1

Suite Information

Item Value
Suite Name test-socrates-fortitude-lfric/run1
Suite User pierre.siddall
Workflow Start 2026-03-16T09:42:55
Groups Run developer
Dependency Reference Main Like
casim MetOffice/casim@2026.03.2 True
jules MetOffice/jules@2026.03.2 True
lfric_apps MetOffice/lfric_apps@2c1e1b4 True
lfric_core MetOffice/lfric_core@6c47d43 True
moci MetOffice/moci@2026.03.2 True
SimSys_Scripts MetOffice/SimSys_Scripts@2026.03.2 True
socrates Pierre-siddall/socrates@fix-fortitude-errors False
socrates-spectral MetOffice/socrates-spectral@2026.03.2 True
ukca MetOffice/ukca@2026.03.2 True

Task Information

✅ succeeded tasks - 1164

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable
    performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance
    of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
    Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
    Simulation Systems AI policy
    (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and
    confirmed that it builds correctly

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@Pierre-siddall Pierre-siddall self-assigned this Mar 16, 2026
@Pierre-siddall Pierre-siddall added the enhancement New feature or request label Mar 16, 2026
@github-actions github-actions bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Mar 16, 2026
@github-actions github-actions bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Mar 16, 2026
@Pierre-siddall Pierre-siddall marked this pull request as draft March 16, 2026 09:27
@Pierre-siddall Pierre-siddall marked this pull request as ready for review March 16, 2026 10:58
@james-bruten-mo james-bruten-mo requested a review from yaswant March 17, 2026 09:10
Copy link
Collaborator

@yaswant yaswant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Perhaps worth getting a quick nod from @mo-jmanners

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format markdown properly.

@mo-jmanners
Copy link
Member

Thanks Yash, looks fine to me.

Could you please add me as code owner for everything except the src/cosp_control and src/cosp_github directories which are owned by Stephan Havemann (@Petzi1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants