perf: memoize getNumberOfAllUnapprovedTransactionsAndMessages selector #39041

cryptotavares · 2026-01-06T14:46:14Z

Description

The getNumberOfAllUnapprovedTransactionsAndMessages selector was unmemoized and created new objects via spread operators on every state change, causing unnecessary recomputations in a critical hot path (app header badge count).

This PR implements several optimizations:

Memoization: Converts to a memoized selector using reselect's createSelector
Reference equality: Uses standard createSelector since Redux/Immer provides stable input references
Direct count summation: Sums Object.keys().length directly instead of spreading objects into a merged object, which:
- Reduces memory allocation from O(N) to O(1)
- Eliminates potential ID collision bugs (if tx/message IDs overlapped, spread would overwrite and undercount)
- Only allocates arrays when inputs actually change (memoization prevents recomputation on stable refs)

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6380

Manual testing steps

Open MetaMask extension
Navigate to a dapp and initiate a transaction
Verify the badge count in the header updates correctly
Verify no regression in badge count functionality

Screenshots/Recordings

Not applicable - internal performance optimization with no UI changes.

Before

N/A

After

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Optimizes a hot-path selector used for the header badge count.

Converts getNumberOfAllUnapprovedTransactionsAndMessages to a memoized createSelector
Avoids object spreads by summing Object.keys(...).length across sources with nullish guards
Reduces unnecessary recomputation and memory allocation; removes risk of ID collisions from object merging

^{Written by Cursor Bugbot for commit 4a406e7. This will update automatically on new commits. Configure here.}

github-actions · 2026-01-06T14:46:25Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Shallow equality O(n) is sufficient since inputs come from Immer-managed state with stable references, avoiding expensive deep equality O(n×d).

metamaskbotv2 · 2026-01-06T23:39:10Z

Builds ready [9c84545]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1309 ± 101 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1309	1090	1645	101	1382	1465
			load	1088	880	1397	99	1153	1230
			domContentLoaded	1082	877	1390	99	1149	1224
			domInteractive	27	16	105	19	24	86
			firstPaint	143	66	301	61	189	282
			backgroundConnect	220	202	256	11	227	244
			firstReactRender	15	9	40	5	16	24
			getState	35	17	115	14	37	70
			initialActions	1	0	4	1	1	2
			loadScripts	869	673	1149	99	938	1017
			setupStore	12	6	60	7	12	17
			numNetworkReqs	17	11	77	16	11	67
	Browserify	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
	Webpack	Standard Home	uiStartup	835	656	1172	103	887	1052
			load	667	581	944	79	719	831
			domContentLoaded	662	575	939	79	711	825
			domInteractive	26	16	113	19	22	84
			firstPaint	108	58	330	57	133	227
			backgroundConnect	28	5	117	30	34	107
			firstReactRender	17	11	47	6	19	32
			getState	36	15	73	15	47	64
			initialActions	1	0	3	1	1	1
			loadScripts	659	573	936	77	708	817
			setupStore	13	5	74	9	14	32
			numNetworkReqs	17	11	85	17	11	66
	Webpack	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
Firefox	Browserify	Standard Home	uiStartup	1403	1099	1982	181	1525	1690
			load	1127	942	1731	139	1203	1393
			domContentLoaded	1127	942	1730	139	1202	1393
			domInteractive	69	32	234	42	89	156
			firstPaint	-	-	-	-	-	-
			backgroundConnect	62	20	274	54	96	184
			firstReactRender	12	9	25	2	13	17
			getState	14	6	139	17	11	40
			initialActions	1	0	2	1	1	2
			loadScripts	1086	927	1702	122	1138	1315
			setupStore	17	4	260	29	12	48
			numNetworkReqs	19	9	89	20	14	77
	Browserify	Power User Home	uiStartup	2402	1440	3875	501	2747	2999
			load	1684	988	2356	466	2085	2307
			domContentLoaded	1684	988	2356	466	2085	2306
			domInteractive	84	35	871	98	86	252
			firstPaint	-	-	-	-	-	-
			backgroundConnect	337	22	1086	338	353	995
			firstReactRender	19	11	52	8	23	36
			getState	108	57	854	111	103	202
			initialActions	2	0	9	1	2	3
			loadScripts	1446	969	2194	405	1871	2143
			setupStore	42	5	916	95	44	139
			numNetworkReqs	67	19	183	34	78	155
	Webpack	Standard Home	uiStartup	1629	1330	2504	208	1738	2070
			load	1339	1112	1827	120	1403	1513
			domContentLoaded	1339	1111	1827	120	1401	1512
			domInteractive	77	29	332	43	95	132
			firstPaint	-	-	-	-	-	-
			backgroundConnect	63	23	269	47	71	155
			firstReactRender	16	11	56	8	17	27
			getState	21	6	141	30	14	118
			initialActions	1	1	3	1	2	2
			loadScripts	1301	1097	1739	103	1351	1481
			setupStore	24	3	251	38	16	123
			numNetworkReqs	19	9	82	18	14	72
	Webpack	Power User Home	uiStartup	2721	1653	4724	624	3136	3603
			load	2004	1200	2976	514	2467	2616
			domContentLoaded	2004	1199	2976	514	2467	2616
			domInteractive	103	29	886	156	89	413
			firstPaint	-	-	-	-	-	-
			backgroundConnect	350	30	1357	367	410	1118
			firstReactRender	23	13	143	16	25	54
			getState	102	58	258	37	105	182
			initialActions	2	0	4	1	2	3
			loadScripts	1748	1146	2789	455	2178	2518
			setupStore	53	5	1071	142	44	191
			numNetworkReqs	67	21	181	35	78	158

📊 Page Load Benchmark Results

Current Commit: 9c84545 | Date: 1/6/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.02s (±37ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 710ms (±35ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 74ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.02s	37ms	994ms	1.30s	1.04s	1.30s
domContentLoaded	710ms	35ms	690ms	976ms	723ms	976ms
firstPaint	74ms	11ms	60ms	164ms	84ms	164ms
firstContentfulPaint	74ms	11ms	60ms	164ms	84ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 0 Bytes (0%)
common: 237 Bytes (0%)

- Switch to createSelector (reference equality) since Redux/Immer provides stable input references - Sum Object.keys lengths directly instead of spreading objects - Avoids O(N) memory allocation and potential ID collision issues

metamaskbotv2 · 2026-01-07T14:54:07Z

Builds ready [4a406e7]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1289 ± 110 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1289	1051	1525	110	1362	1480
			load	1074	861	1320	101	1123	1247
			domContentLoaded	1066	857	1310	100	1115	1238
			domInteractive	26	14	97	19	23	85
			firstPaint	225	65	1199	246	201	1085
			backgroundConnect	216	199	243	11	225	238
			firstReactRender	14	9	34	5	16	24
			getState	35	18	73	10	39	59
			initialActions	1	0	5	1	1	2
			loadScripts	859	658	1096	99	909	1020
			setupStore	11	7	32	4	12	17
			numNetworkReqs	17	11	71	16	11	67
	Browserify	Power User Home	uiStartup	1786	1453	2141	142	1866	2046
			load	1094	913	1425	119	1172	1329
			domContentLoaded	1081	908	1410	118	1158	1316
			domInteractive	34	18	257	34	28	114
			firstPaint	190	73	1343	179	214	383
			backgroundConnect	269	211	584	86	271	528
			firstReactRender	16	11	31	3	17	20
			getState	167	130	288	29	178	223
			initialActions	1	0	2	1	1	2
			loadScripts	855	693	1192	118	929	1092
			setupStore	15	7	54	8	14	39
			numNetworkReqs	66	54	131	17	63	116
	Webpack	Standard Home	uiStartup	781	647	1130	84	823	956
			load	637	572	892	70	653	795
			domContentLoaded	632	568	886	70	649	789
			domInteractive	25	15	123	21	21	77
			firstPaint	110	59	329	60	151	228
			backgroundConnect	23	5	110	25	33	96
			firstReactRender	15	10	30	4	17	24
			getState	32	14	57	12	43	52
			initialActions	1	0	5	1	1	2
			loadScripts	629	566	878	68	646	779
			setupStore	12	5	39	7	14	26
			numNetworkReqs	18	11	79	18	11	73
	Webpack	Power User Home	uiStartup	1248	948	1738	183	1344	1640
			load	770	612	1207	110	866	946
			domContentLoaded	763	604	1195	109	860	938
			domInteractive	34	18	201	32	28	116
			firstPaint	138	68	323	71	197	269
			backgroundConnect	76	8	612	151	59	543
			firstReactRender	18	14	35	3	19	24
			getState	148	122	260	20	156	171
			initialActions	1	0	2	0	1	2
			loadScripts	759	601	1182	107	853	933
			setupStore	16	8	67	9	14	35
			numNetworkReqs	68	53	224	27	63	127
Firefox	Browserify	Standard Home	uiStartup	1472	1085	2362	229	1581	1957
			load	1182	931	1993	198	1243	1691
			domContentLoaded	1182	926	1992	198	1243	1691
			domInteractive	89	32	954	124	91	181
			firstPaint	-	-	-	-	-	-
			backgroundConnect	64	18	226	55	73	196
			firstReactRender	13	9	27	3	13	19
			getState	12	6	56	8	12	27
			initialActions	1	0	3	1	2	2
			loadScripts	1143	917	1968	186	1174	1566
			setupStore	14	4	137	15	13	41
			numNetworkReqs	19	9	85	19	14	75
	Browserify	Power User Home	uiStartup	2341	1464	3774	497	2707	2880
			load	1656	1000	2472	478	2060	2287
			domContentLoaded	1656	1000	2472	478	2060	2287
			domInteractive	84	35	399	74	83	258
			firstPaint	-	-	-	-	-	-
			backgroundConnect	309	27	1041	345	334	1007
			firstReactRender	19	12	52	7	24	27
			getState	93	53	235	32	109	139
			initialActions	2	1	7	1	2	3
			loadScripts	1416	984	2276	424	1884	2204
			setupStore	25	5	251	35	22	97
			numNetworkReqs	75	52	145	27	101	127
	Webpack	Standard Home	uiStartup	1586	1317	2352	199	1669	2019
			load	1328	1130	1764	130	1394	1628
			domContentLoaded	1328	1129	1764	130	1394	1628
			domInteractive	77	29	232	44	100	143
			firstPaint	-	-	-	-	-	-
			backgroundConnect	58	21	223	44	62	162
			firstReactRender	17	10	108	11	16	25
			getState	18	6	168	27	15	81
			initialActions	1	0	3	1	2	2
			loadScripts	1294	1109	1676	114	1347	1528
			setupStore	18	5	128	23	15	87
			numNetworkReqs	19	9	86	19	14	73
	Webpack	Power User Home	uiStartup	2725	1728	4202	552	3095	3565
			load	2063	1222	3011	518	2490	2706
			domContentLoaded	2062	1221	3011	518	2490	2706
			domInteractive	89	30	633	105	86	325
			firstPaint	-	-	-	-	-	-
			backgroundConnect	376	28	1215	391	461	1148
			firstReactRender	21	12	62	9	26	30
			getState	96	57	201	28	101	149
			initialActions	2	0	7	1	2	3
			loadScripts	1754	1147	2843	473	2237	2525
			setupStore	24	4	194	37	17	118
			numNetworkReqs	74	45	167	30	82	144

📊 Page Load Benchmark Results

Current Commit: 4a406e7 | Date: 1/7/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±37ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 722ms (±35ms) 🟢 | historical mean value: 726ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±9ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	37ms	1.02s	1.31s	1.07s	1.31s
domContentLoaded	722ms	35ms	700ms	986ms	751ms	986ms
firstPaint	76ms	9ms	60ms	152ms	88ms	152ms
firstContentfulPaint	76ms	9ms	60ms	152ms	88ms	152ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 430 Bytes (0.01%)
ui: 2.52 KiB (0.03%)
common: 3.11 KiB (0.03%)

perf: memoize getNumberOfAllUnapprovedTransactionsAndMessages selector

54597f0

cryptotavares force-pushed the fix/memoize-getNumberOfAllUnapprovedTransactionsAndMessages branch from bb6e19c to 54597f0 Compare January 6, 2026 22:58

cryptotavares temporarily deployed to pr-comment January 6, 2026 22:58 — with GitHub Actions Inactive

github-actions bot added the size-S label Jan 6, 2026

perf: use createShallowEqualSelector for better performance

9c84545

Shallow equality O(n) is sufficient since inputs come from Immer-managed state with stable references, avoiding expensive deep equality O(n×d).

cryptotavares temporarily deployed to pr-comment January 6, 2026 23:05 — with GitHub Actions Inactive

cryptotavares temporarily deployed to pr-comment January 6, 2026 23:34 — with GitHub Actions Inactive

perf: optimize selector with direct count summation

4a406e7

- Switch to createSelector (reference equality) since Redux/Immer provides stable input references - Sum Object.keys lengths directly instead of spreading objects - Avoids O(N) memory allocation and potential ID collision issues

cryptotavares temporarily deployed to pr-comment January 7, 2026 14:21 — with GitHub Actions Inactive

cryptotavares temporarily deployed to pr-comment January 7, 2026 14:49 — with GitHub Actions Inactive

cryptotavares marked this pull request as ready for review January 7, 2026 17:33

cryptotavares temporarily deployed to pr-comment January 7, 2026 17:33 — with GitHub Actions Inactive

cryptotavares added the team-confirmations Push issues to confirmations team label Jan 7, 2026

OGPoyraz approved these changes Jan 7, 2026

View reviewed changes

jpuri approved these changes Jan 8, 2026

View reviewed changes

cryptotavares added this pull request to the merge queue Jan 8, 2026

Merged via the queue into main with commit 3fe3d5f Jan 8, 2026
185 of 186 checks passed

cryptotavares deleted the fix/memoize-getNumberOfAllUnapprovedTransactionsAndMessages branch January 8, 2026 11:46

github-actions bot locked and limited conversation to collaborators Jan 8, 2026

metamaskbot added the release-13.14.0 Issue or pull request that will be included in release 13.14.0 label Jan 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

perf: memoize getNumberOfAllUnapprovedTransactionsAndMessages selector #39041

perf: memoize getNumberOfAllUnapprovedTransactionsAndMessages selector #39041

cryptotavares commented Jan 6, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

metamaskbotv2 bot commented Jan 6, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Jan 7, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

perf: memoize getNumberOfAllUnapprovedTransactionsAndMessages selector #39041

perf: memoize getNumberOfAllUnapprovedTransactionsAndMessages selector #39041

Conversation

cryptotavares commented Jan 6, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

metamaskbotv2 bot commented Jan 6, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Jan 7, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cryptotavares commented Jan 6, 2026 •

edited by cursor bot

Loading