Skip to content

perf: memoize getNumberOfAllUnapprovedTransactionsAndMessages selector #39041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cryptotavares merged 3 commits into from
Jan 8, 2026
+21 −13
Merged

perf: memoize getNumberOfAllUnapprovedTransactionsAndMessages selector #39041

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54597f0
perf: memoize getNumberOfAllUnapprovedTransactionsAndMessages selector
cryptotavares Jan 6, 2026
9c84545
perf: use createShallowEqualSelector for better performance
cryptotavares Jan 6, 2026
4a406e7
perf: optimize selector with direct count summation
cryptotavares Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions ui/selectors/selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2472,19 +2472,27 @@ export function getShowRecoveryPhraseReminder(state) {
* @param state - Redux state object.
* @returns Number of unapproved transactions
*/
export function getNumberOfAllUnapprovedTransactionsAndMessages(state) {
const unapprovedTxs = getUnapprovedTransactions(state);

const allUnapprovedMessages = {
...unapprovedTxs,
...state.metamask.unapprovedDecryptMsgs,
...state.metamask.unapprovedPersonalMsgs,
...state.metamask.unapprovedEncryptionPublicKeyMsgs,
...state.metamask.unapprovedTypedMessages,
};
const numUnapprovedMessages = Object.keys(allUnapprovedMessages).length;
return numUnapprovedMessages;
}
export const getNumberOfAllUnapprovedTransactionsAndMessages = createSelector(
[
getUnapprovedTransactions,
(state) => state.metamask.unapprovedDecryptMsgs,
(state) => state.metamask.unapprovedPersonalMsgs,
(state) => state.metamask.unapprovedEncryptionPublicKeyMsgs,
(state) => state.metamask.unapprovedTypedMessages,
],
(
unapprovedTxs,
unapprovedDecryptMsgs,
unapprovedPersonalMsgs,
unapprovedEncryptionPublicKeyMsgs,
unapprovedTypedMessages,
) =>
Object.keys(unapprovedTxs ?? {}).length +
Object.keys(unapprovedDecryptMsgs ?? {}).length +
Object.keys(unapprovedPersonalMsgs ?? {}).length +
Object.keys(unapprovedEncryptionPublicKeyMsgs ?? {}).length +
Object.keys(unapprovedTypedMessages ?? {}).length,
);

export const getCurrentNetwork = createDeepEqualSelector(
getNetworkConfigurationsByChainId,
Expand Down
Loading