-
Notifications
You must be signed in to change notification settings - Fork 5.5k
chore: update webpack and related deps #39055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
@metamaskbot update-policies |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution MetaMask internal reviewing guidelines:
Ignoring alerts on: |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
a395420 to
0363e29
Compare
|
@metamaskbot update-policies |
|
Policy update failed. You can review the logs or retry the policy update here |
✨ Files requiring CODEOWNER review ✨📜 @MetaMask/policy-reviewers (2 files, +24 -15)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. |
|
@metamaskbot update-policies |
|
Policy update failed. You can review the logs or retry the policy update here |
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Builds ready [2c45442]
UI Startup Metrics (1260 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [9779cd4]
UI Startup Metrics (1275 ± 105 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
@SocketSecurity ignore npm/[email protected] |
| "console.log": true, | ||
| "console.warn": true, | ||
| "process.exit": true | ||
| "process": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
concerning? 🤔
| // Unsafe layer plugin that applies the layer and assigns the unsafeEntries to it | ||
| export const lavamoatUnsafeLayerPlugin: WebpackPluginInstance = { | ||
| apply: (compiler) => { | ||
| compiler.options.experiments.layers = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removal of experiments.layers may break LavaMoat layer isolation
High Severity
The line compiler.options.experiments.layers = true was removed, but the plugin still uses webpack's layer functionality via issuerLayer: 'unsafe' and entryData.options.layer. Webpack's layers feature requires experiments.layers to be enabled. If not enabled by default in webpack 5.104.1, this would cause the unsafe layer isolation to silently fail—security-sensitive entries (scripts/inpage.js, bootstrap, service-worker.ts) that should run outside LavaMoat protection may not be properly isolated. This could be a silent security regression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its default in webpack now
Description
Update webpack and related deps.
Changelog
CHANGELOG entry: null
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Updates the build toolchain and security policies to align with newer webpack and plugin releases.
webpackto^5.104.1and updates related deps:terser^5.44.1,terser-webpack-plugin^5.3.16,copy-webpack-plugin^13.0.1,html-bundler-webpack-plugin^4.22.0,@pmmmwh/react-refresh-webpack-plugin^0.6.2; refreshesyarn.lockand transitive deps (e.g.,browserslist,es-module-lexer,enhanced-resolve,schema-utils).policy.json/policy-override.jsonpackage mappings (notablyeslint-scopepaths), tweaks allowed globals (console.info,console.trace,process), and adds explicit entries for new scopes.LavamoatPlugin/index.ts, stops settingcompiler.options.experiments.layers, keeping the unsafe layer rule/assignment logic unchanged.Written by Cursor Bugbot for commit 9779cd4. This will update automatically on new commits. Configure here.