release: 13.13.2 #39065
Open
release: 13.13.2 #39065
+49
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metamaskbot
added
team-bots
…o 1.17.0 (#39067) - chore: bump @metamask/tron-wallet-snap to 1.17.0 (#38986) CHANGELOG entry: Bump @metamask/tron-wallet-snap to 1.17.0 --------- Co-authored-by: Ulisses Ferreira <[email protected]> Co-authored-by: MetaMask Bot <[email protected]>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
--------- Co-authored-by: Ulisses Ferreira <[email protected]> Co-authored-by: MetaMask Bot <[email protected]> Co-authored-by: Alejandro Garcia Anglada <[email protected]>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
HowardBraham
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
✨ Files requiring CODEOWNER review ✨📜 @MetaMask/policy-reviewers (7 files, +14 -14)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. |
HowardBraham
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
Builds ready [9a31195]
UI Startup Metrics (1220 ± 97 ms)
|
chloeYue
previously approved these changes
Jan 7, 2026
HowardBraham
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
HowardBraham
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
| }, | ||
| "browserify>url>qs": { | ||
| "mockttp>express>qs": { |
There was a problem hiding this comment.
Lavamoat policy references dev dependency path for production module
Medium Severity
The qs module policy entry changed from browserify>url>qs to mockttp>express>qs, but mockttp is a devDependency not included in production builds. The policy now grants browserify>url access to mockttp>express>qs, which may cause a module identity mismatch at runtime. If Lavamoat cannot match the production qs module (accessed via browserify>url) to the policy entry keyed under a dev dependency path, security sandboxing for the qs module may not be correctly applied. This affects all Lavamoat policy files across browserify and webpack builds.
🔬 Verification Test
Why verification test was not possible:
This requires running the actual MetaMask extension build with Lavamoat enabled to verify whether the policy is correctly applied at runtime. The issue depends on Lavamoat's internal module identity resolution mechanism, which cannot be tested without the full build infrastructure. The concern is that the policy generator used mockttp>express>qs as the canonical name during development (when mockttp is present), but in production the module would be identified differently since mockttp isn't bundled.
Additional Locations (2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 v13.13.2 Testing & Release Quality Process
Hi Team,
As part of our new MetaMask Release Quality Process, here’s a quick overview of the key processes, testing strategies, and milestones to ensure a smooth and high-quality deployment.
📋 Key Processes
Testing Strategy
Conduct regression and exploratory testing for your functional areas, including automated and manual tests for critical workflows.
Focus on exploratory testing across the wallet, prioritize high-impact areas, and triage any Sentry errors found during testing.
Validate new functionalities and provide feedback to support release monitoring.
GitHub Signoff
Issue Resolution
Cherry-Picking Criteria
🗓️ Timeline and Milestones
✅ Signoff Checklist
Each team is responsible for signing off via GitHub. Use the checkbox below to track signoff completion:
Team sign-off checklist
This process is a major step forward in ensuring release stability and quality. Let’s stay aligned and make this release a success! 🚀
Feel free to reach out if you have questions or need clarification.
Many thanks in advance
Reference
Note
Prepares v13.13.2 release with dependency and CI updates.
13.13.2and updatesCHANGELOG.mdlinks/entries@metamask/tron-wallet-snapto^1.17.0and@metamask/keyring-apito^21.3.0; pinsqsto^6.14.1and refreshesyarn.lock/attribution.txtmockttp>express>qsinstead ofbrowserify>url>qsenvironment: pr-commentto CI jobs (E2E failure alerts, identify-codeowners, publish-prerelease) for PR commentingWritten by Cursor Bugbot for commit 2205f3c. This will update automatically on new commits. Configure here.