-
Notifications
You must be signed in to change notification settings - Fork 5.5k
release: 13.13.2 #39065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
metamaskbot
wants to merge
11
commits into
stable
Choose a base branch
from
release/13.13.2
base: stable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+107
−90
Open
release: 13.13.2 #39065
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8008f5c
bump semvar version to 13.13.2
metamaskbot 526692e
release(runway): cherry-pick chore: bump @metamask/tron-wallet-snap t…
runway-github[bot] 0c715de
bump: necessary packages cp-13.13.2 (#39066)
zone-live da7e59e
release: update CHANGELOG
HowardBraham a2fb2d5
release(cp): chore(security): Set yarn resolution for `qs` to patch v…
MajorLift 9a31195
release(cp): ci: Replace expired token with scoped `pr-comment` token…
Gudahtt 2205f3c
fixed invisible characters in CHANGELOG
HowardBraham b5649c0
release(runway): cherry-pick bump: Update react router to resolve ad…
runway-github[bot] 286310b
release(runway): cherry-pick chore: bump @metamask/tron-wallet-snap t…
runway-github[bot] 9c06a05
release: update CHANGELOG
HowardBraham 402fc1f
release(runway): cherry-pick fix(tron): max energy and bandwidth inco…
runway-github[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lavamoat policy references dev dependency path for production module
Medium Severity
The
qsmodule policy entry changed frombrowserify>url>qstomockttp>express>qs, butmockttpis a devDependency not included in production builds. The policy now grantsbrowserify>urlaccess tomockttp>express>qs, which may cause a module identity mismatch at runtime. If Lavamoat cannot match the productionqsmodule (accessed viabrowserify>url) to the policy entry keyed under a dev dependency path, security sandboxing for theqsmodule may not be correctly applied. This affects all Lavamoat policy files across browserify and webpack builds.🔬 Verification Test
Why verification test was not possible:
This requires running the actual MetaMask extension build with Lavamoat enabled to verify whether the policy is correctly applied at runtime. The issue depends on Lavamoat's internal module identity resolution mechanism, which cannot be tested without the full build infrastructure. The concern is that the policy generator used
mockttp>express>qsas the canonical name during development (whenmockttpis present), but in production the module would be identified differently sincemockttpisn't bundled.Additional Locations (2)
lavamoat/browserify/main/policy.json#L5593-L5594lavamoat/webpack/mv3/policy.json#L3286-L3291