Skip to content

Conversation

@V00D00-child
Copy link
Member

@V00D00-child V00D00-child commented Jan 7, 2026

Description

  • Bump @metamask/gator-permissions-controller 0.8.0 -> 0.9.0
  • Handle submitDirectRevocation(params: RevocationParams) interface breaking change. The function now requires a revocationMetadata property in the RevocationParams object.

Related issues

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@V00D00-child V00D00-child added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-delegation MetaMask Delegation Team labels Jan 7, 2026
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 7, 2026
@github-actions github-actions bot added the size-S label Jan 7, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 7, 2026

Builds ready [7f88c9f]
UI Startup Metrics (1288 ± 96 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1288103715909613461467
load108388213048511381191
domContentLoaded107788013008411321172
domInteractive2716117212489
firstPaint1616133272201307
backgroundConnect22020225912224245
firstReactRender1593651626
getState3418114133956
initialActions104112
loadScripts864667109185921972
setupStore1272941423
numNetworkReqs171179161165
BrowserifyPower User HomeuiStartup17401419237618018122098
load1063888134710411451239
domContentLoaded1053881134110311341225
domInteractive3017112202887
firstPaint172661202128212334
backgroundConnect24820256270242431
firstReactRender14112821518
getState16612627929184225
initialActions102111
loadScripts83667911301019111018
setupStore1675181536
numNetworkReqs65521962062119
WebpackStandard HomeuiStartup811661106881863969
load65158383966665802
domContentLoaded64657783566658796
domInteractive2616108192281
firstPaint1065960769122206
backgroundConnect2651553132100
firstReactRender15103141725
getState3316126174560
initialActions103111
loadScripts64357483364655790
setupStore1364381531
numNetworkReqs171176171169
WebpackPower User HomeuiStartup1142924170514711881548
load711590113387733883
domContentLoaded705583112887727862
domInteractive30171622626103
firstPaint1256338769155258
backgroundConnect5075457668107
firstReactRender16132121720
getState14112221516146172
initialActions103111
loadScripts702580111985724860
setupStore1493861334
numNetworkReqs65512082261121
FirefoxBrowserifyStandard HomeuiStartup13251081230518614051675
load1069898206114911281296
domContentLoaded1069898206114911281296
domInteractive73319229288134
firstPaint------
backgroundConnect52212874561159
firstReactRender1292121216
getState116110121027
initialActions102122
loadScripts1038885196013310961218
setupStore14595141143
numNetworkReqs19980191376
BrowserifyPower User HomeuiStartup25001494406359229333293
load1727978266155622322518
domContentLoaded1726978266055622322518
domInteractive71332205073209
firstPaint------
backgroundConnect3582412243804511103
firstReactRender2211147162550
getState1046022036123192
initialActions217123
loadScripts1447955240846919742301
setupStore36599010321155
numNetworkReqs73521613077150
WebpackStandard HomeuiStartup15591296226818416651898
load13141109168513013871595
domContentLoaded13141109168513013871594
domInteractive762916138114135
firstPaint------
backgroundConnect64212724979164
firstReactRender14102831520
getState198215291651
initialActions103022
loadScripts12731087165510813301511
setupStore194200281588
numNetworkReqs19984191474
WebpackPower User HomeuiStartup24641539319344228703034
load18451132253644222402451
domContentLoaded18451132253644222402451
domInteractive68322966365267
firstPaint------
backgroundConnect273231035313278995
firstReactRender201378102442
getState84591542191122
initialActions204123
loadScripts16281113238437620032240
setupStore3957879925128
numNetworkReqs74491643088139
📊 Page Load Benchmark Results

Current Commit: 7f88c9f | Date: 1/7/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±69ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 744ms (±64ms) 🟢 | historical mean value: 723ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±13ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 69ms 1.02s 1.37s 1.28s 1.37s
domContentLoaded 744ms 64ms 705ms 1.02s 953ms 1.02s
firstPaint 78ms 13ms 60ms 192ms 88ms 192ms
firstContentfulPaint 78ms 13ms 60ms 192ms 88ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 1.61 KiB (0.02%)
  • common: 363 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-S team-delegation MetaMask Delegation Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants