Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added gator-permissions-controller-0.9.0-pre-build.tgz
Binary file not shown.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@
"@metamask/eth-trezor-keyring": "^9.0.0",
"@metamask/etherscan-link": "^3.0.0",
"@metamask/gas-fee-controller": "^25.0.0",
"@metamask/gator-permissions-controller": "^0.8.0",
"@metamask/gator-permissions-controller": "file:./gator-permissions-controller-0.9.0-pre-build.tgz",
"@metamask/gator-permissions-snap": "^0.7.0",
"@metamask/institutional-wallet-snap": "1.3.4",
"@metamask/jazzicon": "patch:@metamask/jazzicon@npm%3A2.0.0#~/.yarn/patches/@metamask-jazzicon-npm-2.0.0-36957be38d.patch",
Expand Down
5 changes: 4 additions & 1 deletion ui/hooks/gator-permissions/useRevokeGatorPermissions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,10 @@ export function useRevokeGatorPermissions({

if (isDisabled) {
// Return null since no actual transaction is needed when already disabled
await submitDirectRevocation({ permissionContext });
await submitDirectRevocation({
permissionContext,
revocationMetadata: {}, // We provide empty metadata since no transaction is needed when already disabled
});
return null;
}

Expand Down
8 changes: 7 additions & 1 deletion ui/store/controller-actions/gator-permissions-controller.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
import { GatorPermissionsMap } from '@metamask/gator-permissions-controller';
import {
GatorPermissionsMap,
RevocationMetadata,

Check failure on line 3 in ui/store/controller-actions/gator-permissions-controller.ts

View workflow job for this annotation

GitHub Actions / test-lint / Test lint

Module '"@metamask/gator-permissions-controller"' has no exported member 'RevocationMetadata'.
} from '@metamask/gator-permissions-controller';
import { Hex } from '@metamask/utils';
import { submitRequestToBackground } from '../background-connection';

Expand Down Expand Up @@ -46,15 +49,18 @@
*
* @param params - The parameters for direct revocation.
* @param params.permissionContext - The permission context to revoke.
* @param params.revocationMetadata - The metadata for the revocation.
*/
export const submitDirectRevocation = async ({
permissionContext,
}: {
permissionContext: Hex;
revocationMetadata: RevocationMetadata;
}): Promise<void> => {
await submitRequestToBackground('submitDirectRevocation', [
{
permissionContext,
revocationMetadata,

Check failure on line 63 in ui/store/controller-actions/gator-permissions-controller.ts

View workflow job for this annotation

GitHub Actions / test-lint / Test lint

No value exists in scope for the shorthand property 'revocationMetadata'. Either declare one or provide an initializer.
},
]);
};
Expand Down
20 changes: 19 additions & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6823,6 +6823,24 @@ __metadata:
languageName: node
linkType: hard

"@metamask/gator-permissions-controller@file:./gator-permissions-controller-0.9.0-pre-build.tgz::locator=metamask-crx%40workspace%3A.":
version: 0.8.0
resolution: "@metamask/gator-permissions-controller@file:./gator-permissions-controller-0.9.0-pre-build.tgz#./gator-permissions-controller-0.9.0-pre-build.tgz::hash=6c7e56&locator=metamask-crx%40workspace%3A."
dependencies:
"@metamask/7715-permission-types": "npm:^0.4.0"
"@metamask/base-controller": "npm:^9.0.0"
"@metamask/delegation-core": "npm:^0.2.0"
"@metamask/delegation-deployments": "npm:^0.12.0"
"@metamask/messenger": "npm:^0.3.0"
"@metamask/snaps-controllers": "npm:^14.0.1"
"@metamask/snaps-sdk": "npm:^9.0.0"
"@metamask/snaps-utils": "npm:^11.0.0"
"@metamask/transaction-controller": "npm:^62.7.0"
"@metamask/utils": "npm:^11.8.1"
checksum: 10/4caf3f6c58a83a937431c4b8017010e04b45723156aeeb248881a59fb7bed7f04f8706134b5aebd07b08aae7cba8709fe2d1453b4fabd180c51066c56aa1ac40
languageName: node
linkType: hard

"@metamask/gator-permissions-controller@npm:^0.8.0":
version: 0.8.0
resolution: "@metamask/gator-permissions-controller@npm:0.8.0"
Expand Down Expand Up @@ -32854,7 +32872,7 @@ __metadata:
"@metamask/forwarder": "npm:^1.1.0"
"@metamask/foundryup": "npm:^1.0.1"
"@metamask/gas-fee-controller": "npm:^25.0.0"
"@metamask/gator-permissions-controller": "npm:^0.8.0"
"@metamask/gator-permissions-controller": "file:./gator-permissions-controller-0.9.0-pre-build.tgz"
"@metamask/gator-permissions-snap": "npm:^0.7.0"
"@metamask/institutional-wallet-snap": "npm:1.3.4"
"@metamask/jazzicon": "patch:@metamask/jazzicon@npm%3A2.0.0#~/.yarn/patches/@metamask-jazzicon-npm-2.0.0-36957be38d.patch"
Expand Down
Loading