chore: apply feedback from PR #39005

[gantunesr]

Description

Apply feedback left on PR #39005

Changelog

CHANGELOG entry: null

Related issues

Fixes: NA

Manual testing steps

Not applicable

Screenshots/Recordings

Not applicable

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Minor refactors in multi-SRP components.

• In srp-card.tsx, replace short-circuit invocation with an explicit if (keyringId) { onActionComplete(...) } guard on card click
• In srp-list.tsx, rename walletIdsFromStore to entropyWalletIds and update mapping to use entropy wallet IDs

^{Written by Cursor Bugbot for commit 1b69ec5. This will update automatically on new commits. Configure here.}

[metamaskbotv2]

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (2 files, +5 -3)

• 📁 ui/
  • 📁 components/
    • 📁 multichain/
      • 📁 multi-srp/
        • 📁 srp-list/
          • 📄 srp-card.tsx +3 -1
          • 📄 srp-list.tsx +2 -2

---

👨‍🔧 @MetaMask/core-extension-ux (2 files, +5 -3)

• 📁 ui/
  • 📁 components/
    • 📁 multichain/
      • 📁 multi-srp/
        • 📁 srp-list/
          • 📄 srp-card.tsx +3 -1
          • 📄 srp-list.tsx +2 -2

[metamaskbotv2]

Builds ready [520242c]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1312 ± 100 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1312	1084	1577	100	1376	1447
			load	1086	913	1340	87	1142	1195
			domContentLoaded	1080	908	1333	87	1136	1187
			domInteractive	27	16	85	15	24	69
			firstPaint	171	63	1101	146	206	295
			backgroundConnect	226	207	266	12	232	257
			firstReactRender	16	9	168	16	16	26
			getState	39	19	82	14	44	70
			initialActions	1	0	6	1	1	3
			loadScripts	860	682	1129	88	916	968
			setupStore	13	8	42	6	14	24
			numNetworkReqs	17	11	71	15	11	60
	Browserify	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
	Webpack	Standard Home	uiStartup	801	646	1106	76	852	915
			load	639	573	867	63	656	782
			domContentLoaded	633	568	850	62	649	771
			domInteractive	25	16	98	19	20	85
			firstPaint	119	57	321	64	164	252
			backgroundConnect	34	5	125	34	48	112
			firstReactRender	15	11	40	4	17	23
			getState	34	14	145	21	43	58
			initialActions	1	0	7	1	1	2
			loadScripts	630	565	847	61	646	762
			setupStore	12	7	41	7	13	30
			numNetworkReqs	18	11	77	18	11	71
	Webpack	Power User Home	uiStartup	1262	935	1929	216	1343	1769
			load	761	607	1177	114	870	945
			domContentLoaded	754	601	1168	114	864	939
			domInteractive	33	18	155	30	28	118
			firstPaint	141	65	836	100	166	329
			backgroundConnect	63	7	605	147	16	540
			firstReactRender	17	13	27	2	18	21
			getState	145	123	201	14	151	181
			initialActions	1	0	3	1	1	1
			loadScripts	750	598	1158	113	861	933
			setupStore	16	10	46	9	15	40
			numNetworkReqs	66	53	209	22	61	117
Firefox	Browserify	Standard Home	uiStartup	1417	1120	2685	216	1493	1749
			load	1137	946	2117	167	1196	1416
			domContentLoaded	1136	946	2117	167	1196	1416
			domInteractive	68	32	162	37	89	151
			firstPaint	-	-	-	-	-	-
			backgroundConnect	60	21	200	49	74	185
			firstReactRender	13	10	38	3	13	17
			getState	13	6	117	14	11	24
			initialActions	1	0	2	1	1	2
			loadScripts	1097	932	2032	149	1144	1292
			setupStore	13	4	166	19	11	39
			numNetworkReqs	19	9	84	19	14	74
	Browserify	Power User Home	uiStartup	2396	1513	3108	460	2767	2953
			load	1642	1013	2472	476	2121	2275
			domContentLoaded	1642	1013	2471	476	2120	2274
			domInteractive	91	36	871	102	93	247
			firstPaint	-	-	-	-	-	-
			backgroundConnect	383	23	1135	391	860	1021
			firstReactRender	19	12	53	6	25	28
			getState	95	62	304	41	103	145
			initialActions	2	1	3	1	2	2
			loadScripts	1339	996	2323	364	1303	2074
			setupStore	46	6	1003	139	22	162
			numNetworkReqs	74	52	185	30	100	137
	Webpack	Standard Home	uiStartup	1608	1280	2367	217	1682	2090
			load	1338	1138	1950	148	1395	1679
			domContentLoaded	1337	1137	1950	148	1395	1679
			domInteractive	70	29	214	41	86	143
			firstPaint	-	-	-	-	-	-
			backgroundConnect	61	21	325	45	71	140
			firstReactRender	16	11	63	7	17	25
			getState	22	8	216	38	15	151
			initialActions	1	0	2	1	2	2
			loadScripts	1299	1109	1835	131	1364	1624
			setupStore	19	4	203	28	15	74
			numNetworkReqs	19	9	88	19	14	77
	Webpack	Power User Home	uiStartup	2677	1777	3527	500	3043	3353
			load	2041	1237	2953	513	2475	2653
			domContentLoaded	2040	1237	2953	513	2474	2653
			domInteractive	76	31	419	68	80	183
			firstPaint	-	-	-	-	-	-
			backgroundConnect	343	26	1190	369	370	1130
			firstReactRender	20	13	75	9	25	33
			getState	100	63	208	30	106	174
			initialActions	2	1	7	1	2	3
			loadScripts	1761	1205	2789	443	2204	2482
			setupStore	30	5	985	100	19	90
			numNetworkReqs	70	43	151	29	71	138

📊 Page Load Benchmark Results

Current Commit: 520242c | Date: 1/7/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.04s (±42ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
• domContentLoaded-> current mean value: 708ms (±39ms) 🟢 | historical mean value: 723ms ⬇️ (historical data)
• firstContentfulPaint-> current mean value: 76ms (±15ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	42ms	1.01s	1.36s	1.06s	1.36s
domContentLoaded	708ms	39ms	687ms	1.01s	735ms	1.01s
firstPaint	76ms	15ms	60ms	212ms	88ms	212ms
firstContentfulPaint	76ms	15ms	60ms	212ms	88ms	212ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 96 Bytes (0%)
• ui: 343 Bytes (0%)
• common: 20 Bytes (0%)

[metamaskbotv2]

Builds ready [1b69ec5]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1321 ± 123 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1321	1078	1681	123	1402	1544
			load	1109	886	1435	117	1179	1347
			domContentLoaded	1102	882	1418	115	1173	1340
			domInteractive	27	16	123	20	23	92
			firstPaint	157	65	1093	114	190	290
			backgroundConnect	217	196	255	10	223	240
			firstReactRender	14	10	28	3	15	22
			getState	36	21	96	13	41	69
			initialActions	1	0	4	1	1	1
			loadScripts	892	680	1188	115	962	1116
			setupStore	12	7	36	5	13	26
			numNetworkReqs	17	11	74	16	11	67
	Browserify	Power User Home	uiStartup	1737	1450	2072	154	1833	2046
			load	1045	874	1260	105	1129	1238
			domContentLoaded	1036	867	1252	104	1117	1224
			domInteractive	29	17	127	21	26	86
			firstPaint	159	70	1242	132	204	331
			backgroundConnect	237	200	553	50	242	273
			firstReactRender	14	11	25	2	15	19
			getState	176	122	669	74	188	223
			initialActions	1	0	3	1	1	2
			loadScripts	823	674	1047	101	896	1017
			setupStore	16	6	44	8	16	36
			numNetworkReqs	65	52	136	18	62	117
	Webpack	Standard Home	uiStartup	765	627	965	67	816	881
			load	615	558	798	59	633	740
			domContentLoaded	610	553	791	59	628	732
			domInteractive	24	14	84	17	20	78
			firstPaint	111	57	581	71	145	249
			backgroundConnect	36	5	153	37	62	120
			firstReactRender	14	10	35	4	16	25
			getState	29	14	113	14	38	53
			initialActions	1	0	4	1	1	1
			loadScripts	607	550	784	58	626	726
			setupStore	11	5	35	5	12	22
			numNetworkReqs	18	11	82	18	11	72
	Webpack	Power User Home	uiStartup	1173	941	1698	157	1227	1542
			load	728	608	1069	95	772	912
			domContentLoaded	721	603	1065	94	765	905
			domInteractive	30	17	135	25	26	102
			firstPaint	130	64	376	67	169	254
			backgroundConnect	56	7	551	108	58	415
			firstReactRender	17	13	29	3	18	21
			getState	139	123	189	12	144	163
			initialActions	1	0	2	0	1	1
			loadScripts	718	601	1056	93	762	896
			setupStore	14	7	40	6	14	37
			numNetworkReqs	66	53	206	22	62	123
Firefox	Browserify	Standard Home	uiStartup	1373	1077	1864	171	1477	1675
			load	1106	919	1608	126	1177	1319
			domContentLoaded	1105	919	1608	126	1176	1319
			domInteractive	68	32	213	40	89	147
			firstPaint	-	-	-	-	-	-
			backgroundConnect	60	20	335	54	68	176
			firstReactRender	12	9	36	3	13	17
			getState	13	6	130	17	11	27
			initialActions	1	0	5	1	2	2
			loadScripts	1070	904	1583	117	1132	1253
			setupStore	13	5	107	13	11	29
			numNetworkReqs	19	9	81	19	14	74
	Browserify	Power User Home	uiStartup	2551	1529	6389	677	2901	3258
			load	1710	1025	2656	545	2199	2537
			domContentLoaded	1710	1025	2656	545	2198	2536
			domInteractive	84	32	308	68	88	272
			firstPaint	-	-	-	-	-	-
			backgroundConnect	423	29	1151	419	979	1114
			firstReactRender	21	11	66	10	25	48
			getState	97	58	222	26	106	155
			initialActions	2	1	3	1	2	3
			loadScripts	1392	1008	2486	415	1501	2257
			setupStore	25	5	228	38	19	98
			numNetworkReqs	75	49	151	27	101	128
	Webpack	Standard Home	uiStartup	1581	1327	2317	175	1664	1890
			load	1307	1125	1853	115	1367	1509
			domContentLoaded	1307	1125	1853	115	1366	1508
			domInteractive	84	30	335	46	110	146
			firstPaint	-	-	-	-	-	-
			backgroundConnect	58	20	199	38	65	135
			firstReactRender	15	11	33	4	16	24
			getState	19	8	155	25	17	36
			initialActions	1	0	3	1	2	2
			loadScripts	1272	1109	1669	101	1337	1476
			setupStore	23	6	119	30	19	106
			numNetworkReqs	20	9	91	20	15	78
	Webpack	Power User Home	uiStartup	2602	1724	3466	495	3001	3296
			load	1936	1085	2795	499	2402	2582
			domContentLoaded	1936	1084	2795	499	2402	2582
			domInteractive	67	29	365	72	59	283
			firstPaint	-	-	-	-	-	-
			backgroundConnect	342	23	1346	366	387	1103
			firstReactRender	21	12	86	12	25	50
			getState	102	57	1164	111	95	176
			initialActions	1	0	3	1	2	2
			loadScripts	1671	1071	2593	417	2078	2351
			setupStore	34	4	965	100	20	130
			numNetworkReqs	75	51	163	32	73	152

📊 Page Load Benchmark Results

Current Commit: 1b69ec5 | Date: 1/7/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.04s (±40ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
• domContentLoaded-> current mean value: 723ms (±38ms) 🟢 | historical mean value: 724ms ⬇️ (historical data)
• firstContentfulPaint-> current mean value: 77ms (±9ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	40ms	1.01s	1.34s	1.07s	1.34s
domContentLoaded	723ms	38ms	699ms	1.01s	745ms	1.01s
firstPaint	77ms	9ms	60ms	152ms	84ms	152ms
firstContentfulPaint	77ms	9ms	60ms	152ms	84ms	152ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 58 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 20 Bytes (0%)