Skip to content

chore: apply feedback from PR #39005 #39077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gantunesr merged 2 commits into from
Jan 8, 2026
+5 −3
Merged

chore: apply feedback from PR #39005 #39077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
520242c
chore: apply feedback from PR #39005
gantunesr Jan 7, 2026
1b69ec5
Merge branch 'main' into chore/39005-feedback
gantunesr Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ui/components/multichain/multi-srp/srp-list/srp-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,9 @@ export const SrpCard = ({
button_type: 'srp_select',
},
});
keyringId && onActionComplete(keyringId, shouldTriggerBackup);
if (keyringId) {
onActionComplete(keyringId, shouldTriggerBackup);
}
}}
className="select-srp__container"
marginBottom={3}
Expand Down
4 changes: 2 additions & 2 deletions ui/components/multichain/multi-srp/srp-list/srp-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const SrpList = ({
getIsPrimarySeedPhraseBackedUp,
);

const walletIdsFromStore = useSelector((state) =>
const entropyWalletIds = useSelector((state) =>
getWalletIdsByType(state, AccountWalletType.Entropy),
);

Expand All @@ -33,7 +33,7 @@ export const SrpList = ({
padding={isSettingsPage ? 0 : 4}
data-testid="srp-list"
>
{walletIdsFromStore.map((walletId, index) => {
{entropyWalletIds.map((walletId, index) => {
// We only consider the first(primary) keyring for the backup reminder.
const shouldTriggerBackup = !isPrimarySeedPhraseBackedUp && index === 0;

Expand Down
Loading