refactor(confirmations): replace inline naming-convention disables with file-level disables #39079

cryptotavares · 2026-01-07T19:41:35Z

Description

This PR addresses the new ESLint rule @typescript-eslint/naming-convention that was introduced in PR #32106 to prevent snake_case naming.

Instead of having many individual // eslint-disable-next-line @typescript-eslint/naming-convention comments scattered throughout files (primarily metrics-related files that use snake_case for analytics properties), this change consolidates them into a single file-level /* eslint-disable @typescript-eslint/naming-convention */ directive for files with more than 5 occurrences.

Changes:

Files with >5 inline disable comments now use a file-level disable with a TODO comment linking to issue [Typescript-eslint] Fix @typescript-eslint/naming-convention violations #31860
Files with ≤5 occurrences remain unchanged (keeping their individual inline disables)
Reduces code noise while maintaining the same ESLint behavior

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4992

Manual testing steps

Run yarn lint to verify ESLint passes
Verify the modified files still have proper snake_case naming allowed where needed

Screenshots/Recordings

Not applicable - code cleanup only.

Before

Files had many repeated inline disable comments:

// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
account_snap_type: 'snaptype',
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
account_snap_version: 'snapversion',

After

Single file-level disable at the top:

// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
/* eslint-disable @typescript-eslint/naming-convention */
import { ... } from '...';

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Streamlines lint suppression for snake_case analytics fields without changing runtime behavior.

Adds /* eslint-disable @typescript-eslint/naming-convention */ (with issue TODO) at top of files with many occurrences; removes per-line disables in transaction-data.tsx, simulation and alert metrics hooks/tests, and transaction metrics tests
No logic changes; only comment/lint directive consolidation to reduce noise

^{Written by Cursor Bugbot for commit 658372d. This will update automatically on new commits. Configure here.}

…th file-level disables Convert files with >5 `eslint-disable-next-line @typescript-eslint/naming-convention` comments to use a single file-level `/* eslint-disable */` directive instead. This reduces code noise while maintaining the same ESLint behavior for files that heavily use snake_case naming (primarily metrics-related files).

github-actions · 2026-01-07T19:41:44Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-01-07T19:42:18Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (8 files, +15 -317)

📁 app/
- 📁 scripts/
  - 📁 lib/
    - 📁 transaction/
      - 📄 metrics.test.ts +1 -166
📁 ui/
- 📁 pages/
  - 📁 confirmations/
    - 📁 components/
      - 📁 confirm/
        
        📁 info/
        
        📁 shared/
        
        📁 transaction-data/
        
        📄 transaction-data.tsx +2 -14
      - 📁 simulation-details/
        
        📄 useSimulationMetrics.test.ts +2 -24
        
        📄 useSimulationMetrics.ts +2 -18
    - 📁 hooks/
      - 📁 alerts/
        
        📄 useShieldCoverageAlert.test.ts +2 -15
        
        📄 useConfirmationAlertMetrics.test.ts +2 -28
        
        📄 useConfirmationAlertMetrics.ts +2 -26
        
        📄 useDecodedSignatureMetrics.test.ts +2 -26

🔐 @MetaMask/web3auth (1 files, +2 -15)

📁 ui/
- 📁 pages/
  - 📁 confirmations/
    - 📁 hooks/
      - 📁 alerts/
        
        📄 useShieldCoverageAlert.test.ts +2 -15

metamaskbotv2 · 2026-01-07T20:14:16Z

Builds ready [658372d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1253 ± 104 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1253	999	1706	104	1320	1378
			load	1053	841	1424	98	1121	1187
			domContentLoaded	1046	835	1415	97	1110	1179
			domInteractive	26	14	128	21	22	80
			firstPaint	203	58	1434	231	188	1019
			backgroundConnect	204	180	253	12	209	229
			firstReactRender	15	8	35	5	17	25
			getState	35	18	76	12	42	61
			initialActions	1	0	7	1	1	3
			loadScripts	849	651	1217	98	909	989
			setupStore	12	7	29	5	13	25
			numNetworkReqs	18	11	76	19	11	73
	Browserify	Power User Home	uiStartup	1769	1313	2462	207	1853	2187
			load	1074	886	1374	114	1163	1269
			domContentLoaded	1063	878	1346	114	1157	1261
			domInteractive	34	17	235	35	28	97
			firstPaint	189	71	1367	201	212	382
			backgroundConnect	239	199	568	49	244	286
			firstReactRender	14	11	24	2	16	19
			getState	168	124	277	31	184	240
			initialActions	1	0	3	1	1	2
			loadScripts	846	676	1128	110	936	1045
			setupStore	17	6	47	9	17	38
			numNetworkReqs	65	54	140	17	62	117
	Webpack	Standard Home	uiStartup	813	662	1074	86	843	1002
			load	654	585	878	73	686	815
			domContentLoaded	649	581	873	72	680	811
			domInteractive	26	15	116	20	22	82
			firstPaint	112	60	356	62	153	253
			backgroundConnect	25	5	110	25	36	82
			firstReactRender	16	11	37	5	17	28
			getState	32	15	75	13	42	58
			initialActions	1	0	3	1	1	2
			loadScripts	645	578	864	71	677	803
			setupStore	14	7	44	9	14	40
			numNetworkReqs	17	11	74	17	11	67
	Webpack	Power User Home	uiStartup	1187	934	1944	183	1239	1574
			load	721	589	1194	102	809	892
			domContentLoaded	714	584	1178	101	799	885
			domInteractive	30	17	131	26	25	107
			firstPaint	132	61	388	73	184	309
			backgroundConnect	57	6	567	109	65	480
			firstReactRender	16	13	33	3	17	20
			getState	149	129	213	14	156	175
			initialActions	1	0	2	0	1	1
			loadScripts	711	582	1168	100	792	878
			setupStore	13	9	42	7	13	36
			numNetworkReqs	66	51	199	23	61	125
Firefox	Browserify	Standard Home	uiStartup	1400	1109	2239	197	1520	1772
			load	1122	944	1910	153	1190	1388
			domContentLoaded	1122	939	1910	154	1190	1388
			domInteractive	69	31	163	37	91	147
			firstPaint	-	-	-	-	-	-
			backgroundConnect	59	16	246	54	67	195
			firstReactRender	12	10	43	4	13	16
			getState	16	6	195	26	13	28
			initialActions	1	0	3	1	2	2
			loadScripts	1088	928	1887	135	1144	1302
			setupStore	15	5	189	22	12	53
			numNetworkReqs	19	9	78	19	14	74
	Browserify	Power User Home	uiStartup	2613	1531	3529	544	3073	3313
			load	1686	987	2644	579	2310	2522
			domContentLoaded	1686	987	2644	579	2304	2522
			domInteractive	84	34	419	77	84	302
			firstPaint	-	-	-	-	-	-
			backgroundConnect	414	29	1234	462	1078	1174
			firstReactRender	22	12	71	11	25	53
			getState	98	56	228	29	101	156
			initialActions	2	0	3	1	2	3
			loadScripts	1334	967	2397	381	1371	2247
			setupStore	60	5	1120	179	27	198
			numNetworkReqs	75	54	158	28	93	142
	Webpack	Standard Home	uiStartup	1507	1221	2292	165	1577	1809
			load	1266	1081	1536	99	1327	1462
			domContentLoaded	1265	1081	1536	99	1327	1462
			domInteractive	72	27	197	38	91	141
			firstPaint	-	-	-	-	-	-
			backgroundConnect	52	19	171	34	61	127
			firstReactRender	16	11	132	12	15	22
			getState	16	7	101	13	16	40
			initialActions	1	0	3	1	2	2
			loadScripts	1236	1067	1501	90	1289	1412
			setupStore	16	5	168	24	12	57
			numNetworkReqs	19	9	76	18	15	73
	Webpack	Power User Home	uiStartup	2719	1636	3910	566	3146	3424
			load	2051	1183	3143	554	2534	2709
			domContentLoaded	2050	1182	3138	554	2534	2709
			domInteractive	73	28	355	61	71	219
			firstPaint	-	-	-	-	-	-
			backgroundConnect	361	20	1222	402	411	1185
			firstReactRender	21	13	158	16	22	33
			getState	113	57	1140	110	114	174
			initialActions	2	1	7	1	2	3
			loadScripts	1763	1160	2977	451	2250	2435
			setupStore	32	4	1061	109	18	101
			numNetworkReqs	75	50	171	31	84	150

📊 Page Load Benchmark Results

Current Commit: 658372d | Date: 1/7/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±39ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 730ms (±37ms) 🟢 | historical mean value: 723ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	39ms	1.02s	1.34s	1.08s	1.34s
domContentLoaded	730ms	37ms	710ms	1.01s	750ms	1.01s
firstPaint	78ms	12ms	60ms	180ms	88ms	180ms
firstContentfulPaint	78ms	12ms	60ms	180ms	88ms	180ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 96 Bytes (0%)
ui: 343 Bytes (0%)
common: 20 Bytes (0%)

cryptotavares temporarily deployed to pr-comment January 7, 2026 19:41 — with GitHub Actions Inactive

metamaskbot added the team-product-safety Push issues to Product Safety team label Jan 7, 2026

github-actions bot added the size-M label Jan 7, 2026

cryptotavares marked this pull request as ready for review January 7, 2026 19:44

cryptotavares requested review from a team as code owners January 7, 2026 19:44

cryptotavares temporarily deployed to pr-comment January 7, 2026 19:44 — with GitHub Actions Inactive

cryptotavares temporarily deployed to pr-comment January 7, 2026 20:09 — with GitHub Actions Inactive

pedronfigueiredo approved these changes Jan 9, 2026

View reviewed changes

jpuri approved these changes Jan 9, 2026

View reviewed changes

cryptotavares added this pull request to the merge queue Jan 9, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2026

cryptotavares added this pull request to the merge queue Jan 9, 2026

HowardBraham removed this pull request from the merge queue due to a manual request Jan 10, 2026

HowardBraham added this pull request to the merge queue Jan 10, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2026

HowardBraham added this pull request to the merge queue Jan 10, 2026

Merged via the queue into main with commit 44e05d9 Jan 10, 2026
346 of 349 checks passed

HowardBraham deleted the cryptotavares/disable-snake-case-rule-at-file-level branch January 10, 2026 03:41

github-actions bot locked and limited conversation to collaborators Jan 10, 2026

metamaskbot added the release-13.15.0 Issue or pull request that will be included in release 13.15.0 label Jan 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(confirmations): replace inline naming-convention disables with file-level disables #39079

refactor(confirmations): replace inline naming-convention disables with file-level disables #39079

cryptotavares commented Jan 7, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

metamaskbotv2 bot commented Jan 7, 2026

Uh oh!

metamaskbotv2 bot commented Jan 7, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

refactor(confirmations): replace inline naming-convention disables with file-level disables #39079

refactor(confirmations): replace inline naming-convention disables with file-level disables #39079

Conversation

cryptotavares commented Jan 7, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

metamaskbotv2 bot commented Jan 7, 2026

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 bot commented Jan 7, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cryptotavares commented Jan 7, 2026 •

edited by cursor bot

Loading