Skip to content

refactor(confirmations): replace inline naming-convention disables with file-level disables #39079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HowardBraham merged 1 commit into from
Jan 10, 2026
Merged

refactor(confirmations): replace inline naming-convention disables with file-level disables #39079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
167 changes: 1 addition & 166 deletions app/scripts/lib/transaction/metrics.test.ts
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 2 additions & 14 deletions ui/pages/confirmations/components/confirm/info/shared/transaction-data/transaction-data.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
/* eslint-disable @typescript-eslint/naming-convention */
import React from 'react';
import { TransactionMeta } from '@metamask/transaction-controller';
import { hexStripZeros } from '@ethersproject/bytes';
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
import _ from 'lodash';
import { Hex, isHexString } from '@metamask/utils';

Expand Down Expand Up @@ -128,8 +128,6 @@ export const TransactionData = ({
);
};

// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
export function Container({
children,
isLoading,
Expand Down Expand Up @@ -164,8 +162,6 @@ export function Container({
);
}

// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
function RawDataRow({ transactionData }: { transactionData: string }) {
const t = useI18nContext();
return (
Expand All @@ -178,8 +174,6 @@ function RawDataRow({ transactionData }: { transactionData: string }) {
);
}

// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
function FunctionContainer({
method,
source,
Expand Down Expand Up @@ -237,8 +231,6 @@ function FunctionContainer({
);
}

// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
function ParamValue({
param,
source,
Expand Down Expand Up @@ -275,8 +267,6 @@ function ParamValue({
return <ConfirmInfoRowText text={valueString} />;
}

// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
function ParamRow({
param,
index,
Expand Down Expand Up @@ -315,8 +305,6 @@ function ParamRow({
);
}

// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
function UniswapPath({
pathPools,
chainId,
Expand Down
26 changes: 2 additions & 24 deletions ui/pages/confirmations/components/simulation-details/useSimulationMetrics.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
/* eslint-disable @typescript-eslint/naming-convention */
import { useContext, useEffect, useState } from 'react';
import {
SimulationData,
Expand Down Expand Up @@ -169,8 +171,6 @@ describe('useSimulationMetrics', () => {
expect(updateTransactionEventFragmentMock).toHaveBeenCalledWith(
expect.objectContaining({
properties: expect.objectContaining({
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
simulation_latency: LOADING_TIME_MOCK,
}),
}),
Expand Down Expand Up @@ -207,8 +207,6 @@ describe('useSimulationMetrics', () => {
},
expect.objectContaining({
properties: expect.objectContaining({
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
simulation_response: simulationResponse,
}),
}),
Expand Down Expand Up @@ -544,20 +542,10 @@ describe('useSimulationMetrics', () => {
category: MetaMetricsEventCategory.Transactions,
event: MetaMetricsEventName.SimulationIncompleteAssetDisplayed,
properties: {
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
asset_address: ADDRESS_MOCK,
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
asset_petname: PetnameType.Unknown,
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
asset_symbol: undefined,
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
asset_type: AssetType.ERC20,
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
fiat_conversion_available: FiatType.Available,
location: 'confirmation',
},
Expand All @@ -583,20 +571,10 @@ describe('useSimulationMetrics', () => {
category: MetaMetricsEventCategory.Transactions,
event: MetaMetricsEventName.SimulationIncompleteAssetDisplayed,
properties: {
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
asset_address: ADDRESS_MOCK,
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
asset_petname: PetnameType.Saved,
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
asset_symbol: SYMBOL_MOCK,
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
asset_type: AssetType.ERC20,
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
fiat_conversion_available: FiatType.NotAvailable,
location: 'confirmation',
},
Expand Down
20 changes: 2 additions & 18 deletions ui/pages/confirmations/components/simulation-details/useSimulationMetrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
/* eslint-disable @typescript-eslint/naming-convention */
import {
SimulationData,
SimulationErrorCode,
Expand Down Expand Up @@ -104,11 +106,7 @@ export function useSimulationMetrics({
const simulationLatency = loadingTime;

const properties = {
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
simulation_response: simulationResponse,
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
simulation_latency: simulationLatency,
...getProperties(
receivingAssets,
Expand Down Expand Up @@ -176,20 +174,10 @@ function useIncompleteAssetEvent(
event: MetaMetricsEventName.SimulationIncompleteAssetDisplayed,
category: MetaMetricsEventCategory.Transactions,
properties: {
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
asset_address: change.asset.address,
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
asset_petname: getPetnameType(change, displayName),
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
asset_symbol: displayName?.contractDisplayName,
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
asset_type: getAssetType(change.asset.standard),
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
fiat_conversion_available: change.fiatAmount
? FiatType.Available
: FiatType.NotAvailable,
Expand Down Expand Up @@ -229,8 +217,6 @@ function getProperties(
const totalValue = totalFiat ? Math.abs(totalFiat) : undefined;

return getPrefixProperties(
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
{ petname, quantity, type, value, total_value: totalValue },
prefix,
);
Expand Down Expand Up @@ -310,8 +296,6 @@ function getSimulationResponseType(
return SimulationResponseType.Changes;
}

// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
function unique<T>(list: T[]): T[] {
return Array.from(new Set(list));
}
17 changes: 2 additions & 15 deletions ui/pages/confirmations/hooks/alerts/useShieldCoverageAlert.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
/* eslint-disable @typescript-eslint/naming-convention */
import { TransactionType } from '@metamask/transaction-controller';
import { renderHookWithConfirmContextProvider } from '../../../../../test/lib/confirmations/render-helpers';
import {
Expand Down Expand Up @@ -170,11 +172,8 @@ describe('useShieldCoverageAlert', () => {
expect(updateTransactionEventFragmentMock).toHaveBeenCalledWith(
expect.objectContaining({
properties: {
// eslint-disable-next-line @typescript-eslint/naming-convention
shield_result: 'covered',
// eslint-disable-next-line @typescript-eslint/naming-convention
shield_reason: 'shieldCoverageAlertCovered',
// eslint-disable-next-line @typescript-eslint/naming-convention
shield_result_response_latency_ms: 150,
},
}),
Expand All @@ -188,11 +187,8 @@ describe('useShieldCoverageAlert', () => {
expect(updateTransactionEventFragmentMock).toHaveBeenCalledWith(
expect.objectContaining({
properties: {
// eslint-disable-next-line @typescript-eslint/naming-convention
shield_result: 'not_covered_malicious',
// eslint-disable-next-line @typescript-eslint/naming-convention
shield_reason: 'shieldCoverageAlertMessagePotentialRisks',
// eslint-disable-next-line @typescript-eslint/naming-convention
shield_result_response_latency_ms: 'N/A',
},
}),
Expand All @@ -206,11 +202,8 @@ describe('useShieldCoverageAlert', () => {
expect(updateTransactionEventFragmentMock).toHaveBeenCalledWith(
expect.objectContaining({
properties: {
// eslint-disable-next-line @typescript-eslint/naming-convention
shield_result: 'not_covered',
// eslint-disable-next-line @typescript-eslint/naming-convention
shield_reason: 'shieldCoverageAlertMessagePotentialRisks',
// eslint-disable-next-line @typescript-eslint/naming-convention
shield_result_response_latency_ms: 'N/A',
},
}),
Expand All @@ -224,11 +217,8 @@ describe('useShieldCoverageAlert', () => {
expect(updateTransactionEventFragmentMock).toHaveBeenCalledWith(
expect.objectContaining({
properties: {
// eslint-disable-next-line @typescript-eslint/naming-convention
shield_result: 'loading',
// eslint-disable-next-line @typescript-eslint/naming-convention
shield_reason: 'shieldCoverageAlertMessagePotentialRisks',
// eslint-disable-next-line @typescript-eslint/naming-convention
shield_result_response_latency_ms: 'N/A',
},
}),
Expand All @@ -243,11 +233,8 @@ describe('useShieldCoverageAlert', () => {
expect(updateSignatureEventFragmentMock).toHaveBeenCalledWith(
expect.objectContaining({
properties: {
// eslint-disable-next-line @typescript-eslint/naming-convention
shield_result: 'covered',
// eslint-disable-next-line @typescript-eslint/naming-convention
shield_reason: 'shieldCoverageAlertCovered',
// eslint-disable-next-line @typescript-eslint/naming-convention
shield_result_response_latency_ms: 200,
},
}),
Expand Down
30 changes: 2 additions & 28 deletions ui/pages/confirmations/hooks/useConfirmationAlertMetrics.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
/* eslint-disable @typescript-eslint/naming-convention */
import { TransactionMeta } from '@metamask/transaction-controller';
import { act } from '@testing-library/react-hooks';

Expand Down Expand Up @@ -61,32 +63,16 @@ const STATE_MOCK = getMockConfirmStateForTransaction(
);

const EXPECTED_PROPERTIES_BASE = {
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
alert_action_clicked: [],
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
alert_key_clicked: [],
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
alert_resolved: [],
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
alert_resolved_count: 0,
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
alert_triggered: [
ALERT_NAME_METRICS_MOCK,
ALERTS_NAME_METRICS[AlertsName.Blockaid],
],
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
alert_triggered_count: 2,
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
alert_visualized: [],
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
alert_visualized_count: 0,
};

Expand Down Expand Up @@ -129,11 +115,7 @@ describe('useConfirmationAlertMetrics', () => {
alertKey: AlertsName.GasFeeLow,
action: 'trackAlertRender',
expectedProperties: {
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
alert_visualized: [ALERT_NAME_METRICS_MOCK],
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
alert_visualized_count: 1,
},
},
Expand All @@ -143,8 +125,6 @@ describe('useConfirmationAlertMetrics', () => {
alertKey: AlertsName.GasFeeLow,
action: 'trackInlineAlertClicked',
expectedProperties: {
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
alert_key_clicked: [ALERT_NAME_METRICS_MOCK],
},
},
Expand All @@ -154,8 +134,6 @@ describe('useConfirmationAlertMetrics', () => {
alertKey: AlertsName.GasFeeLow,
action: 'trackAlertActionClicked',
expectedProperties: {
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
alert_action_clicked: [ALERT_NAME_METRICS_MOCK],
},
},
Expand All @@ -165,11 +143,7 @@ describe('useConfirmationAlertMetrics', () => {
alertKey: UUID_ALERT_KEY_MOCK,
action: 'trackAlertRender',
expectedProperties: {
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
alert_visualized: [ALERTS_NAME_METRICS[AlertsName.Blockaid]],
// TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
// eslint-disable-next-line @typescript-eslint/naming-convention
alert_visualized_count: 1,
},
},
Expand Down
Loading
Loading