Issue-94 Resolved memory leak by adding weak to parent CameraManager #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2025
bogdan
reviewed
Jun 3, 2025
| } | ||
| private extension CameraManagerMotionManager { | ||
| func handleAccelerometerUpdates(_ data: CMAccelerometerData?, _ error: Error?) { | ||
| guard let data, error == nil else { return } |
There was a problem hiding this comment.
I believe with all of that, the ! should be removed from:
private(set) weak var parent: CameraManager!We should not pretend it can not be nil if it can.
samdogg7
force-pushed
the
fix/memory-leak
branch
from
6413055 to
8fde7fb
Compare
|
@FulcrumOne / @bogdan this PR is ready for review. I believe this as a high priority fix, if either of you are able to review! |
|
@samdogg7 I am already using this patch in production 👍 . Works well so far. Unfortunately, @FulcrumOne doesn't pay much attention to the repo and I have no power here. We need to find a way to get some maintenance, but I don't have any ideas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves memory leak mentioned in Issue 94