Ability to build with ip and sp library#1197
Open
scrasmussen wants to merge 1 commit intoNCAR:mainfrom
Open
Conversation
…ip so this is needed. Note that in spack-stack 1.9.3 the ip package builds with the OpenMP flag, so CMAKE_Fortran_FLAGS_OPENMP_OFF needs to be set by the host model. The RRTMGP files currently break if compiled with OpenMP flags.
scrasmussen
requested review from
dustinswales,
grantfirl and
rhaesung
as code owners
dustinswales
approved these changes
Feb 26, 2026
grantfirl
approved these changes
Feb 27, 2026
rhaesung
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes:
iplibrary if it is found. Thesplibrary is being replaced byipso this is required. Note that in spack-stack theippackage builds with the OpenMP flag so it gets turned on in the CMake build. This means theCMAKE_Fortran_FLAGS_OPENMP_OFFneeds to be set by the host model since the RRTMGP files currently break if compiled with OpenMP flags. TheCMAKE_Fortran_FLAGS_OPENMP_OFFenvironement variable will make sure OpenMP isn't used by the RRTMGP files.Tests Conducted:
Builds and runs with the SCM, see NCAR/ccpp-scm#662 for tests.
Documentation:
Does this PR add new capabilities that need to be documented or require modifications to the existing documentation? No
Issue (optional):
Partly fixes issue mentioned in #1193,
Contributors (optional):
Built on work from @climbfuji in #1090 and NCAR/ccpp-scm#524