Update: spack stack 1.9.3 and 2.0.0 and ip library#662
Update: spack stack 1.9.3 and 2.0.0 and ip library#662scrasmussen wants to merge 11 commits intoNCAR:mainfrom
Conversation
…g from sp to ip and the bacio version. CMAKE_Fortran_FLAGS_OPENMP_OFF flags needs to be set, ip in 1.9.3 turn on OpenMP and RRTMGP files will break with OpenMP turned on
…Not running on Derecho, will create an issue with the RC helpdesk
…s not officially support GNU on Derecho
|
@scrasmussen I ran tests on derecho with this PR. GNU w/ 1.9.3 Builds and runs SCM fine Did you ever discover what the issue with running the SCM was for Intel on Derecho? Do you want me to look into it? LMK |
@hertneky I haven't had time to dive into why the SCM is failing with an Intel executable. I'll be able to look into it a bit more next week. If we want to merge this in sooner I can split off the intel stuff until we can get it to run. Or we can add a note when the spack stack 2.0 intel modules are loaded that the SCM is failing at runtime with them |
@scrasmussen That's what I wasn't sure about either, whether it was fine to merge this knowing intel is broken for running SCM. Do others have thoughts? @grantfirl @dustinswales |
|
I'd also like to get this working on Ursa before merging this. I can work on that. |
|
@scrasmussen @hertneky I just uploaded a module file for spack-stack-2.0.0 using ip on Ursa. It successfully compiled and ran a case. I also made a new spack-stack-2.0.0 python virtual environment to use there in /scratch3/BMC/gmtb/ccpp-scm-software. |
|
@scrasmussen Also, no issues on Ursa for using -O2. If issues persist on Derecho, we should test for which machine is being used before reducing optimization, IMO. |
|
@scrasmussen @hertneky Also added a GNU module file and python environment using spack-stack 2.0.0. Everything works with GNU too. |
|
I also tested the code using the spack-stack-1.9.1 module on Ursa (without ip), and it successfully built/ran, so it will successfully fall back to the sp library if necessary. |
|
@scrasmussen I removed the -O0 in the scm/src/CMakeLists.txt since it is apparently a known issue with too many suites that will be addressed in a future PR. Are there any problems remaining on Derecho? |
SOURCE: Soren Rasmussen, NSF NCAR
DESCRIPTION OF CHANGES:
iplibrary if it is found. Thesplibrary is being replaced byipso this is required. Note that in spack-stack theippackage builds with the OpenMP flag so it gets turned on in the CMake build. The RRTMGP files currently break if compiled with OpenMP flags so theCMAKE_Fortran_FLAGS_OPENMP_OFFenvironment variable will make sure OpenMP isn't used by the RRTMGP files.bacio::bacio_4tobacio::bacioin spack-stack 2.0.0-O0. It fails at runtime on Derecho though, this will need to investigated more.ASSOCIATED PRs:
TESTS CONDUCTED: Built on Derecho with GNU and Intel. GNU successfully ran the scm cases but Intel is failing.
Contributors:
Built on work from @climbfuji in NCAR/ccpp-physics#1090 and #524