fix: deploy github pages on upstream only - #1229
Merged
Merged
Conversation
scrasmussen
requested review from
climbfuji,
dustinswales,
grantfirl and
rhaesung
as code owners
June 20, 2026 20:54
climbfuji
approved these changes
Jun 20, 2026
grantfirl
approved these changes
Jun 22, 2026
grantfirl
added a commit
to ufs-community/ccpp-physics
that referenced
this pull request
Aug 5, 2026
* [scm/dev] Ability to build with ip and sp library (NCAR#1208) * Add ability to build with ip if it is found. sp is being replaced by ip so this is needed. Note that in spack-stack 1.9.3 the ip package builds with the OpenMP flag, so CMAKE_Fortran_FLAGS_OPENMP_OFF needs to be set by the host model. The RRTMGP files currently break if compiled with OpenMP flags. * only have DTC/SCM people in the CODEOWNERS for the scm/dev branch --------- Co-authored-by: Soren Rasmussen <s.c.rasmussen@gmail.com> * [main] Followup for NCAR#1187 for NOAA models (NCAR#1205) * update several files to work with CCPP SCM after PR 1187 * remove ccpp_bcast for aerin and aer_pres due to UFS RT hanging * [scm/dev] Update scm/dev from main (includes ccpp_bcast PR + followup NOAA fixes) (NCAR#1209) * Read and broadcast data from MPI root rank during init and timestep init phase in GFS time vary; add time vary interstitials for NEPTUNE (NCAR#1187) * 1. number_of_coefficients_in_ozone_data --> number_of_coefficients_in_ozone_forcing_data 2. Add NEPTUNE interstitials in physics/Interstitials/UFS_SCM_NEPTUNE/ * Read and broadcast data in CCPP init and timestep_init phases instead of reading with every MPI rank * In physics/Radiation/radiation_astronomy.f, replace hardcoded zero with mpiroot; move mpiutil.F90 to subdirectory tools * physics/tools/mpiutil.F90: add temporary routine to mpi-abort the model if MPI broadcast errors occur * Bug fixes in physics/Interstitials/UFS_SCM_NEPTUNE/GFS_time_vary_pre.*.F90 when writing to errmsg for invalid w3kindreal/w3kindint; additionally: formatting updates * In physics/Radiation/radiation_astronomy.f, replace hardcoded zero with mpiroot; move mpiutil.F90 to subdirectory tools * Add ability to build with ip if it is found. sp is being replaced by ip so this is needed. Note that in spack-stack 1.9.3 the ip package builds with the OpenMP flag, so CMAKE_Fortran_FLAGS_OPENMP_OFF needs to be set by the host model. The RRTMGP files currently break if compiled with OpenMP flags. * update several files to work with CCPP SCM after PR 1187 * remove ccpp_bcast for aerin and aer_pres due to UFS RT hanging --------- Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: Soren Rasmussen <s.c.rasmussen@gmail.com> * [main] ccpp-physics SciDocs to github pages (NCAR#1207) * add doxygen action * minor changes * minor changes * minor changes * doxy only * Create main.yml * Create jekyll-gh-pages.yml * change * add doxyfile into wkfl * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update ccpp_doxyfile * Update ccpp_doxyfile * update ccpp doxyfile * Update doxygen.yml * update doxyfile * Update doxygen.yml * Update doxygen.yml * update doxyfile * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * change path * add mactex * add mactex * minor changes * minor fix * try1 * try1 * try2 * updates * update perl * update perl * update path * explicitly install * updates * updates * fix * fix path * fix * fix path * fixes * fix3 * cleanup * restore yml files * hsd updates * add doxygen.yml * update branch * update wflw * test * fix * fix * fix * fix * rearrange steps * oops * . * debug * chng dir * chng dir * chng dir * -landing page * -update para * try to add a backlink, fix typo * fix css link * link path * try cp stylesheet * Add CCPP website * fix * add SRW build, backlink * try mainpage * changes for mainpage * mainpage config * mainpage config * mainpage config * mainpage debug * mainpage debug * mainpage debug * mainpage debug * mainpage debug * fix landing page sidebar. * fix landing page sidebar. * fix landing page sidebar. * fix landing page sidebar. * style updates * mainpage style * mainpage style * hide tree on mainpage * add back tree * try adding backlink * add backlink to other pages * updates migrated from mzhangw * fix missed conflicts * fix syntax * run workflow on this branch * remove branch from workflow run, update doxyfile * mods to mainpag dxy * updates * try update for v7 arg table * turn on scidoc branch for deploy * recurse checkout * fix directory * try fix * update landing page with acknowledgements * fix path * fix path * debug * add prebuild_config for building tables * fix * debug * debug * restructure workflow to work with metadata2html.py * add remaining prebuild configs * attempt fix srwv3 checkout * fix main checkout for landing page, stash prebuild configs * fix syntax * update prebuild location * workflow updates * point to NCAR/main --------- Co-authored-by: mzhangw <man.zhang@noaa.gov> Co-authored-by: mzhangw <mzhangw@gmail.com> Co-authored-by: Grant Firl <grant.firl@noaa.gov> * fix: update actions/checkout version to v6, v4 uses deprecated nodejs version. Updating other actions to their newest release (NCAR#1215) Co-authored-by: Grant Firl <grant.firl@noaa.gov> * First round of updates and bug fixes for capgen-ng * Update submodule pointer for physics/MP/TEMPO/TEMPO * Minor bugfixes for building with capgen-ng in SCM * ufs-dev PR#337 (NCAR#1212) * remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations * change Xu-Randall cloud fraction scheme to be elemental * use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme * modify the cld_frac_XuRandall function call in RRTMGP scheme * add the repository update to this PR * Revert "add the repository update to this PR" This reverts commit 565d62c. * remove the printing tests * remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory * remove Zhao-Carr microphysics scheme from physics/MP directory * remove non-ASCII character in canopy_levs.F90 (from previous PR) * Apply suggestion from @matusmartini Co-authored-by: Matus Martini <matusmartini@users.noreply.github.com> --------- Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov> Co-authored-by: Grant Firl <grant.firl@noaa.gov> Co-authored-by: Matus Martini <matusmartini@users.noreply.github.com> * Metadata corrections from ccpp_validator.py * Correct dimensions for air_pressure_at_interface in physics/MP/Ferrier_Aligo/mp_fer_hires.meta * physics/Interstitials/UFS_SCM_NEPTUNE/GFS_phys_time_vary.neptune.meta: fix intent for xlat_d and xlon_d * ufs-dev PR#363 PR#339 PR#364 (NCAR#1213) * remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations * change Xu-Randall cloud fraction scheme to be elemental * Fixed too-high lower bound for SMC Deleted code associated with already removed print statements Deleted excess comments. * use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme * Tidy-up for PR. * modify the cld_frac_XuRandall function call in RRTMGP scheme * Changes to the post L-IAU checks: * Change tfreeze to match that in NoahMP * Only set SLC to SMC if temp newly > tfreez * add the repository update to this PR * Revert "add the repository update to this PR" This reverts commit 565d62c. * remove the printing tests * remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory * remove Zhao-Carr microphysics scheme from physics/MP directory * Update for 10m wind option in fire_behavior module * remove non-ASCII character in canopy_levs.F90 (from previous PR) * Updates to progomega option of saSAS convection scheme * Correction * correction 2 * Correct parameter setting in samfshalcnv to pass debug runs * address saturation vapor pressure out of bounds error in hafs_4_nest RT --------- Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov> Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov> Co-authored-by: Grant Firl <grant.firl@noaa.gov> Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu> Co-authored-by: Lisa <lisa.bengtsson@noaa.gov> Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov> * Metadata corrections from ccpp_validator.py (NCAR#1219) * resubmission: Small inconsistency between metadata and fortran code (NCAR#1222) * Fix fortran to metadata inconsistency * Actual fix --------- Co-authored-by: dustinswales <dswales@ucar.edu> * Some small changes * UFS/dev PR#299 (NCAR#1220) * update standard names to move Xgrs to physics_timestep_initial* and remove *_of_new_state (default name refers to 'current' value) * fix a few unchanged standard names * change some timestep_initial variables to general variables; make satmedmfvdifq return new tendencies and new tendency application block in GFS_PBL_generic_post * Refactor physics tendency calculations - Added tendency variables (`ten_t`, `ten_u`, `ten_v`) for temperature and wind tendencies in SAMF deep and shallow convection schemes. - Updated relevant `.meta` files to reflect changes in variable intent (`inout` -> `in` where appropriate) and added tendencies. - Modified Interstitials (`GFS_DCNV_generic_post`, `GFS_DCNV_generic_pre`, `GFS_SCNV_generic_post`, `GFS_SCNV_generic_pre`) to directly use tendencies instead of saved state variables. - Removed redundant saved variables (`save_u`, `save_v`, `save_t`). - Added `delt` to post interstitials. * update unified_ugwp, ugwpv1, and drag_suite to use new tendency code * save tendency work with GFS_photochemistry * add tracer tendency changes to convection; fix typos in GFS_photochemistry * fix typo in samfdeepcnv.f * save tendency work with Thompson MP * save tendency work with radiation * add FMS to ccpp-physics CMakeLists.txt for fv3 * add initial setting of state in GFS_time_vary_pre.fv3; fix horizontal_dimension in GFS_time_vary_pre.scm * fix metadata in GFS_time_vary_pre.fv3 * add momentum tendency output to mp_thompson and fix intent in metadata * fix array size bug in mp_thompson.F90; cleanup dtend code using new tendency paradigm; cleanup saving of states no longer needed * fix improperly-merged conflict resolution in GFS_photochemistry.F90 * fix access of ntlnc/ntinc access of tracer array when missing * convert many RAD, PBL, GWD, CONV, and MP schemes to return tendencies * convert MG micro and Arakawa-Wu adjustment schemes * convert MYNNEDMF PBL scheme to return tendencies * add changes to MYNN EDMF PBL * add back divide-by-zero bugfix in module_sf_noahmp_glacier.F90 that was removed recently * remove obsolete interstitial schemes * fix 2 minor compilation issues after testing with UFS RTs * fix bug in MG MP * fix near-surface air temperature standard name in GFS_surface_composites_pre * apply tendency cleanup to GFDLMPv3 and TEMPO * fix compilation error * fix typo in TEMPO * debug sgscloud_radpre/post * remove tendency application code from rrtmg_lw/sw_post * change thmpsn to thompson to fix compilation error * fix compilation errors in GFS_radiation_post.F90 * remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations * fix array size problem in cs_conv.F90 * refactor RAS tendencies * fix compilation error in rascnv.F90 * change Xu-Randall cloud fraction scheme to be elemental * Fixed too-high lower bound for SMC Deleted code associated with already removed print statements Deleted excess comments. * use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme * Tidy-up for PR. * modify the cld_frac_XuRandall function call in RRTMGP scheme * Changes to the post L-IAU checks: * Change tfreeze to match that in NoahMP * Only set SLC to SMC if temp newly > tfreez * add the repository update to this PR * Revert "add the repository update to this PR" This reverts commit 565d62c. * fix bug in GFDLMPv3 tendency implementation * remove the printing tests * remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory * remove Zhao-Carr microphysics scheme from physics/MP directory * fix hail tendency changes from reviewer suggestions * fix indexing bug in cu_tiedtke caught in code review * changes to RAS tendency application update code from code review * check for flag_for_generic_tendency_due_to_gravity_wave_drag before computing diagnostic tendencies in drag_suite * fix diagnostic tendency bug in physics/GWD/ugwpv1_gsldrag.F90 * remove unused arguments in physics/GWD/ugwpv1_gsldrag_post.F90 * fix tendency diagnostics in physics/GWD/unified_ugwp.F90 * fix merge problem in mp_thompson.meta * add arguments to drag_suite_run called outside of ccpp entry point * initialize dclw variables in cu_ntiedtke * fix loop bounds for ten_q in cu_gf_driver.F90 * fix loop bounds in cu_c3_driver * fix new_q typo in mp_fer_hires.F90 * deallocate locally-allocated variables in MP schemes * update zeroing logic in m_micro_post after review * Update for 10m wind option in fire_behavior module * remove non-ASCII character in canopy_levs.F90 (from previous PR) * Updates to progomega option of saSAS convection scheme * Correction * correction 2 * fix line in SHOC where a tracer was being updated directly * remove old_ozone array since it was not being used * deallocate local variables in satmedmfvdifq at end of run phase * save temperature before modification to pass in to diagnostics in GFS_radiation_post * fix diagnostic temp tendency in GFS_MP_generic.F90 for when radar is/isn't available * Correct parameter setting in samfshalcnv to pass debug runs * address saturation vapor pressure out of bounds error in hafs_4_nest RT * update long names to remove 'updated by physics'; change prognostic updraft standard names * remove additional references to Zhao-Carr microphysics * remove Zhao-Carr references from GFS_scnv_generic_post * fix deallocation statement in Thompson MP * fix additional warnings * Bug fix in physics/GWD/rayleigh_damp.f: don't mix scalars and rank-2 arrays * remove whitespace changes in radiation_clouds.f --------- Co-authored-by: VanderleiVargas-NOAA <vanderlei.vargas@noaa.gov> Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov> Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov> Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu> Co-authored-by: Lisa <lisa.bengtsson@noaa.gov> Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov> Co-authored-by: Grant Firl <grant@Macbook-Air-M4.local> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> * Add metadata to physcons.F90 * Fix metadata vs Fortran inconsistencies in GFS_PBL_generic_post.meta and mp_nssl.{F90,meta} * Some inconsistencies found by validator * Fix inconsistencies Fortran vs Metadata physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_pre.meta * Few more small changes * number_of_openmp_threads --> number_of_physics_threads in all schemes * C3 * Fix inconsistencies in metadata/fortran * More metadata/source inconsistencies * Ufs dev pr367 (NCAR#1223) * update standard names to move Xgrs to physics_timestep_initial* and remove *_of_new_state (default name refers to 'current' value) * fix a few unchanged standard names * change some timestep_initial variables to general variables; make satmedmfvdifq return new tendencies and new tendency application block in GFS_PBL_generic_post * Refactor physics tendency calculations - Added tendency variables (`ten_t`, `ten_u`, `ten_v`) for temperature and wind tendencies in SAMF deep and shallow convection schemes. - Updated relevant `.meta` files to reflect changes in variable intent (`inout` -> `in` where appropriate) and added tendencies. - Modified Interstitials (`GFS_DCNV_generic_post`, `GFS_DCNV_generic_pre`, `GFS_SCNV_generic_post`, `GFS_SCNV_generic_pre`) to directly use tendencies instead of saved state variables. - Removed redundant saved variables (`save_u`, `save_v`, `save_t`). - Added `delt` to post interstitials. * update unified_ugwp, ugwpv1, and drag_suite to use new tendency code * save tendency work with GFS_photochemistry * add tracer tendency changes to convection; fix typos in GFS_photochemistry * fix typo in samfdeepcnv.f * save tendency work with Thompson MP * save tendency work with radiation * add FMS to ccpp-physics CMakeLists.txt for fv3 * add initial setting of state in GFS_time_vary_pre.fv3; fix horizontal_dimension in GFS_time_vary_pre.scm * fix metadata in GFS_time_vary_pre.fv3 * add momentum tendency output to mp_thompson and fix intent in metadata * fix array size bug in mp_thompson.F90; cleanup dtend code using new tendency paradigm; cleanup saving of states no longer needed * fix improperly-merged conflict resolution in GFS_photochemistry.F90 * fix access of ntlnc/ntinc access of tracer array when missing * convert many RAD, PBL, GWD, CONV, and MP schemes to return tendencies * convert MG micro and Arakawa-Wu adjustment schemes * convert MYNNEDMF PBL scheme to return tendencies * add changes to MYNN EDMF PBL * add back divide-by-zero bugfix in module_sf_noahmp_glacier.F90 that was removed recently * remove obsolete interstitial schemes * fix 2 minor compilation issues after testing with UFS RTs * fix bug in MG MP * fix near-surface air temperature standard name in GFS_surface_composites_pre * apply tendency cleanup to GFDLMPv3 and TEMPO * fix compilation error * fix typo in TEMPO * debug sgscloud_radpre/post * remove tendency application code from rrtmg_lw/sw_post * change thmpsn to thompson to fix compilation error * fix compilation errors in GFS_radiation_post.F90 * remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations * fix array size problem in cs_conv.F90 * refactor RAS tendencies * fix compilation error in rascnv.F90 * change Xu-Randall cloud fraction scheme to be elemental * Fixed too-high lower bound for SMC Deleted code associated with already removed print statements Deleted excess comments. * use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme * Tidy-up for PR. * modify the cld_frac_XuRandall function call in RRTMGP scheme * Changes to the post L-IAU checks: * Change tfreeze to match that in NoahMP * Only set SLC to SMC if temp newly > tfreez * add the repository update to this PR * Revert "add the repository update to this PR" This reverts commit 565d62c. * fix bug in GFDLMPv3 tendency implementation * remove the printing tests * remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory * remove Zhao-Carr microphysics scheme from physics/MP directory * fix hail tendency changes from reviewer suggestions * fix indexing bug in cu_tiedtke caught in code review * changes to RAS tendency application update code from code review * check for flag_for_generic_tendency_due_to_gravity_wave_drag before computing diagnostic tendencies in drag_suite * fix diagnostic tendency bug in physics/GWD/ugwpv1_gsldrag.F90 * remove unused arguments in physics/GWD/ugwpv1_gsldrag_post.F90 * fix tendency diagnostics in physics/GWD/unified_ugwp.F90 * fix merge problem in mp_thompson.meta * add arguments to drag_suite_run called outside of ccpp entry point * initialize dclw variables in cu_ntiedtke * fix loop bounds for ten_q in cu_gf_driver.F90 * fix loop bounds in cu_c3_driver * fix new_q typo in mp_fer_hires.F90 * deallocate locally-allocated variables in MP schemes * update zeroing logic in m_micro_post after review * Update for 10m wind option in fire_behavior module * remove non-ASCII character in canopy_levs.F90 (from previous PR) * Updates to progomega option of saSAS convection scheme * Correction * correction 2 * fix line in SHOC where a tracer was being updated directly * remove old_ozone array since it was not being used * deallocate local variables in satmedmfvdifq at end of run phase * save temperature before modification to pass in to diagnostics in GFS_radiation_post * Remove goto in physics/MP/Morrison_Gettelman/aer_cloud.F * Remove goto in physics/Radiation/radiation_clouds.f * fix diagnostic temp tendency in GFS_MP_generic.F90 for when radar is/isn't available * Correct parameter setting in samfshalcnv to pass debug runs * Name END DO * Remove goto physics/MP/calpreciptype.f90 * Remove goto physics/MP/Morrison_Gettelman/cldwat2m_micro.F * Start goto physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90 * Remove goto physics/SFC_Layer/UFS/module_nst_model.f90 * address saturation vapor pressure out of bounds error in hafs_4_nest RT * update long names to remove 'updated by physics'; change prognostic updraft standard names * remove additional references to Zhao-Carr microphysics * remove Zhao-Carr references from GFS_scnv_generic_post * fix deallocation statement in Thompson MP * Remove go to physics/CONV/C3/cu_c3_sh.F90 * Remove go to physics/PBL/MYJ/module_BL_MYJPBL.F90 * Remove goto physics/MP/Morrison_Gettelman/wv_saturation.F * Again physics/MP/Morrison_Gettelman/wv_saturation.F * physics/MP/Morrison_Gettelman/wv_saturation.F * Typo * Remove goto physics/CONV/C3/cu_c3_deep.F90 * Remove go to physics/CONV/RAS/rascnv.F90 * Typo rascnv.F90 * physics/SFC_Layer/GFDL/gfdl_sfc_layer.F90 * physics/CONV/Grell_Freitas/cu_gf_sh.F90 * Typo module_BL_MYJPBL.F90 * physics/SFC_Layer/MYJ/module_SF_JSFC.F90 * First pass physics/CONV/Grell_Freitas/cu_gf_deep.F90 * physics/CONV/Grell_Freitas/cu_gf_deep.F90 * physics/GWD/ugwp_driver_v0.F * physics/MP/Thompson/module_mp_thompson.F90 * physics/PBL/MYNN_EDMF/module_bl_mynn.F90 * physics/MP/GFDL/v1_2019/gfdl_cloud_microphys_mod.F90 * physics/MP/GFDL/v3_2022/gfdl_cloud_microphys_v3_mod.F90 * Fix compile physics/Radiation/radiation_clouds.f * Compile fixes * Fix for 73 character limit line * Compile fix * Start physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90 * physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90 * fix additional warnings * Fix compile hafsw wcoss2 * Revert rascnv so control_ras_intel b4b on wcoss2 * remove whitespace changes in radiation_clouds.f --------- Co-authored-by: Grant Firl <grant.firl@noaa.gov> Co-authored-by: VanderleiVargas-NOAA <vanderlei.vargas@noaa.gov> Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov> Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov> Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu> Co-authored-by: Lisa <lisa.bengtsson@noaa.gov> Co-authored-by: Nicholas Szapiro <149816583+NickSzapiro-NOAA@users.noreply.github.com> Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov> Co-authored-by: Nick Szapiro <nick.szapiro@noaa.gov> Co-authored-by: Nick Szapiro <nick.szapiro@clogin06.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: Grant Firl <grant@Macbook-Air-M4.local> * ufs-dev PR#371 (NCAR#1224) * update standard names to move Xgrs to physics_timestep_initial* and remove *_of_new_state (default name refers to 'current' value) * fix a few unchanged standard names * change some timestep_initial variables to general variables; make satmedmfvdifq return new tendencies and new tendency application block in GFS_PBL_generic_post * Refactor physics tendency calculations - Added tendency variables (`ten_t`, `ten_u`, `ten_v`) for temperature and wind tendencies in SAMF deep and shallow convection schemes. - Updated relevant `.meta` files to reflect changes in variable intent (`inout` -> `in` where appropriate) and added tendencies. - Modified Interstitials (`GFS_DCNV_generic_post`, `GFS_DCNV_generic_pre`, `GFS_SCNV_generic_post`, `GFS_SCNV_generic_pre`) to directly use tendencies instead of saved state variables. - Removed redundant saved variables (`save_u`, `save_v`, `save_t`). - Added `delt` to post interstitials. * update unified_ugwp, ugwpv1, and drag_suite to use new tendency code * save tendency work with GFS_photochemistry * add tracer tendency changes to convection; fix typos in GFS_photochemistry * fix typo in samfdeepcnv.f * save tendency work with Thompson MP * save tendency work with radiation * add FMS to ccpp-physics CMakeLists.txt for fv3 * add initial setting of state in GFS_time_vary_pre.fv3; fix horizontal_dimension in GFS_time_vary_pre.scm * fix metadata in GFS_time_vary_pre.fv3 * add momentum tendency output to mp_thompson and fix intent in metadata * fix array size bug in mp_thompson.F90; cleanup dtend code using new tendency paradigm; cleanup saving of states no longer needed * fix improperly-merged conflict resolution in GFS_photochemistry.F90 * fix access of ntlnc/ntinc access of tracer array when missing * convert many RAD, PBL, GWD, CONV, and MP schemes to return tendencies * convert MG micro and Arakawa-Wu adjustment schemes * convert MYNNEDMF PBL scheme to return tendencies * add changes to MYNN EDMF PBL * add back divide-by-zero bugfix in module_sf_noahmp_glacier.F90 that was removed recently * remove obsolete interstitial schemes * fix 2 minor compilation issues after testing with UFS RTs * fix bug in MG MP * fix near-surface air temperature standard name in GFS_surface_composites_pre * apply tendency cleanup to GFDLMPv3 and TEMPO * fix compilation error * fix typo in TEMPO * debug sgscloud_radpre/post * remove tendency application code from rrtmg_lw/sw_post * change thmpsn to thompson to fix compilation error * fix compilation errors in GFS_radiation_post.F90 * remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations * fix array size problem in cs_conv.F90 * refactor RAS tendencies * fix compilation error in rascnv.F90 * change Xu-Randall cloud fraction scheme to be elemental * Fixed too-high lower bound for SMC Deleted code associated with already removed print statements Deleted excess comments. * use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme * Tidy-up for PR. * modify the cld_frac_XuRandall function call in RRTMGP scheme * Changes to the post L-IAU checks: * Change tfreeze to match that in NoahMP * Only set SLC to SMC if temp newly > tfreez * add the repository update to this PR * Revert "add the repository update to this PR" This reverts commit 565d62c. * fix bug in GFDLMPv3 tendency implementation * remove the printing tests * remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory * remove Zhao-Carr microphysics scheme from physics/MP directory * fix hail tendency changes from reviewer suggestions * fix indexing bug in cu_tiedtke caught in code review * changes to RAS tendency application update code from code review * check for flag_for_generic_tendency_due_to_gravity_wave_drag before computing diagnostic tendencies in drag_suite * fix diagnostic tendency bug in physics/GWD/ugwpv1_gsldrag.F90 * remove unused arguments in physics/GWD/ugwpv1_gsldrag_post.F90 * fix tendency diagnostics in physics/GWD/unified_ugwp.F90 * fix merge problem in mp_thompson.meta * add arguments to drag_suite_run called outside of ccpp entry point * initialize dclw variables in cu_ntiedtke * fix loop bounds for ten_q in cu_gf_driver.F90 * fix loop bounds in cu_c3_driver * fix new_q typo in mp_fer_hires.F90 * deallocate locally-allocated variables in MP schemes * update zeroing logic in m_micro_post after review * Update for 10m wind option in fire_behavior module * remove non-ASCII character in canopy_levs.F90 (from previous PR) * Updates to progomega option of saSAS convection scheme * Correction * correction 2 * fix line in SHOC where a tracer was being updated directly * remove old_ozone array since it was not being used * deallocate local variables in satmedmfvdifq at end of run phase * save temperature before modification to pass in to diagnostics in GFS_radiation_post * Remove goto in physics/MP/Morrison_Gettelman/aer_cloud.F * Remove goto in physics/Radiation/radiation_clouds.f * fix diagnostic temp tendency in GFS_MP_generic.F90 for when radar is/isn't available * Correct parameter setting in samfshalcnv to pass debug runs * Name END DO * Remove goto physics/MP/calpreciptype.f90 * Remove goto physics/MP/Morrison_Gettelman/cldwat2m_micro.F * Start goto physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90 * Remove goto physics/SFC_Layer/UFS/module_nst_model.f90 * address saturation vapor pressure out of bounds error in hafs_4_nest RT * update long names to remove 'updated by physics'; change prognostic updraft standard names * remove additional references to Zhao-Carr microphysics * remove Zhao-Carr references from GFS_scnv_generic_post * fix deallocation statement in Thompson MP * Remove go to physics/CONV/C3/cu_c3_sh.F90 * Remove go to physics/PBL/MYJ/module_BL_MYJPBL.F90 * Remove goto physics/MP/Morrison_Gettelman/wv_saturation.F * Again physics/MP/Morrison_Gettelman/wv_saturation.F * physics/MP/Morrison_Gettelman/wv_saturation.F * Typo * Remove goto physics/CONV/C3/cu_c3_deep.F90 * Remove go to physics/CONV/RAS/rascnv.F90 * Typo rascnv.F90 * physics/SFC_Layer/GFDL/gfdl_sfc_layer.F90 * physics/CONV/Grell_Freitas/cu_gf_sh.F90 * Typo module_BL_MYJPBL.F90 * physics/SFC_Layer/MYJ/module_SF_JSFC.F90 * First pass physics/CONV/Grell_Freitas/cu_gf_deep.F90 * physics/CONV/Grell_Freitas/cu_gf_deep.F90 * physics/GWD/ugwp_driver_v0.F * physics/MP/Thompson/module_mp_thompson.F90 * physics/PBL/MYNN_EDMF/module_bl_mynn.F90 * physics/MP/GFDL/v1_2019/gfdl_cloud_microphys_mod.F90 * physics/MP/GFDL/v3_2022/gfdl_cloud_microphys_v3_mod.F90 * Fix compile physics/Radiation/radiation_clouds.f * Compile fixes * Fix for 73 character limit line * Compile fix * Start physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90 * physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90 * fix additional warnings * Fix compile hafsw wcoss2 * Revert rascnv so control_ras_intel b4b on wcoss2 * Use 10-m intepolated winds in the explicit in-canopy diffusion of tracers. Remove hpbl/kpbl update due to explicit in-canopy diffusion. * Clean up commented out code. Correct a truncated source line. * Comment out the integrated-canopy meteorology effect. Keep the lines for future PR with the canopy met effects. * revert radiation_clouds.f --------- Co-authored-by: Grant Firl <grant.firl@noaa.gov> Co-authored-by: VanderleiVargas-NOAA <vanderlei.vargas@noaa.gov> Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov> Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov> Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu> Co-authored-by: Lisa <lisa.bengtsson@noaa.gov> Co-authored-by: Nicholas Szapiro <149816583+NickSzapiro-NOAA@users.noreply.github.com> Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov> Co-authored-by: Nick Szapiro <nick.szapiro@noaa.gov> Co-authored-by: Nick Szapiro <nick.szapiro@clogin06.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: iri01 <i.t.ivanova@gmail.com> Co-authored-by: iri01 <129897017+iri01@users.noreply.github.com> Co-authored-by: Grant Firl <grant@Macbook-Air-M4.local> Co-authored-by: Tracy <hertneky@ucar.edu> * ufs-dev PR#365 (NCAR#1225) * update standard names to move Xgrs to physics_timestep_initial* and remove *_of_new_state (default name refers to 'current' value) * fix a few unchanged standard names * change some timestep_initial variables to general variables; make satmedmfvdifq return new tendencies and new tendency application block in GFS_PBL_generic_post * Refactor physics tendency calculations - Added tendency variables (`ten_t`, `ten_u`, `ten_v`) for temperature and wind tendencies in SAMF deep and shallow convection schemes. - Updated relevant `.meta` files to reflect changes in variable intent (`inout` -> `in` where appropriate) and added tendencies. - Modified Interstitials (`GFS_DCNV_generic_post`, `GFS_DCNV_generic_pre`, `GFS_SCNV_generic_post`, `GFS_SCNV_generic_pre`) to directly use tendencies instead of saved state variables. - Removed redundant saved variables (`save_u`, `save_v`, `save_t`). - Added `delt` to post interstitials. * update unified_ugwp, ugwpv1, and drag_suite to use new tendency code * save tendency work with GFS_photochemistry * add tracer tendency changes to convection; fix typos in GFS_photochemistry * fix typo in samfdeepcnv.f * save tendency work with Thompson MP * save tendency work with radiation * add FMS to ccpp-physics CMakeLists.txt for fv3 * add initial setting of state in GFS_time_vary_pre.fv3; fix horizontal_dimension in GFS_time_vary_pre.scm * fix metadata in GFS_time_vary_pre.fv3 * add momentum tendency output to mp_thompson and fix intent in metadata * fix array size bug in mp_thompson.F90; cleanup dtend code using new tendency paradigm; cleanup saving of states no longer needed * fix improperly-merged conflict resolution in GFS_photochemistry.F90 * fix access of ntlnc/ntinc access of tracer array when missing * convert many RAD, PBL, GWD, CONV, and MP schemes to return tendencies * convert MG micro and Arakawa-Wu adjustment schemes * convert MYNNEDMF PBL scheme to return tendencies * add changes to MYNN EDMF PBL * add back divide-by-zero bugfix in module_sf_noahmp_glacier.F90 that was removed recently * remove obsolete interstitial schemes * fix 2 minor compilation issues after testing with UFS RTs * fix bug in MG MP * fix near-surface air temperature standard name in GFS_surface_composites_pre * apply tendency cleanup to GFDLMPv3 and TEMPO * fix compilation error * fix typo in TEMPO * debug sgscloud_radpre/post * remove tendency application code from rrtmg_lw/sw_post * change thmpsn to thompson to fix compilation error * fix compilation errors in GFS_radiation_post.F90 * remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations * fix array size problem in cs_conv.F90 * refactor RAS tendencies * fix compilation error in rascnv.F90 * change Xu-Randall cloud fraction scheme to be elemental * Fixed too-high lower bound for SMC Deleted code associated with already removed print statements Deleted excess comments. * use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme * Tidy-up for PR. * modify the cld_frac_XuRandall function call in RRTMGP scheme * Changes to the post L-IAU checks: * Change tfreeze to match that in NoahMP * Only set SLC to SMC if temp newly > tfreez * add the repository update to this PR * Revert "add the repository update to this PR" This reverts commit 565d62c. * fix bug in GFDLMPv3 tendency implementation * remove the printing tests * remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory * remove Zhao-Carr microphysics scheme from physics/MP directory * Chagne to not using ozone physics DDT when not active * fix hail tendency changes from reviewer suggestions * fix indexing bug in cu_tiedtke caught in code review * changes to RAS tendency application update code from code review * check for flag_for_generic_tendency_due_to_gravity_wave_drag before computing diagnostic tendencies in drag_suite * fix diagnostic tendency bug in physics/GWD/ugwpv1_gsldrag.F90 * remove unused arguments in physics/GWD/ugwpv1_gsldrag_post.F90 * fix tendency diagnostics in physics/GWD/unified_ugwp.F90 * fix merge problem in mp_thompson.meta * add arguments to drag_suite_run called outside of ccpp entry point * initialize dclw variables in cu_ntiedtke * fix loop bounds for ten_q in cu_gf_driver.F90 * fix loop bounds in cu_c3_driver * fix new_q typo in mp_fer_hires.F90 * deallocate locally-allocated variables in MP schemes * update zeroing logic in m_micro_post after review * Update for 10m wind option in fire_behavior module * remove non-ASCII character in canopy_levs.F90 (from previous PR) * Updates to progomega option of saSAS convection scheme * Correction * correction 2 * fix line in SHOC where a tracer was being updated directly * remove old_ozone array since it was not being used * deallocate local variables in satmedmfvdifq at end of run phase * save temperature before modification to pass in to diagnostics in GFS_radiation_post * Remove goto in physics/MP/Morrison_Gettelman/aer_cloud.F * Remove goto in physics/Radiation/radiation_clouds.f * fix diagnostic temp tendency in GFS_MP_generic.F90 for when radar is/isn't available * Correct parameter setting in samfshalcnv to pass debug runs * Name END DO * Remove goto physics/MP/calpreciptype.f90 * Remove goto physics/MP/Morrison_Gettelman/cldwat2m_micro.F * Start goto physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90 * Remove goto physics/SFC_Layer/UFS/module_nst_model.f90 * address saturation vapor pressure out of bounds error in hafs_4_nest RT * update long names to remove 'updated by physics'; change prognostic updraft standard names * remove additional references to Zhao-Carr microphysics * remove Zhao-Carr references from GFS_scnv_generic_post * fix deallocation statement in Thompson MP * Remove go to physics/CONV/C3/cu_c3_sh.F90 * Remove go to physics/PBL/MYJ/module_BL_MYJPBL.F90 * Remove goto physics/MP/Morrison_Gettelman/wv_saturation.F * Again physics/MP/Morrison_Gettelman/wv_saturation.F * physics/MP/Morrison_Gettelman/wv_saturation.F * Typo * Remove goto physics/CONV/C3/cu_c3_deep.F90 * Remove go to physics/CONV/RAS/rascnv.F90 * Typo rascnv.F90 * physics/SFC_Layer/GFDL/gfdl_sfc_layer.F90 * physics/CONV/Grell_Freitas/cu_gf_sh.F90 * Typo module_BL_MYJPBL.F90 * physics/SFC_Layer/MYJ/module_SF_JSFC.F90 * First pass physics/CONV/Grell_Freitas/cu_gf_deep.F90 * physics/CONV/Grell_Freitas/cu_gf_deep.F90 * physics/GWD/ugwp_driver_v0.F * physics/MP/Thompson/module_mp_thompson.F90 * physics/PBL/MYNN_EDMF/module_bl_mynn.F90 * physics/MP/GFDL/v1_2019/gfdl_cloud_microphys_mod.F90 * physics/MP/GFDL/v3_2022/gfdl_cloud_microphys_v3_mod.F90 * Fix compile physics/Radiation/radiation_clouds.f * Compile fixes * Fix for 73 character limit line * Compile fix * Start physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90 * physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90 * fix additional warnings * Fix compile hafsw wcoss2 * Revert rascnv so control_ras_intel b4b on wcoss2 * Use 10-m intepolated winds in the explicit in-canopy diffusion of tracers. Remove hpbl/kpbl update due to explicit in-canopy diffusion. * Clean up commented out code. Correct a truncated source line. * Bug in gcycle error message * Comment out the integrated-canopy meteorology effect. Keep the lines for future PR with the canopy met effects. --------- Co-authored-by: Grant Firl <grant.firl@noaa.gov> Co-authored-by: VanderleiVargas-NOAA <vanderlei.vargas@noaa.gov> Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov> Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov> Co-authored-by: Dustin Swales <dustin.swales@noaa.gov> Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu> Co-authored-by: Lisa <lisa.bengtsson@noaa.gov> Co-authored-by: Nicholas Szapiro <149816583+NickSzapiro-NOAA@users.noreply.github.com> Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov> Co-authored-by: Nick Szapiro <nick.szapiro@noaa.gov> Co-authored-by: Nick Szapiro <nick.szapiro@clogin06.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: iri01 <i.t.ivanova@gmail.com> Co-authored-by: iri01 <129897017+iri01@users.noreply.github.com> Co-authored-by: Grant Firl <grant@Macbook-Air-M4.local> Co-authored-by: Tracy <hertneky@ucar.edu> * copy fix from FV3 version to SCM version of GFS_phys_time_vary (NCAR#1227) * UGWP_v0: Scale cdmbgwd(1:2) by inverse square root of dx (NCAR#1218) * GW multiplication factors scaled by inverse square root of dx (#82) * Scale cdmb with the inverse square root of dxres in ugwp_v0 * Scale cleff with the inverse square root of dxres in ugwp_v0 * Replace the non-ascii 1/2 with its ascii representation to satisfy ci test requirement. * Unify cdmbgwd0 and cdmbgwd (#83) * Make cdmbgwd0 to be rank 4 * Unify cdmbgwd0 and cdmbgwd * Remove unnecessary line * Multiply coefficients by a power of 10 * add Alex and Matus as codeowners for ugwp_v0 --------- Co-authored-by: Matus Martini <matus.n.martini.ctr@us.navy.mil> Co-authored-by: Grant Firl <grant.firl@noaa.gov> * New SciDocs for GWv1 release and LandDA capability (NCAR#1226) * add doxygen action * minor changes * minor changes * minor changes * doxy only * Create main.yml * Create jekyll-gh-pages.yml * change * add doxyfile into wkfl * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update ccpp_doxyfile * Update ccpp_doxyfile * update ccpp doxyfile * Update doxygen.yml * update doxyfile * Update doxygen.yml * Update doxygen.yml * update doxyfile * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * change path * add mactex * add mactex * minor changes * minor fix * try1 * try1 * try2 * updates * update perl * update perl * update path * explicitly install * updates * updates * fix * fix path * fix * fix path * fixes * fix3 * cleanup * restore yml files * hsd updates * add doxygen.yml * update branch * update wflw * test * fix * fix * fix * fix * rearrange steps * oops * . * debug * chng dir * chng dir * chng dir * -landing page * -update para * try to add a backlink, fix typo * fix css link * link path * try cp stylesheet * Add CCPP website * fix * add SRW build, backlink * try mainpage * changes for mainpage * mainpage config * mainpage config * mainpage config * mainpage debug * mainpage debug * mainpage debug * mainpage debug * mainpage debug * fix landing page sidebar. * fix landing page sidebar. * fix landing page sidebar. * fix landing page sidebar. * style updates * mainpage style * mainpage style * hide tree on mainpage * add back tree * try adding backlink * add backlink to other pages * updates migrated from mzhangw * fix missed conflicts * fix syntax * run workflow on this branch * remove branch from workflow run, update doxyfile * mods to mainpag dxy * updates * try update for v7 arg table * turn on scidoc branch for deploy * recurse checkout * fix directory * try fix * update landing page with acknowledgements * fix path * fix path * debug * add prebuild_config for building tables * fix * debug * debug * restructure workflow to work with metadata2html.py * add remaining prebuild configs * attempt fix srwv3 checkout * fix main checkout for landing page, stash prebuild configs * fix syntax * update prebuild location * workflow updates * point to NCAR/main * initial landDA sciDoc commits * point to fork for testing * point to fork for testing in 1 more place * add sciDocs for GW release, some reorg * point to fork * remove main * Changes to GW mainpage * try fix * fix! * fix few things * Add nml links * fix land DA overview page * fixes * oops * oops * updates to GFS_ugwpv1 from Michael Toy and Bo Yang * updates to SAMFdeep from Lisa Bengtsson * updates from Jongil Han for convective, sfc, pbl schemes * Update SciDoc link on README * updates for H2O/Ozone schemes from Qingfu Lui * fix sfclyr link * update reference * try bib fix * try bib tweak * trying to get ref to work * fix bib links * updates for RRTMG from Qingfu Lui * update tracy-fork > main for merging into NCAR/main --------- Co-authored-by: mzhangw <man.zhang@noaa.gov> Co-authored-by: mzhangw <mzhangw@gmail.com> Co-authored-by: Grant Firl <grant.firl@noaa.gov> * run on upstream only since deploy will fail when run from forks (NCAR#1229) Co-authored-by: Grant Firl <grant.firl@noaa.gov> * ufs-dev PR#373 (NCAR#1228) * remove old C3 directory * add C3 as a submodule in a standalone repository * add cu_c3_driver.meta into C3 repository to hook up with CCPP * C3 refactoring - create new CCPP-facing interface compatible with new shared MPAS code. Move to stand alone submodule * Remove non ascii charachters that ccpp doesn't like * translate some comments from Portuguese to English as ccpp doesn't like the ascii format * translate some comments from Portuguese to English as ccpp doesn't like the ascii format 2 * translate some comments from Portuguese to English as ccpp doesn't like the ascii format 3 * more ascii symbols correction * non-ascii charachters * Add host driver directories inside the C3 submodule and rename driver to have suffix _ccpp and _mpas respectively * Add mod_cu_kinds module for consistent kind_phys handling * Fix C3 CCPP plume postprocessing consistency and add neg_check to ensure moisture conservation * Minor updates to avoid compiler warnings associated with subten-variables * Address typos in meta files according to review comments * Correct typo from host model causing inconsistent prebuild * Update C3 commit to 4a41088 and update .gitmodules --------- Co-authored-by: Lisa <lisa.bengtsson@noaa.gov> * number_of_openmp_threads --> number_of_physics_threads * Update submodule pointer for C3 * Add optional attribute for tke vars in cires_ugwp * Bug fix in physics/GWD/cires_ugwp.meta * Add back in metadata file changes that were lost? * Remove changes accidentally intrioduced * Remove changes accidentally intrioduced * Remove cmakelists. Not used * Remove commented line * Updates for TEMPO changes * One more TEMPO change * Update submodule name in .gitmodules. Not impactful sice path os set correctly, but still inconsistent. * Update physics submodules --------- Co-authored-by: Tracy <hertneky@ucar.edu> Co-authored-by: Grant Firl <grant.firl@noaa.gov> Co-authored-by: Soren Rasmussen <s.c.rasmussen@gmail.com> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: Tracy Hertneky <39317287+hertneky@users.noreply.github.com> Co-authored-by: mzhangw <man.zhang@noaa.gov> Co-authored-by: mzhangw <mzhangw@gmail.com> Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov> Co-authored-by: Matus Martini <matusmartini@users.noreply.github.com> Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov> Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu> Co-authored-by: Lisa <lisa.bengtsson@noaa.gov> Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov> Co-authored-by: dustinswales <dswales@ucar.edu> Co-authored-by: VanderleiVargas-NOAA <vanderlei.vargas@noaa.gov> Co-authored-by: Grant Firl <grant@Macbook-Air-M4.local> Co-authored-by: Nicholas Szapiro <149816583+NickSzapiro-NOAA@users.noreply.github.com> Co-authored-by: Nick Szapiro <nick.szapiro@noaa.gov> Co-authored-by: Nick Szapiro <nick.szapiro@clogin06.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: iri01 <i.t.ivanova@gmail.com> Co-authored-by: iri01 <129897017+iri01@users.noreply.github.com> Co-authored-by: Matus Martini <matus.n.martini.ctr@us.navy.mil>
grantfirl
added a commit
that referenced
this pull request
Aug 14, 2026
* update standard names to move Xgrs to physics_timestep_initial* and remove *_of_new_state (default name refers to 'current' value)
* fix a few unchanged standard names
* change some timestep_initial variables to general variables; make satmedmfvdifq return new tendencies and new tendency application block in GFS_PBL_generic_post
* Refactor physics tendency calculations
- Added tendency variables (`ten_t`, `ten_u`, `ten_v`) for temperature and wind tendencies in SAMF deep and shallow convection schemes.
- Updated relevant `.meta` files to reflect changes in variable intent (`inout` -> `in` where appropriate) and added tendencies.
- Modified Interstitials (`GFS_DCNV_generic_post`, `GFS_DCNV_generic_pre`, `GFS_SCNV_generic_post`, `GFS_SCNV_generic_pre`) to directly use tendencies instead of saved state variables.
- Removed redundant saved variables (`save_u`, `save_v`, `save_t`).
- Added `delt` to post interstitials.
* update unified_ugwp, ugwpv1, and drag_suite to use new tendency code
* save tendency work with GFS_photochemistry
* add tracer tendency changes to convection; fix typos in GFS_photochemistry
* fix typo in samfdeepcnv.f
* save tendency work with Thompson MP
* save tendency work with radiation
* add FMS to ccpp-physics CMakeLists.txt for fv3
* add initial setting of state in GFS_time_vary_pre.fv3; fix horizontal_dimension in GFS_time_vary_pre.scm
* fix metadata in GFS_time_vary_pre.fv3
* add momentum tendency output to mp_thompson and fix intent in metadata
* fix array size bug in mp_thompson.F90; cleanup dtend code using new tendency paradigm; cleanup saving of states no longer needed
* fix improperly-merged conflict resolution in GFS_photochemistry.F90
* fix access of ntlnc/ntinc access of tracer array when missing
* convert many RAD, PBL, GWD, CONV, and MP schemes to return tendencies
* convert MG micro and Arakawa-Wu adjustment schemes
* convert MYNNEDMF PBL scheme to return tendencies
* add changes to MYNN EDMF PBL
* add back divide-by-zero bugfix in module_sf_noahmp_glacier.F90 that was removed recently
* remove obsolete interstitial schemes
* fix 2 minor compilation issues after testing with UFS RTs
* fix bug in MG MP
* fix near-surface air temperature standard name in GFS_surface_composites_pre
* apply tendency cleanup to GFDLMPv3 and TEMPO
* fix compilation error
* fix typo in TEMPO
* debug sgscloud_radpre/post
* remove tendency application code from rrtmg_lw/sw_post
* change thmpsn to thompson to fix compilation error
* fix compilation errors in GFS_radiation_post.F90
* remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations
* fix array size problem in cs_conv.F90
* refactor RAS tendencies
* fix compilation error in rascnv.F90
* change Xu-Randall cloud fraction scheme to be elemental
* Fixed too-high lower bound for SMC
Deleted code associated with already removed print statements
Deleted excess comments.
* use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme
* Tidy-up for PR.
* modify the cld_frac_XuRandall function call in RRTMGP scheme
* Changes to the post L-IAU checks:
* Change tfreeze to match that in NoahMP
* Only set SLC to SMC if temp newly > tfreez
* add the repository update to this PR
* Revert "add the repository update to this PR"
This reverts commit 565d62cd9c7959e0981aabc2674686595fc73359.
* fix bug in GFDLMPv3 tendency implementation
* remove the printing tests
* remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory
* remove Zhao-Carr microphysics scheme from physics/MP directory
* Chagne to not using ozone physics DDT when not active
* fix hail tendency changes from reviewer suggestions
* fix indexing bug in cu_tiedtke caught in code review
* changes to RAS tendency application update code from code review
* check for flag_for_generic_tendency_due_to_gravity_wave_drag before computing diagnostic tendencies in drag_suite
* fix diagnostic tendency bug in physics/GWD/ugwpv1_gsldrag.F90
* remove unused arguments in physics/GWD/ugwpv1_gsldrag_post.F90
* fix tendency diagnostics in physics/GWD/unified_ugwp.F90
* fix merge problem in mp_thompson.meta
* add arguments to drag_suite_run called outside of ccpp entry point
* initialize dclw variables in cu_ntiedtke
* fix loop bounds for ten_q in cu_gf_driver.F90
* fix loop bounds in cu_c3_driver
* fix new_q typo in mp_fer_hires.F90
* deallocate locally-allocated variables in MP schemes
* update zeroing logic in m_micro_post after review
* Update for 10m wind option in fire_behavior module
* remove non-ASCII character in canopy_levs.F90 (from previous PR)
* Updates to progomega option of saSAS convection scheme
* Correction
* correction 2
* fix line in SHOC where a tracer was being updated directly
* remove old_ozone array since it was not being used
* deallocate local variables in satmedmfvdifq at end of run phase
* save temperature before modification to pass in to diagnostics in GFS_radiation_post
* Remove goto in physics/MP/Morrison_Gettelman/aer_cloud.F
* Remove goto in physics/Radiation/radiation_clouds.f
* fix diagnostic temp tendency in GFS_MP_generic.F90 for when radar is/isn't available
* Correct parameter setting in samfshalcnv to pass debug runs
* Name END DO
* Remove goto physics/MP/calpreciptype.f90
* Remove goto physics/MP/Morrison_Gettelman/cldwat2m_micro.F
* Start goto physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90
* Remove goto physics/SFC_Layer/UFS/module_nst_model.f90
* address saturation vapor pressure out of bounds error in hafs_4_nest RT
* update long names to remove 'updated by physics'; change prognostic updraft standard names
* remove additional references to Zhao-Carr microphysics
* remove Zhao-Carr references from GFS_scnv_generic_post
* fix deallocation statement in Thompson MP
* Remove go to physics/CONV/C3/cu_c3_sh.F90
* Remove go to physics/PBL/MYJ/module_BL_MYJPBL.F90
* Remove goto physics/MP/Morrison_Gettelman/wv_saturation.F
* Again physics/MP/Morrison_Gettelman/wv_saturation.F
* physics/MP/Morrison_Gettelman/wv_saturation.F
* Typo
* Remove goto physics/CONV/C3/cu_c3_deep.F90
* Remove go to physics/CONV/RAS/rascnv.F90
* Typo rascnv.F90
* physics/SFC_Layer/GFDL/gfdl_sfc_layer.F90
* physics/CONV/Grell_Freitas/cu_gf_sh.F90
* Typo module_BL_MYJPBL.F90
* physics/SFC_Layer/MYJ/module_SF_JSFC.F90
* First pass physics/CONV/Grell_Freitas/cu_gf_deep.F90
* physics/CONV/Grell_Freitas/cu_gf_deep.F90
* physics/GWD/ugwp_driver_v0.F
* physics/MP/Thompson/module_mp_thompson.F90
* physics/PBL/MYNN_EDMF/module_bl_mynn.F90
* physics/MP/GFDL/v1_2019/gfdl_cloud_microphys_mod.F90
* physics/MP/GFDL/v3_2022/gfdl_cloud_microphys_v3_mod.F90
* Fix compile physics/Radiation/radiation_clouds.f
* Compile fixes
* Fix for 73 character limit line
* update several files to work with CCPP SCM after PR 1187
* Compile fix
* Start physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90
* physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90
* fix additional warnings
* Fix compile hafsw wcoss2
* Revert rascnv so control_ras_intel b4b on wcoss2
* update CODEOWNERS"
* remove old C3 directory
* add C3 as a submodule in a standalone repository
* add cu_c3_driver.meta into C3 repository to hook up with CCPP
* Use 10-m intepolated winds in the explicit in-canopy diffusion of tracers. Remove hpbl/kpbl update due to explicit in-canopy diffusion.
* remove ccpp_bcast from aerinterp.F90/read_netfaer that causes hanging UFS RTs
* remove ccpp_bcast in aerinterp.F90/read_netfaer_dl due to UFS hanging
* Clean up commented out code. Correct a truncated source line.
* fix new compiler warning in mpiutil.F90
* Bug in gcycle error message
* Comment out the integrated-canopy meteorology effect. Keep the lines for future PR with the canopy met effects.
* Remove local mpiroot
* Add initialization flags.
* update MYNN-SFC submodule pointer
* C3 refactoring - create new CCPP-facing interface compatible with new shared MPAS code. Move to stand alone submodule
* Remove non ascii charachters that ccpp doesn't like
* translate some comments from Portuguese to English as ccpp doesn't like the ascii format
* translate some comments from Portuguese to English as ccpp doesn't like the ascii format 2
* translate some comments from Portuguese to English as ccpp doesn't like the ascii format 3
* more ascii symbols correction
* clean up truncated comment lines in radiation_gases.f
* non-ascii charachters
* Add host driver directories inside the C3 submodule and rename driver to have suffix _ccpp and _mpas respectively
* Add mod_cu_kinds module for consistent kind_phys handling
* Fix C3 CCPP plume postprocessing consistency and add neg_check to ensure moisture conservation
* Minor updates to avoid compiler warnings associated with subten-variables
* Metadata corrections from ccpp_validator.py
* Address typos in meta files according to review comments
* Correct typo from host model causing inconsistent prebuild
* Update C3 commit to 4a41088 and update .gitmodules
* RRFS smoke fix
* Tempo version 3 (#353)
* initial connection of tempo version 3
* Add comments to radiation for tempo MP and to differentiate tempo from Thompson
* Connects TEMPO to GFS PBL generic
* fix type and add tempo to aerosol index procedure
* simplify tempo driver and add condensation routine
* radiation to use tempo v2 for now
* adds diagnostics and optional arguments to tempo
* add aerosol surface emissions to tempo and aerosol and hail aware flags
* couple tempo to MYNN in ccpp
* update pointer to tempo and fix missing qv variable
* update GFS_rrtmg_pre for tempo v3, clean up condensation
* update to authoritative repo
* clean-up code and add checks for tempo
* clean up radiation coupling to tempo v3
* update GFS_rad_pre, bugfixes to mp_temp, and update to tempo v3.0.3
* use thompson functions in interstial 4 for now as tendencies there apply to convection
* Work to fix interstitial 4
* update to tempo version 3.0.4
* modifications from code review
* add loop for dt_inner on ccpp side
* add back ability of host to control a set of physical constants used in TEMPO MP
* fix unit in mp_tempo.meta
* fix compilation error in mp_tempo_condensation.F90 related to odt
* add some more constants to use/only list to compile
* roll back units change in mp_tempo.meta to fix weird ccpp_prebuild error
* fix subroutine arguments in fast physics condensation and update tempo pointer to 3.0.6
* fixes for RTs
* update .gitmodules
* fix for ufs-mpas
* revert
* update tempo
* update tempo to v3.1.0
* remove old version of TEMPO that was added back
* point tempo_v3 submodule to latest top-of-main commit
---------
Co-authored-by: Grant Firl <grant@Macbook-Air-M4.local>
Co-authored-by: Grant Firl <grant.firl@noaa.gov>
Co-authored-by: gspetro-NOAA <Gillian.Petro@noaa.gov>
* add flag controlling catchem coupling
Co-authored-by: Wei Li <liweicugb@gmail.com>
* remove extra cplcat flags
* Updates for ccpp-capgen v1 (#378)
* [scm/dev] Ability to build with ip and sp library (#1208)
* Add ability to build with ip if it is found. sp is being replaced by ip so this is needed. Note that in spack-stack 1.9.3 the ip package builds with the OpenMP flag, so CMAKE_Fortran_FLAGS_OPENMP_OFF needs to be set by the host model. The RRTMGP files currently break if compiled with OpenMP flags.
* only have DTC/SCM people in the CODEOWNERS for the scm/dev branch
---------
Co-authored-by: Soren Rasmussen <s.c.rasmussen@gmail.com>
* [main] Followup for #1187 for NOAA models (#1205)
* update several files to work with CCPP SCM after PR 1187
* remove ccpp_bcast for aerin and aer_pres due to UFS RT hanging
* [scm/dev] Update scm/dev from main (includes ccpp_bcast PR + followup NOAA fixes) (#1209)
* Read and broadcast data from MPI root rank during init and timestep init phase in GFS time vary; add time vary interstitials for NEPTUNE (#1187)
* 1. number_of_coefficients_in_ozone_data --> number_of_coefficients_in_ozone_forcing_data
2. Add NEPTUNE interstitials in physics/Interstitials/UFS_SCM_NEPTUNE/
* Read and broadcast data in CCPP init and timestep_init phases instead of reading with every MPI rank
* In physics/Radiation/radiation_astronomy.f, replace hardcoded zero with mpiroot; move mpiutil.F90 to subdirectory tools
* physics/tools/mpiutil.F90: add temporary routine to mpi-abort the model if MPI broadcast errors occur
* Bug fixes in physics/Interstitials/UFS_SCM_NEPTUNE/GFS_time_vary_pre.*.F90 when writing to errmsg for invalid w3kindreal/w3kindint; additionally: formatting updates
* In physics/Radiation/radiation_astronomy.f, replace hardcoded zero with mpiroot; move mpiutil.F90 to subdirectory tools
* Add ability to build with ip if it is found. sp is being replaced by ip so this is needed. Note that in spack-stack 1.9.3 the ip package builds with the OpenMP flag, so CMAKE_Fortran_FLAGS_OPENMP_OFF needs to be set by the host model. The RRTMGP files currently break if compiled with OpenMP flags.
* update several files to work with CCPP SCM after PR 1187
* remove ccpp_bcast for aerin and aer_pres due to UFS RT hanging
---------
Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
Co-authored-by: Soren Rasmussen <s.c.rasmussen@gmail.com>
* [main] ccpp-physics SciDocs to github pages (#1207)
* add doxygen action
* minor changes
* minor changes
* minor changes
* doxy only
* Create main.yml
* Create jekyll-gh-pages.yml
* change
* add doxyfile into wkfl
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update ccpp_doxyfile
* Update ccpp_doxyfile
* update ccpp doxyfile
* Update doxygen.yml
* update doxyfile
* Update doxygen.yml
* Update doxygen.yml
* update doxyfile
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* change path
* add mactex
* add mactex
* minor changes
* minor fix
* try1
* try1
* try2
* updates
* update perl
* update perl
* update path
* explicitly install
* updates
* updates
* fix
* fix path
* fix
* fix path
* fixes
* fix3
* cleanup
* restore yml files
* hsd updates
* add doxygen.yml
* update branch
* update wflw
* test
* fix
* fix
* fix
* fix
* rearrange steps
* oops
* .
* debug
* chng dir
* chng dir
* chng dir
* -landing page
* -update para
* try to add a backlink, fix typo
* fix css link
* link path
* try cp stylesheet
* Add CCPP website
* fix
* add SRW build, backlink
* try mainpage
* changes for mainpage
* mainpage config
* mainpage config
* mainpage config
* mainpage debug
* mainpage debug
* mainpage debug
* mainpage debug
* mainpage debug
* fix landing page sidebar.
* fix landing page sidebar.
* fix landing page sidebar.
* fix landing page sidebar.
* style updates
* mainpage style
* mainpage style
* hide tree on mainpage
* add back tree
* try adding backlink
* add backlink to other pages
* updates migrated from mzhangw
* fix missed conflicts
* fix syntax
* run workflow on this branch
* remove branch from workflow run, update doxyfile
* mods to mainpag dxy
* updates
* try update for v7 arg table
* turn on scidoc branch for deploy
* recurse checkout
* fix directory
* try fix
* update landing page with acknowledgements
* fix path
* fix path
* debug
* add prebuild_config for building tables
* fix
* debug
* debug
* restructure workflow to work with metadata2html.py
* add remaining prebuild configs
* attempt fix srwv3 checkout
* fix main checkout for landing page, stash prebuild configs
* fix syntax
* update prebuild location
* workflow updates
* point to NCAR/main
---------
Co-authored-by: mzhangw <man.zhang@noaa.gov>
Co-authored-by: mzhangw <mzhangw@gmail.com>
Co-authored-by: Grant Firl <grant.firl@noaa.gov>
* fix: update actions/checkout version to v6, v4 uses deprecated nodejs version. Updating other actions to their newest release (#1215)
Co-authored-by: Grant Firl <grant.firl@noaa.gov>
* First round of updates and bug fixes for capgen-ng
* Update submodule pointer for physics/MP/TEMPO/TEMPO
* Minor bugfixes for building with capgen-ng in SCM
* ufs-dev PR#337 (#1212)
* remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations
* change Xu-Randall cloud fraction scheme to be elemental
* use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme
* modify the cld_frac_XuRandall function call in RRTMGP scheme
* add the repository update to this PR
* Revert "add the repository update to this PR"
This reverts commit 565d62cd9c7959e0981aabc2674686595fc73359.
* remove the printing tests
* remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory
* remove Zhao-Carr microphysics scheme from physics/MP directory
* remove non-ASCII character in canopy_levs.F90 (from previous PR)
* Apply suggestion from @matusmartini
Co-authored-by: Matus Martini <matusmartini@users.noreply.github.com>
---------
Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov>
Co-authored-by: Grant Firl <grant.firl@noaa.gov>
Co-authored-by: Matus Martini <matusmartini@users.noreply.github.com>
* Metadata corrections from ccpp_validator.py
* Correct dimensions for air_pressure_at_interface in physics/MP/Ferrier_Aligo/mp_fer_hires.meta
* physics/Interstitials/UFS_SCM_NEPTUNE/GFS_phys_time_vary.neptune.meta: fix intent for xlat_d and xlon_d
* ufs-dev PR#363 PR#339 PR#364 (#1213)
* remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations
* change Xu-Randall cloud fraction scheme to be elemental
* Fixed too-high lower bound for SMC
Deleted code associated with already removed print statements
Deleted excess comments.
* use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme
* Tidy-up for PR.
* modify the cld_frac_XuRandall function call in RRTMGP scheme
* Changes to the post L-IAU checks:
* Change tfreeze to match that in NoahMP
* Only set SLC to SMC if temp newly > tfreez
* add the repository update to this PR
* Revert "add the repository update to this PR"
This reverts commit 565d62cd9c7959e0981aabc2674686595fc73359.
* remove the printing tests
* remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory
* remove Zhao-Carr microphysics scheme from physics/MP directory
* Update for 10m wind option in fire_behavior module
* remove non-ASCII character in canopy_levs.F90 (from previous PR)
* Updates to progomega option of saSAS convection scheme
* Correction
* correction 2
* Correct parameter setting in samfshalcnv to pass debug runs
* address saturation vapor pressure out of bounds error in hafs_4_nest RT
---------
Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov>
Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov>
Co-authored-by: Grant Firl <grant.firl@noaa.gov>
Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu>
Co-authored-by: Lisa <lisa.bengtsson@noaa.gov>
Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov>
* Metadata corrections from ccpp_validator.py (#1219)
* resubmission: Small inconsistency between metadata and fortran code (#1222)
* Fix fortran to metadata inconsistency
* Actual fix
---------
Co-authored-by: dustinswales <dswales@ucar.edu>
* Some small changes
* UFS/dev PR#299 (#1220)
* update standard names to move Xgrs to physics_timestep_initial* and remove *_of_new_state (default name refers to 'current' value)
* fix a few unchanged standard names
* change some timestep_initial variables to general variables; make satmedmfvdifq return new tendencies and new tendency application block in GFS_PBL_generic_post
* Refactor physics tendency calculations
- Added tendency variables (`ten_t`, `ten_u`, `ten_v`) for temperature and wind tendencies in SAMF deep and shallow convection schemes.
- Updated relevant `.meta` files to reflect changes in variable intent (`inout` -> `in` where appropriate) and added tendencies.
- Modified Interstitials (`GFS_DCNV_generic_post`, `GFS_DCNV_generic_pre`, `GFS_SCNV_generic_post`, `GFS_SCNV_generic_pre`) to directly use tendencies instead of saved state variables.
- Removed redundant saved variables (`save_u`, `save_v`, `save_t`).
- Added `delt` to post interstitials.
* update unified_ugwp, ugwpv1, and drag_suite to use new tendency code
* save tendency work with GFS_photochemistry
* add tracer tendency changes to convection; fix typos in GFS_photochemistry
* fix typo in samfdeepcnv.f
* save tendency work with Thompson MP
* save tendency work with radiation
* add FMS to ccpp-physics CMakeLists.txt for fv3
* add initial setting of state in GFS_time_vary_pre.fv3; fix horizontal_dimension in GFS_time_vary_pre.scm
* fix metadata in GFS_time_vary_pre.fv3
* add momentum tendency output to mp_thompson and fix intent in metadata
* fix array size bug in mp_thompson.F90; cleanup dtend code using new tendency paradigm; cleanup saving of states no longer needed
* fix improperly-merged conflict resolution in GFS_photochemistry.F90
* fix access of ntlnc/ntinc access of tracer array when missing
* convert many RAD, PBL, GWD, CONV, and MP schemes to return tendencies
* convert MG micro and Arakawa-Wu adjustment schemes
* convert MYNNEDMF PBL scheme to return tendencies
* add changes to MYNN EDMF PBL
* add back divide-by-zero bugfix in module_sf_noahmp_glacier.F90 that was removed recently
* remove obsolete interstitial schemes
* fix 2 minor compilation issues after testing with UFS RTs
* fix bug in MG MP
* fix near-surface air temperature standard name in GFS_surface_composites_pre
* apply tendency cleanup to GFDLMPv3 and TEMPO
* fix compilation error
* fix typo in TEMPO
* debug sgscloud_radpre/post
* remove tendency application code from rrtmg_lw/sw_post
* change thmpsn to thompson to fix compilation error
* fix compilation errors in GFS_radiation_post.F90
* remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations
* fix array size problem in cs_conv.F90
* refactor RAS tendencies
* fix compilation error in rascnv.F90
* change Xu-Randall cloud fraction scheme to be elemental
* Fixed too-high lower bound for SMC
Deleted code associated with already removed print statements
Deleted excess comments.
* use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme
* Tidy-up for PR.
* modify the cld_frac_XuRandall function call in RRTMGP scheme
* Changes to the post L-IAU checks:
* Change tfreeze to match that in NoahMP
* Only set SLC to SMC if temp newly > tfreez
* add the repository update to this PR
* Revert "add the repository update to this PR"
This reverts commit 565d62cd9c7959e0981aabc2674686595fc73359.
* fix bug in GFDLMPv3 tendency implementation
* remove the printing tests
* remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory
* remove Zhao-Carr microphysics scheme from physics/MP directory
* fix hail tendency changes from reviewer suggestions
* fix indexing bug in cu_tiedtke caught in code review
* changes to RAS tendency application update code from code review
* check for flag_for_generic_tendency_due_to_gravity_wave_drag before computing diagnostic tendencies in drag_suite
* fix diagnostic tendency bug in physics/GWD/ugwpv1_gsldrag.F90
* remove unused arguments in physics/GWD/ugwpv1_gsldrag_post.F90
* fix tendency diagnostics in physics/GWD/unified_ugwp.F90
* fix merge problem in mp_thompson.meta
* add arguments to drag_suite_run called outside of ccpp entry point
* initialize dclw variables in cu_ntiedtke
* fix loop bounds for ten_q in cu_gf_driver.F90
* fix loop bounds in cu_c3_driver
* fix new_q typo in mp_fer_hires.F90
* deallocate locally-allocated variables in MP schemes
* update zeroing logic in m_micro_post after review
* Update for 10m wind option in fire_behavior module
* remove non-ASCII character in canopy_levs.F90 (from previous PR)
* Updates to progomega option of saSAS convection scheme
* Correction
* correction 2
* fix line in SHOC where a tracer was being updated directly
* remove old_ozone array since it was not being used
* deallocate local variables in satmedmfvdifq at end of run phase
* save temperature before modification to pass in to diagnostics in GFS_radiation_post
* fix diagnostic temp tendency in GFS_MP_generic.F90 for when radar is/isn't available
* Correct parameter setting in samfshalcnv to pass debug runs
* address saturation vapor pressure out of bounds error in hafs_4_nest RT
* update long names to remove 'updated by physics'; change prognostic updraft standard names
* remove additional references to Zhao-Carr microphysics
* remove Zhao-Carr references from GFS_scnv_generic_post
* fix deallocation statement in Thompson MP
* fix additional warnings
* Bug fix in physics/GWD/rayleigh_damp.f: don't mix scalars and rank-2 arrays
* remove whitespace changes in radiation_clouds.f
---------
Co-authored-by: VanderleiVargas-NOAA <vanderlei.vargas@noaa.gov>
Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov>
Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov>
Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu>
Co-authored-by: Lisa <lisa.bengtsson@noaa.gov>
Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov>
Co-authored-by: Grant Firl <grant@Macbook-Air-M4.local>
Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
* Add metadata to physcons.F90
* Fix metadata vs Fortran inconsistencies in GFS_PBL_generic_post.meta and mp_nssl.{F90,meta}
* Some inconsistencies found by validator
* Fix inconsistencies Fortran vs Metadata physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_pre.meta
* Few more small changes
* number_of_openmp_threads --> number_of_physics_threads in all schemes
* C3
* Fix inconsistencies in metadata/fortran
* More metadata/source inconsistencies
* Ufs dev pr367 (#1223)
* update standard names to move Xgrs to physics_timestep_initial* and remove *_of_new_state (default name refers to 'current' value)
* fix a few unchanged standard names
* change some timestep_initial variables to general variables; make satmedmfvdifq return new tendencies and new tendency application block in GFS_PBL_generic_post
* Refactor physics tendency calculations
- Added tendency variables (`ten_t`, `ten_u`, `ten_v`) for temperature and wind tendencies in SAMF deep and shallow convection schemes.
- Updated relevant `.meta` files to reflect changes in variable intent (`inout` -> `in` where appropriate) and added tendencies.
- Modified Interstitials (`GFS_DCNV_generic_post`, `GFS_DCNV_generic_pre`, `GFS_SCNV_generic_post`, `GFS_SCNV_generic_pre`) to directly use tendencies instead of saved state variables.
- Removed redundant saved variables (`save_u`, `save_v`, `save_t`).
- Added `delt` to post interstitials.
* update unified_ugwp, ugwpv1, and drag_suite to use new tendency code
* save tendency work with GFS_photochemistry
* add tracer tendency changes to convection; fix typos in GFS_photochemistry
* fix typo in samfdeepcnv.f
* save tendency work with Thompson MP
* save tendency work with radiation
* add FMS to ccpp-physics CMakeLists.txt for fv3
* add initial setting of state in GFS_time_vary_pre.fv3; fix horizontal_dimension in GFS_time_vary_pre.scm
* fix metadata in GFS_time_vary_pre.fv3
* add momentum tendency output to mp_thompson and fix intent in metadata
* fix array size bug in mp_thompson.F90; cleanup dtend code using new tendency paradigm; cleanup saving of states no longer needed
* fix improperly-merged conflict resolution in GFS_photochemistry.F90
* fix access of ntlnc/ntinc access of tracer array when missing
* convert many RAD, PBL, GWD, CONV, and MP schemes to return tendencies
* convert MG micro and Arakawa-Wu adjustment schemes
* convert MYNNEDMF PBL scheme to return tendencies
* add changes to MYNN EDMF PBL
* add back divide-by-zero bugfix in module_sf_noahmp_glacier.F90 that was removed recently
* remove obsolete interstitial schemes
* fix 2 minor compilation issues after testing with UFS RTs
* fix bug in MG MP
* fix near-surface air temperature standard name in GFS_surface_composites_pre
* apply tendency cleanup to GFDLMPv3 and TEMPO
* fix compilation error
* fix typo in TEMPO
* debug sgscloud_radpre/post
* remove tendency application code from rrtmg_lw/sw_post
* change thmpsn to thompson to fix compilation error
* fix compilation errors in GFS_radiation_post.F90
* remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations
* fix array size problem in cs_conv.F90
* refactor RAS tendencies
* fix compilation error in rascnv.F90
* change Xu-Randall cloud fraction scheme to be elemental
* Fixed too-high lower bound for SMC
Deleted code associated with already removed print statements
Deleted excess comments.
* use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme
* Tidy-up for PR.
* modify the cld_frac_XuRandall function call in RRTMGP scheme
* Changes to the post L-IAU checks:
* Change tfreeze to match that in NoahMP
* Only set SLC to SMC if temp newly > tfreez
* add the repository update to this PR
* Revert "add the repository update to this PR"
This reverts commit 565d62cd9c7959e0981aabc2674686595fc73359.
* fix bug in GFDLMPv3 tendency implementation
* remove the printing tests
* remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory
* remove Zhao-Carr microphysics scheme from physics/MP directory
* fix hail tendency changes from reviewer suggestions
* fix indexing bug in cu_tiedtke caught in code review
* changes to RAS tendency application update code from code review
* check for flag_for_generic_tendency_due_to_gravity_wave_drag before computing diagnostic tendencies in drag_suite
* fix diagnostic tendency bug in physics/GWD/ugwpv1_gsldrag.F90
* remove unused arguments in physics/GWD/ugwpv1_gsldrag_post.F90
* fix tendency diagnostics in physics/GWD/unified_ugwp.F90
* fix merge problem in mp_thompson.meta
* add arguments to drag_suite_run called outside of ccpp entry point
* initialize dclw variables in cu_ntiedtke
* fix loop bounds for ten_q in cu_gf_driver.F90
* fix loop bounds in cu_c3_driver
* fix new_q typo in mp_fer_hires.F90
* deallocate locally-allocated variables in MP schemes
* update zeroing logic in m_micro_post after review
* Update for 10m wind option in fire_behavior module
* remove non-ASCII character in canopy_levs.F90 (from previous PR)
* Updates to progomega option of saSAS convection scheme
* Correction
* correction 2
* fix line in SHOC where a tracer was being updated directly
* remove old_ozone array since it was not being used
* deallocate local variables in satmedmfvdifq at end of run phase
* save temperature before modification to pass in to diagnostics in GFS_radiation_post
* Remove goto in physics/MP/Morrison_Gettelman/aer_cloud.F
* Remove goto in physics/Radiation/radiation_clouds.f
* fix diagnostic temp tendency in GFS_MP_generic.F90 for when radar is/isn't available
* Correct parameter setting in samfshalcnv to pass debug runs
* Name END DO
* Remove goto physics/MP/calpreciptype.f90
* Remove goto physics/MP/Morrison_Gettelman/cldwat2m_micro.F
* Start goto physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90
* Remove goto physics/SFC_Layer/UFS/module_nst_model.f90
* address saturation vapor pressure out of bounds error in hafs_4_nest RT
* update long names to remove 'updated by physics'; change prognostic updraft standard names
* remove additional references to Zhao-Carr microphysics
* remove Zhao-Carr references from GFS_scnv_generic_post
* fix deallocation statement in Thompson MP
* Remove go to physics/CONV/C3/cu_c3_sh.F90
* Remove go to physics/PBL/MYJ/module_BL_MYJPBL.F90
* Remove goto physics/MP/Morrison_Gettelman/wv_saturation.F
* Again physics/MP/Morrison_Gettelman/wv_saturation.F
* physics/MP/Morrison_Gettelman/wv_saturation.F
* Typo
* Remove goto physics/CONV/C3/cu_c3_deep.F90
* Remove go to physics/CONV/RAS/rascnv.F90
* Typo rascnv.F90
* physics/SFC_Layer/GFDL/gfdl_sfc_layer.F90
* physics/CONV/Grell_Freitas/cu_gf_sh.F90
* Typo module_BL_MYJPBL.F90
* physics/SFC_Layer/MYJ/module_SF_JSFC.F90
* First pass physics/CONV/Grell_Freitas/cu_gf_deep.F90
* physics/CONV/Grell_Freitas/cu_gf_deep.F90
* physics/GWD/ugwp_driver_v0.F
* physics/MP/Thompson/module_mp_thompson.F90
* physics/PBL/MYNN_EDMF/module_bl_mynn.F90
* physics/MP/GFDL/v1_2019/gfdl_cloud_microphys_mod.F90
* physics/MP/GFDL/v3_2022/gfdl_cloud_microphys_v3_mod.F90
* Fix compile physics/Radiation/radiation_clouds.f
* Compile fixes
* Fix for 73 character limit line
* Compile fix
* Start physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90
* physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90
* fix additional warnings
* Fix compile hafsw wcoss2
* Revert rascnv so control_ras_intel b4b on wcoss2
* remove whitespace changes in radiation_clouds.f
---------
Co-authored-by: Grant Firl <grant.firl@noaa.gov>
Co-authored-by: VanderleiVargas-NOAA <vanderlei.vargas@noaa.gov>
Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov>
Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov>
Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu>
Co-authored-by: Lisa <lisa.bengtsson@noaa.gov>
Co-authored-by: Nicholas Szapiro <149816583+NickSzapiro-NOAA@users.noreply.github.com>
Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov>
Co-authored-by: Nick Szapiro <nick.szapiro@noaa.gov>
Co-authored-by: Nick Szapiro <nick.szapiro@clogin06.cactus.wcoss2.ncep.noaa.gov>
Co-authored-by: Grant Firl <grant@Macbook-Air-M4.local>
* ufs-dev PR#371 (#1224)
* update standard names to move Xgrs to physics_timestep_initial* and remove *_of_new_state (default name refers to 'current' value)
* fix a few unchanged standard names
* change some timestep_initial variables to general variables; make satmedmfvdifq return new tendencies and new tendency application block in GFS_PBL_generic_post
* Refactor physics tendency calculations
- Added tendency variables (`ten_t`, `ten_u`, `ten_v`) for temperature and wind tendencies in SAMF deep and shallow convection schemes.
- Updated relevant `.meta` files to reflect changes in variable intent (`inout` -> `in` where appropriate) and added tendencies.
- Modified Interstitials (`GFS_DCNV_generic_post`, `GFS_DCNV_generic_pre`, `GFS_SCNV_generic_post`, `GFS_SCNV_generic_pre`) to directly use tendencies instead of saved state variables.
- Removed redundant saved variables (`save_u`, `save_v`, `save_t`).
- Added `delt` to post interstitials.
* update unified_ugwp, ugwpv1, and drag_suite to use new tendency code
* save tendency work with GFS_photochemistry
* add tracer tendency changes to convection; fix typos in GFS_photochemistry
* fix typo in samfdeepcnv.f
* save tendency work with Thompson MP
* save tendency work with radiation
* add FMS to ccpp-physics CMakeLists.txt for fv3
* add initial setting of state in GFS_time_vary_pre.fv3; fix horizontal_dimension in GFS_time_vary_pre.scm
* fix metadata in GFS_time_vary_pre.fv3
* add momentum tendency output to mp_thompson and fix intent in metadata
* fix array size bug in mp_thompson.F90; cleanup dtend code using new tendency paradigm; cleanup saving of states no longer needed
* fix improperly-merged conflict resolution in GFS_photochemistry.F90
* fix access of ntlnc/ntinc access of tracer array when missing
* convert many RAD, PBL, GWD, CONV, and MP schemes to return tendencies
* convert MG micro and Arakawa-Wu adjustment schemes
* convert MYNNEDMF PBL scheme to return tendencies
* add changes to MYNN EDMF PBL
* add back divide-by-zero bugfix in module_sf_noahmp_glacier.F90 that was removed recently
* remove obsolete interstitial schemes
* fix 2 minor compilation issues after testing with UFS RTs
* fix bug in MG MP
* fix near-surface air temperature standard name in GFS_surface_composites_pre
* apply tendency cleanup to GFDLMPv3 and TEMPO
* fix compilation error
* fix typo in TEMPO
* debug sgscloud_radpre/post
* remove tendency application code from rrtmg_lw/sw_post
* change thmpsn to thompson to fix compilation error
* fix compilation errors in GFS_radiation_post.F90
* remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations
* fix array size problem in cs_conv.F90
* refactor RAS tendencies
* fix compilation error in rascnv.F90
* change Xu-Randall cloud fraction scheme to be elemental
* Fixed too-high lower bound for SMC
Deleted code associated with already removed print statements
Deleted excess comments.
* use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme
* Tidy-up for PR.
* modify the cld_frac_XuRandall function call in RRTMGP scheme
* Changes to the post L-IAU checks:
* Change tfreeze to match that in NoahMP
* Only set SLC to SMC if temp newly > tfreez
* add the repository update to this PR
* Revert "add the repository update to this PR"
This reverts commit 565d62cd9c7959e0981aabc2674686595fc73359.
* fix bug in GFDLMPv3 tendency implementation
* remove the printing tests
* remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory
* remove Zhao-Carr microphysics scheme from physics/MP directory
* fix hail tendency changes from reviewer suggestions
* fix indexing bug in cu_tiedtke caught in code review
* changes to RAS tendency application update code from code review
* check for flag_for_generic_tendency_due_to_gravity_wave_drag before computing diagnostic tendencies in drag_suite
* fix diagnostic tendency bug in physics/GWD/ugwpv1_gsldrag.F90
* remove unused arguments in physics/GWD/ugwpv1_gsldrag_post.F90
* fix tendency diagnostics in physics/GWD/unified_ugwp.F90
* fix merge problem in mp_thompson.meta
* add arguments to drag_suite_run called outside of ccpp entry point
* initialize dclw variables in cu_ntiedtke
* fix loop bounds for ten_q in cu_gf_driver.F90
* fix loop bounds in cu_c3_driver
* fix new_q typo in mp_fer_hires.F90
* deallocate locally-allocated variables in MP schemes
* update zeroing logic in m_micro_post after review
* Update for 10m wind option in fire_behavior module
* remove non-ASCII character in canopy_levs.F90 (from previous PR)
* Updates to progomega option of saSAS convection scheme
* Correction
* correction 2
* fix line in SHOC where a tracer was being updated directly
* remove old_ozone array since it was not being used
* deallocate local variables in satmedmfvdifq at end of run phase
* save temperature before modification to pass in to diagnostics in GFS_radiation_post
* Remove goto in physics/MP/Morrison_Gettelman/aer_cloud.F
* Remove goto in physics/Radiation/radiation_clouds.f
* fix diagnostic temp tendency in GFS_MP_generic.F90 for when radar is/isn't available
* Correct parameter setting in samfshalcnv to pass debug runs
* Name END DO
* Remove goto physics/MP/calpreciptype.f90
* Remove goto physics/MP/Morrison_Gettelman/cldwat2m_micro.F
* Start goto physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90
* Remove goto physics/SFC_Layer/UFS/module_nst_model.f90
* address saturation vapor pressure out of bounds error in hafs_4_nest RT
* update long names to remove 'updated by physics'; change prognostic updraft standard names
* remove additional references to Zhao-Carr microphysics
* remove Zhao-Carr references from GFS_scnv_generic_post
* fix deallocation statement in Thompson MP
* Remove go to physics/CONV/C3/cu_c3_sh.F90
* Remove go to physics/PBL/MYJ/module_BL_MYJPBL.F90
* Remove goto physics/MP/Morrison_Gettelman/wv_saturation.F
* Again physics/MP/Morrison_Gettelman/wv_saturation.F
* physics/MP/Morrison_Gettelman/wv_saturation.F
* Typo
* Remove goto physics/CONV/C3/cu_c3_deep.F90
* Remove go to physics/CONV/RAS/rascnv.F90
* Typo rascnv.F90
* physics/SFC_Layer/GFDL/gfdl_sfc_layer.F90
* physics/CONV/Grell_Freitas/cu_gf_sh.F90
* Typo module_BL_MYJPBL.F90
* physics/SFC_Layer/MYJ/module_SF_JSFC.F90
* First pass physics/CONV/Grell_Freitas/cu_gf_deep.F90
* physics/CONV/Grell_Freitas/cu_gf_deep.F90
* physics/GWD/ugwp_driver_v0.F
* physics/MP/Thompson/module_mp_thompson.F90
* physics/PBL/MYNN_EDMF/module_bl_mynn.F90
* physics/MP/GFDL/v1_2019/gfdl_cloud_microphys_mod.F90
* physics/MP/GFDL/v3_2022/gfdl_cloud_microphys_v3_mod.F90
* Fix compile physics/Radiation/radiation_clouds.f
* Compile fixes
* Fix for 73 character limit line
* Compile fix
* Start physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90
* physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90
* fix additional warnings
* Fix compile hafsw wcoss2
* Revert rascnv so control_ras_intel b4b on wcoss2
* Use 10-m intepolated winds in the explicit in-canopy diffusion of tracers. Remove hpbl/kpbl update due to explicit in-canopy diffusion.
* Clean up commented out code. Correct a truncated source line.
* Comment out the integrated-canopy meteorology effect. Keep the lines for future PR with the canopy met effects.
* revert radiation_clouds.f
---------
Co-authored-by: Grant Firl <grant.firl@noaa.gov>
Co-authored-by: VanderleiVargas-NOAA <vanderlei.vargas@noaa.gov>
Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov>
Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov>
Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu>
Co-authored-by: Lisa <lisa.bengtsson@noaa.gov>
Co-authored-by: Nicholas Szapiro <149816583+NickSzapiro-NOAA@users.noreply.github.com>
Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov>
Co-authored-by: Nick Szapiro <nick.szapiro@noaa.gov>
Co-authored-by: Nick Szapiro <nick.szapiro@clogin06.cactus.wcoss2.ncep.noaa.gov>
Co-authored-by: iri01 <i.t.ivanova@gmail.com>
Co-authored-by: iri01 <129897017+iri01@users.noreply.github.com>
Co-authored-by: Grant Firl <grant@Macbook-Air-M4.local>
Co-authored-by: Tracy <hertneky@ucar.edu>
* ufs-dev PR#365 (#1225)
* update standard names to move Xgrs to physics_timestep_initial* and remove *_of_new_state (default name refers to 'current' value)
* fix a few unchanged standard names
* change some timestep_initial variables to general variables; make satmedmfvdifq return new tendencies and new tendency application block in GFS_PBL_generic_post
* Refactor physics tendency calculations
- Added tendency variables (`ten_t`, `ten_u`, `ten_v`) for temperature and wind tendencies in SAMF deep and shallow convection schemes.
- Updated relevant `.meta` files to reflect changes in variable intent (`inout` -> `in` where appropriate) and added tendencies.
- Modified Interstitials (`GFS_DCNV_generic_post`, `GFS_DCNV_generic_pre`, `GFS_SCNV_generic_post`, `GFS_SCNV_generic_pre`) to directly use tendencies instead of saved state variables.
- Removed redundant saved variables (`save_u`, `save_v`, `save_t`).
- Added `delt` to post interstitials.
* update unified_ugwp, ugwpv1, and drag_suite to use new tendency code
* save tendency work with GFS_photochemistry
* add tracer tendency changes to convection; fix typos in GFS_photochemistry
* fix typo in samfdeepcnv.f
* save tendency work with Thompson MP
* save tendency work with radiation
* add FMS to ccpp-physics CMakeLists.txt for fv3
* add initial setting of state in GFS_time_vary_pre.fv3; fix horizontal_dimension in GFS_time_vary_pre.scm
* fix metadata in GFS_time_vary_pre.fv3
* add momentum tendency output to mp_thompson and fix intent in metadata
* fix array size bug in mp_thompson.F90; cleanup dtend code using new tendency paradigm; cleanup saving of states no longer needed
* fix improperly-merged conflict resolution in GFS_photochemistry.F90
* fix access of ntlnc/ntinc access of tracer array when missing
* convert many RAD, PBL, GWD, CONV, and MP schemes to return tendencies
* convert MG micro and Arakawa-Wu adjustment schemes
* convert MYNNEDMF PBL scheme to return tendencies
* add changes to MYNN EDMF PBL
* add back divide-by-zero bugfix in module_sf_noahmp_glacier.F90 that was removed recently
* remove obsolete interstitial schemes
* fix 2 minor compilation issues after testing with UFS RTs
* fix bug in MG MP
* fix near-surface air temperature standard name in GFS_surface_composites_pre
* apply tendency cleanup to GFDLMPv3 and TEMPO
* fix compilation error
* fix typo in TEMPO
* debug sgscloud_radpre/post
* remove tendency application code from rrtmg_lw/sw_post
* change thmpsn to thompson to fix compilation error
* fix compilation errors in GFS_radiation_post.F90
* remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations
* fix array size problem in cs_conv.F90
* refactor RAS tendencies
* fix compilation error in rascnv.F90
* change Xu-Randall cloud fraction scheme to be elemental
* Fixed too-high lower bound for SMC
Deleted code associated with already removed print statements
Deleted excess comments.
* use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme
* Tidy-up for PR.
* modify the cld_frac_XuRandall function call in RRTMGP scheme
* Changes to the post L-IAU checks:
* Change tfreeze to match that in NoahMP
* Only set SLC to SMC if temp newly > tfreez
* add the repository update to this PR
* Revert "add the repository update to this PR"
This reverts commit 565d62cd9c7959e0981aabc2674686595fc73359.
* fix bug in GFDLMPv3 tendency implementation
* remove the printing tests
* remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory
* remove Zhao-Carr microphysics scheme from physics/MP directory
* Chagne to not using ozone physics DDT when not active
* fix hail tendency changes from reviewer suggestions
* fix indexing bug in cu_tiedtke caught in code review
* changes to RAS tendency application update code from code review
* check for flag_for_generic_tendency_due_to_gravity_wave_drag before computing diagnostic tendencies in drag_suite
* fix diagnostic tendency bug in physics/GWD/ugwpv1_gsldrag.F90
* remove unused arguments in physics/GWD/ugwpv1_gsldrag_post.F90
* fix tendency diagnostics in physics/GWD/unified_ugwp.F90
* fix merge problem in mp_thompson.meta
* add arguments to drag_suite_run called outside of ccpp entry point
* initialize dclw variables in cu_ntiedtke
* fix loop bounds for ten_q in cu_gf_driver.F90
* fix loop bounds in cu_c3_driver
* fix new_q typo in mp_fer_hires.F90
* deallocate locally-allocated variables in MP schemes
* update zeroing logic in m_micro_post after review
* Update for 10m wind option in fire_behavior module
* remove non-ASCII character in canopy_levs.F90 (from previous PR)
* Updates to progomega option of saSAS convection scheme
* Correction
* correction 2
* fix line in SHOC where a tracer was being updated directly
* remove old_ozone array since it was not being used
* deallocate local variables in satmedmfvdifq at end of run phase
* save temperature before modification to pass in to diagnostics in GFS_radiation_post
* Remove goto in physics/MP/Morrison_Gettelman/aer_cloud.F
* Remove goto in physics/Radiation/radiation_clouds.f
* fix diagnostic temp tendency in GFS_MP_generic.F90 for when radar is/isn't available
* Correct parameter setting in samfshalcnv to pass debug runs
* Name END DO
* Remove goto physics/MP/calpreciptype.f90
* Remove goto physics/MP/Morrison_Gettelman/cldwat2m_micro.F
* Start goto physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90
* Remove goto physics/SFC_Layer/UFS/module_nst_model.f90
* address saturation vapor pressure out of bounds error in hafs_4_nest RT
* update long names to remove 'updated by physics'; change prognostic updraft standard names
* remove additional references to Zhao-Carr microphysics
* remove Zhao-Carr references from GFS_scnv_generic_post
* fix deallocation statement in Thompson MP
* Remove go to physics/CONV/C3/cu_c3_sh.F90
* Remove go to physics/PBL/MYJ/module_BL_MYJPBL.F90
* Remove goto physics/MP/Morrison_Gettelman/wv_saturation.F
* Again physics/MP/Morrison_Gettelman/wv_saturation.F
* physics/MP/Morrison_Gettelman/wv_saturation.F
* Typo
* Remove goto physics/CONV/C3/cu_c3_deep.F90
* Remove go to physics/CONV/RAS/rascnv.F90
* Typo rascnv.F90
* physics/SFC_Layer/GFDL/gfdl_sfc_layer.F90
* physics/CONV/Grell_Freitas/cu_gf_sh.F90
* Typo module_BL_MYJPBL.F90
* physics/SFC_Layer/MYJ/module_SF_JSFC.F90
* First pass physics/CONV/Grell_Freitas/cu_gf_deep.F90
* physics/CONV/Grell_Freitas/cu_gf_deep.F90
* physics/GWD/ugwp_driver_v0.F
* physics/MP/Thompson/module_mp_thompson.F90
* physics/PBL/MYNN_EDMF/module_bl_mynn.F90
* physics/MP/GFDL/v1_2019/gfdl_cloud_microphys_mod.F90
* physics/MP/GFDL/v3_2022/gfdl_cloud_microphys_v3_mod.F90
* Fix compile physics/Radiation/radiation_clouds.f
* Compile fixes
* Fix for 73 character limit line
* Compile fix
* Start physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90
* physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90
* fix additional warnings
* Fix compile hafsw wcoss2
* Revert rascnv so control_ras_intel b4b on wcoss2
* Use 10-m intepolated winds in the explicit in-canopy diffusion of tracers. Remove hpbl/kpbl update due to explicit in-canopy diffusion.
* Clean up commented out code. Correct a truncated source line.
* Bug in gcycle error message
* Comment out the integrated-canopy meteorology effect. Keep the lines for future PR with the canopy met effects.
---------
Co-authored-by: Grant Firl <grant.firl@noaa.gov>
Co-authored-by: VanderleiVargas-NOAA <vanderlei.vargas@noaa.gov>
Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov>
Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov>
Co-authored-by: Dustin Swales <dustin.swales@noaa.gov>
Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu>
Co-authored-by: Lisa <lisa.bengtsson@noaa.gov>
Co-authored-by: Nicholas Szapiro <149816583+NickSzapiro-NOAA@users.noreply.github.com>
Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov>
Co-authored-by: Nick Szapiro <nick.szapiro@noaa.gov>
Co-authored-by: Nick Szapiro <nick.szapiro@clogin06.cactus.wcoss2.ncep.noaa.gov>
Co-authored-by: iri01 <i.t.ivanova@gmail.com>
Co-authored-by: iri01 <129897017+iri01@users.noreply.github.com>
Co-authored-by: Grant Firl <grant@Macbook-Air-M4.local>
Co-authored-by: Tracy <hertneky@ucar.edu>
* copy fix from FV3 version to SCM version of GFS_phys_time_vary (#1227)
* UGWP_v0: Scale cdmbgwd(1:2) by inverse square root of dx (#1218)
* GW multiplication factors scaled by inverse square root of dx (#82)
* Scale cdmb with the inverse square root of dxres in ugwp_v0
* Scale cleff with the inverse square root of dxres in ugwp_v0
* Replace the non-ascii 1/2 with its ascii representation to satisfy ci
test requirement.
* Unify cdmbgwd0 and cdmbgwd (#83)
* Make cdmbgwd0 to be rank 4
* Unify cdmbgwd0 and cdmbgwd
* Remove unnecessary line
* Multiply coefficients by a power of 10
* add Alex and Matus as codeowners for ugwp_v0
---------
Co-authored-by: Matus Martini <matus.n.martini.ctr@us.navy.mil>
Co-authored-by: Grant Firl <grant.firl@noaa.gov>
* New SciDocs for GWv1 release and LandDA capability (#1226)
* add doxygen action
* minor changes
* minor changes
* minor changes
* doxy only
* Create main.yml
* Create jekyll-gh-pages.yml
* change
* add doxyfile into wkfl
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update ccpp_doxyfile
* Update ccpp_doxyfile
* update ccpp doxyfile
* Update doxygen.yml
* update doxyfile
* Update doxygen.yml
* Update doxygen.yml
* update doxyfile
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* Update doxygen.yml
* change path
* add mactex
* add mactex
* minor changes
* minor fix
* try1
* try1
* try2
* updates
* update perl
* update perl
* update path
* explicitly install
* updates
* updates
* fix
* fix path
* fix
* fix path
* fixes
* fix3
* cleanup
* restore yml files
* hsd updates
* add doxygen.yml
* update branch
* update wflw
* test
* fix
* fix
* fix
* fix
* rearrange steps
* oops
* .
* debug
* chng dir
* chng dir
* chng dir
* -landing page
* -update para
* try to add a backlink, fix typo
* fix css link
* link path
* try cp stylesheet
* Add CCPP website
* fix
* add SRW build, backlink
* try mainpage
* changes for mainpage
* mainpage config
* mainpage config
* mainpage config
* mainpage debug
* mainpage debug
* mainpage debug
* mainpage debug
* mainpage debug
* fix landing page sidebar.
* fix landing page sidebar.
* fix landing page sidebar.
* fix landing page sidebar.
* style updates
* mainpage style
* mainpage style
* hide tree on mainpage
* add back tree
* try adding backlink
* add backlink to other pages
* updates migrated from mzhangw
* fix missed conflicts
* fix syntax
* run workflow on this branch
* remove branch from workflow run, update doxyfile
* mods to mainpag dxy
* updates
* try update for v7 arg table
* turn on scidoc branch for deploy
* recurse checkout
* fix directory
* try fix
* update landing page with acknowledgements
* fix path
* fix path
* debug
* add prebuild_config for building tables
* fix
* debug
* debug
* restructure workflow to work with metadata2html.py
* add remaining prebuild configs
* attempt fix srwv3 checkout
* fix main checkout for landing page, stash prebuild configs
* fix syntax
* update prebuild location
* workflow updates
* point to NCAR/main
* initial landDA sciDoc commits
* point to fork for testing
* point to fork for testing in 1 more place
* add sciDocs for GW release, some reorg
* point to fork
* remove main
* Changes to GW mainpage
* try fix
* fix!
* fix few things
* Add nml links
* fix land DA overview page
* fixes
* oops
* oops
* updates to GFS_ugwpv1 from Michael Toy and Bo Yang
* updates to SAMFdeep from Lisa Bengtsson
* updates from Jongil Han for convective, sfc, pbl schemes
* Update SciDoc link on README
* updates for H2O/Ozone schemes from Qingfu Lui
* fix sfclyr link
* update reference
* try bib fix
* try bib tweak
* trying to get ref to work
* fix bib links
* updates for RRTMG from Qingfu Lui
* update tracy-fork > main for merging into NCAR/main
---------
Co-authored-by: mzhangw <man.zhang@noaa.gov>
Co-authored-by: mzhangw <mzhangw@gmail.com>
Co-authored-by: Grant Firl <grant.firl@noaa.gov>
* run on upstream only since deploy will fail when run from forks (#1229)
Co-authored-by: Grant Firl <grant.firl@noaa.gov>
* ufs-dev PR#373 (#1228)
* remove old C3 directory
* add C3 as a submodule in a standalone repository
* add cu_c3_driver.meta into C3 repository to hook up with CCPP
* C3 refactoring - create new CCPP-facing interface compatible with new shared MPAS code. Move to stand alone submodule
* Remove non ascii charachters that ccpp doesn't like
* translate some comments from Portuguese to English as ccpp doesn't like the ascii format
* translate some comments from Portuguese to English as ccpp doesn't like the ascii format 2
* translate some comments from Portuguese to English as ccpp doesn't like the ascii format 3
* more ascii symbols correction
* non-ascii charachters
* Add host driver directories inside the C3 submodule and rename driver to have suffix _ccpp and _mpas respectively
* Add mod_cu_kinds module for consistent kind_phys handling
* Fix C3 CCPP plume postprocessing consistency and add neg_check to ensure moisture conservation
* Minor updates to avoid compiler warnings associated with subten-variables
* Address typos in meta files according to review comments
* Correct typo from host model causing inconsistent prebuild
* Update C3 commit to 4a41088 and update .gitmodules
---------
Co-authored-by: Lisa <lisa.bengtsson@noaa.gov>
* number_of_openmp_threads --> number_of_physics_threads
* Update submodule pointer for C3
* Add optional attribute for tke vars in cires_ugwp
* Bug fix in physics/GWD/cires_ugwp.meta
* Add back in metadata file changes that were lost?
* Remove changes accidentally intrioduced
* Remove changes accidentally intrioduced
* Remove cmakelists. Not used
* Remove commented line
* Updates for TEMPO changes
* One more TEMPO change
* Update submodule name in .gitmodules. Not impactful sice path os set correctly, but still inconsistent.
* Update physics submodules
---------
Co-authored-by: Tracy <hertneky@ucar.edu>
Co-authored-by: Grant Firl <grant.firl@noaa.gov>
Co-authored-by: Soren Rasmussen <s.c.rasmussen@gmail.com>
Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
Co-authored-by: Tracy Hertneky <39317287+hertneky@users.noreply.github.com>
Co-authored-by: mzhangw <man.zhang@noaa.gov>
Co-authored-by: mzhangw <mzhangw@gmail.com>
Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov>
Co-authored-by: Matus Martini <matusmartini@users.noreply.github.com>
Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov>
Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu>
Co-authored-by: Lisa <lisa.bengtsson@noaa.gov>
Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov>
Co-authored-by: dustinswales <dswales@ucar.edu>
Co-authored-by: VanderleiVargas-NOAA <vanderlei.vargas@noaa.gov>
Co-authored-by: Grant Firl <grant@Macbook-Air-M4.local>
Co-authored-by: Nicholas Szapiro <149816583+NickSzapiro-NOAA@users.noreply.github.com>
Co-authored-by: Nick Szapiro <nick.szapiro@noaa.gov>
Co-authored-by: Nick Szapiro <nick.szapiro@clogin06.cactus.wcoss2.ncep.noaa.gov>
Co-authored-by: iri01 <i.t.ivanova@gmail.com>
Co-authored-by: iri01 <129897017+iri01@users.noreply.github.com>
Co-authored-by: Matus Martini <matus.n.martini.ctr@us.navy.mil>
* remove unnecessary merged changes from PR branch
* fix merge conflict error
* fix whitespace
---------
Co-authored-by: VanderleiVargas-NOAA <vanderlei.vargas@noaa.gov>
Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov>
Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov>
Co-authored-by: Dustin Swales <dustin.swales@noaa.gov>
Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu>
Co-authored-by: Lisa <lisa.bengtsson@noaa.gov>
Co-authored-by: Nicholas Szapiro <149816583+NickSzapiro-NOAA@users.noreply.github.com>
Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov>
Co-authored-by: Nick Szapiro <nick.szapiro@noaa.gov>
Co-authored-by: Nick Szapiro <nick.szapiro@clogin06.cactus.wcoss2.ncep.noaa.gov>
Co-authored-by: iri01 <i.t.ivanova@gmail.com>
Co-authored-by: iri01 <129897017+iri01@users.noreply.github.com>
Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
Co-authored-by: AndersJensen-NOAA <132939212+AndersJensen-NOAA@users.noreply.github.com>
Co-authored-by: Grant Firl <grant@Macbook-Air-M4.local>
Co-authored-by: gspetro-NOAA <Gillian.Petro@noaa.gov>
Co-authored-by: Ben Koziol <bkoziol@redlineperf.com>
Co-authored-by: Wei Li <liweicugb@gmail.com>
Co-authored-by: Tracy <hertneky@ucar.edu>
Co-authored-by: Soren Rasmussen <s.c.rasmussen@gmail.com>
Co-authored-by: Tracy Hertneky <39317287+hertneky@users.noreply.github.com>
Co-authored-by: mzhangw <man.zhang@noaa.gov>
Co-authored-by: mzhangw <mzhangw@gmail.com>
Co-authored-by: Matus Martini <matusmartini@users.noreply.github.com>
Co-authored-by: dustinswales <dswales@ucar.edu>
Co-authored-by: Matus Martini <matus.n.martini.ctr@us.navy.mil>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SOURCE: Soren Rasmussen, NSF NCAR
DESCRIPTION OF CHANGES:
ISSUE:
mainbranch, Github Actions will attempt to deploy ccpp-physic's github pages from that fork and will failTests Conducted: