Conversation
hertneky
requested review from
dustinswales,
grantfirl,
mkavulich and
scrasmussen
as code owners
scrasmussen
left a comment
scrasmussen
left a comment
There was a problem hiding this comment.
PR looks good! I think we just need to figure out why the RTs are failing before merging.
Maybe just rerunning them will get it to work? Seems like the git submodule update --init --recursive couldn't find CCPP-Physics 00398289d0c26cdca7ac08a35d70853b0376ac90 commit, which is showing up for me now
|
I forgot to run the RTs locally before opening the PR. I was doing that now. Ignore this until I re-ping ya! |
Yeah - I pushed the physics to my fork well after opening the PR too - I am sure that's why it failed. Got a bit overexcited I guess. |
|
@scrasmussen |
scrasmussen
left a comment
scrasmussen
left a comment
There was a problem hiding this comment.
RTs passing now, looks good!
|
@hertneky Please make sure that the ccpp-physics submodule is updated. The latest hash after the ccpp-physics PR was merged is NCAR/ccpp-physics@35e9980. It looks like e9bbe5d only reverted .gitmodules. |
|
@hertneky Everything else looks good. I'll approve once the ccpp-physics commit hash is updated. |
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Looks perfect. Feel free to merge any time.
3 participants
This PR catches the NCAR:main branch up with changes from the ufs-community:ufs/dev branch.
This also updates the framework to point to the develop branch since the main branch is now frozen.
Associated ufs/dev PR:
Associated ufsatm PR:
Associated NCAR PR:
REGRESSION TEST CHANGES: none expected