Dynamic screenshots #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Login to local setup - Navigate to target URL - Screenshot page
- JSON file for image metadata
- Find element handle and size details - Custom functions for processing images - Refactor
- Find and process radio buttons
- util func to remove footer from full page screenshot
- refactor
Also remove descriptions from the images And add TODOs to the README.md
mikejamesthompson
requested changes
Feb 15, 2025
Contributor
There was a problem hiding this comment.
This is looking good, but I'm having issues running it as it is because the session URLs have changed and even deleting the database the IDs used for consent and school moves don't match up to what I see locally.
Apart from that, I've added some other suggestions, including some quite picky ones 😃
- rename 'url_extension' to 'path' - Improve readability of README - Make login function more uniform
- Launch playwright and login once - quicker overall
Merge in 2.0 updates to main
Make main branch up to date
…s-in-schools-guidance into dynamic-screenshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.