Skip to content

Install setuptools in dev and CI container images for editable builds #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CoryMartin-NOAA merged 3 commits into from
Sep 22, 2026
+8 −7
Merged

Install setuptools in dev and CI container images for editable builds #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a4eea2
Initial plan
Copilot Sep 22, 2026
fb234dc
fix: install setuptools in container images
Copilot Sep 22, 2026
6d8369c
remove that install from the shell script
CoryMartin-NOAA Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,13 @@ RUN git clone --branch "${BUFR_QUERY_REF}" --depth 1 \
make install && \
rm -rf /tmp/bufr-query

# Install Python dependencies declared in pyproject.toml, plus pybind11 which
# is required to build bufr-query bindings, and cloud storage CLIs for S3/GCS.
# Install Python dependencies declared in pyproject.toml, plus setuptools for
# editable installs without build isolation, pybind11 for bufr-query bindings,
# and cloud storage CLIs for S3/GCS.
COPY pyproject.toml /tmp/geode/pyproject.toml
COPY src /tmp/geode/src
RUN python -m pip install --no-cache-dir --upgrade pip && \
python -m pip install --no-cache-dir "/tmp/geode[dev]" pybind11==3.0.1 awscli==1.46.1 gsutil==5.37 && \
python -m pip install --no-cache-dir "setuptools>=61,!=79.0.1" "/tmp/geode[dev]" pybind11==3.0.1 awscli==1.46.1 gsutil==5.37 && \
rm -rf /tmp/geode

# Set working directory
Expand Down
7 changes: 4 additions & 3 deletions .devcontainer/Dockerfile_CI
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,13 @@ RUN git clone --branch "${BUFR_QUERY_REF}" --depth 1 \
make install && \
rm -rf /tmp/bufr-query

# Install Python dependencies declared in pyproject.toml, plus pybind11 which
# is required to build bufr-query bindings, and cloud storage CLIs for S3/GCS.
# Install Python dependencies declared in pyproject.toml, plus setuptools for
# editable installs without build isolation, pybind11 for bufr-query bindings,
# and cloud storage CLIs for S3/GCS.
COPY pyproject.toml /tmp/geode/pyproject.toml
COPY src /tmp/geode/src
RUN python -m pip install --no-cache-dir --upgrade pip && \
python -m pip install --no-cache-dir "/tmp/geode[dev]" pybind11==3.0.1 awscli==1.46.1 gsutil==5.37 && \
python -m pip install --no-cache-dir "setuptools>=61,!=79.0.1" "/tmp/geode[dev]" pybind11==3.0.1 awscli==1.46.1 gsutil==5.37 && \
rm -rf /tmp/geode

# Set default command
Expand Down
1 change: 0 additions & 1 deletion dev/ush/install_and_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ main() {

(
cd "${repo_root}"
python -m pip install --user "setuptools>=61,!=79.0.1"
python -m pip install --user --no-build-isolation -e ".[dev]"
python -m pytest test/ -v -s -W error::pytest.PytestUnhandledThreadExceptionWarning
)
Expand Down
Loading