Fix averaging for FH000 when using IAU#1081
Open
dpsarmie wants to merge 4 commits intoNOAA-EMC:developfrom
Open
Fix averaging for FH000 when using IAU#1081dpsarmie wants to merge 4 commits intoNOAA-EMC:developfrom
dpsarmie wants to merge 4 commits intoNOAA-EMC:developfrom
Conversation
DusanJovic-NOAA
approved these changes
Mar 26, 2026
dpsarmie
added a commit
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A bug was reported (NOAA-EMC/GFS#53) where the averaged fields in
sfcf000.ncwere not being calculated correctly. This occurred when in IAU mode and only affected the sfc file at fh000.The fix involves adding a case for fh000 in the
InitTimeFromIAUOffsetsubroutine in./fv3/atmos_model.F90where the correct averaging window is set. The functionality at other points in the model remains untouched.diag_time_fhzerowas also initialized for non-IAU cases to prevent errors. This variable is not used in non-IAU cases so that functionality remains the same.The variables that changed in sfcf000.nc in the GFSv17 tests were the following:
No other variables or files at any other forecast hour were changed.
Issue(s) addressed
Closes #1080
Testing
This fix was tested using the GFSv17 operational configuration on WCOSS2. The fix was also tested using the regression test suite of the UFSWM on Ursa.