Skip to content

Fix IAU forecast hour 00 averaging // Machine cleanup for Jet, Frontera, and S4 #3158#3161

Open
dpsarmie wants to merge 10 commits intoufs-community:developfrom
dpsarmie:fix/IAU_avg_at_fh000
Open

Fix IAU forecast hour 00 averaging // Machine cleanup for Jet, Frontera, and S4 #3158#3161
dpsarmie wants to merge 10 commits intoufs-community:developfrom
dpsarmie:fix/IAU_avg_at_fh000

Conversation

@dpsarmie
Copy link
Copy Markdown
Collaborator

@dpsarmie dpsarmie commented Mar 25, 2026

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

#3158
This PR will be cleaning up references to Jet, Frontera, and S4.

#3161
This PR will bring in a fix via the UFSATM to correct a bug that was occurring when averaging fields in IAU for forecast hour 00. The bug was originally reported here: NOAA-EMC/GFS#53 and resulted in fields showing roughly half of their expected value.
New logic was added in UFSATM to correctly average the fields when at fh000.

This change does not affect any of the atmfXXX.nc output files or any of the sfcfXXX.nc after fh000.

Here's a full list of variables that changed in sfcf000.nc when doing a bitwise comparison:

cduvb_ave
cpratb_ave
csdlf
csdsf
csulf
csulftoa
csusf
csusftoa
cwork_aveclm
dlwrf_ave
dswrf_ave
dswrf_avetoa
duvb_ave
evbs_ave
evcw_ave
gflux_ave
lhtfl_ave
nbdsf_ave
nddsf_ave
pah_ave
pevpr_ave
prateb_ave
pres_avehcb
pres_avehct
pres_avelcb
pres_avelct
pres_avemcb
pres_avemct
sbsno_ave
shtfl_ave
snohf
snowc_ave
tcdc_avebndcl
tcdc_aveclm
tcdc_avehcl
tcdc_avelcl
tcdc_avemcl
tmp_avehct
tmp_avelct
tmp_avemct
trans_ave
u-gwd_ave
uflx_ave
ulwrf_ave
ulwrf_avetoa
uswrf_ave
uswrf_avetoa
v-gwd_ave
vbdsf_ave
vddsf_ave
vflx_ave

Commit Message:

* UFSWM - clean up code for Jet, Frontera, and S4
* UFSWM - Update UFSATM with IAU averaging fix
  * UFSATM - Fix IAU averaging at FH000
 

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Documentation:

  • Documentation update NOT required.

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@dpsarmie dpsarmie marked this pull request as ready for review March 26, 2026 13:14
@FernandoAndrade-NOAA FernandoAndrade-NOAA added the No Baseline Change No Baseline Change label Mar 27, 2026
@FernandoAndrade-NOAA FernandoAndrade-NOAA changed the title Fix IAU forecast hour 00 averaging Fix IAU forecast hour 00 averaging // Machine cleanup for Jet, Frontera, and S4#3158 Mar 27, 2026
@FernandoAndrade-NOAA FernandoAndrade-NOAA changed the title Fix IAU forecast hour 00 averaging // Machine cleanup for Jet, Frontera, and S4#3158 Fix IAU forecast hour 00 averaging // Machine cleanup for Jet, Frontera, and S4 #3158 Mar 27, 2026
@FernandoAndrade-NOAA FernandoAndrade-NOAA linked an issue Mar 27, 2026 that may be closed by this pull request
@FernandoAndrade-NOAA FernandoAndrade-NOAA added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Mar 27, 2026
@FernandoAndrade-NOAA FernandoAndrade-NOAA moved this from Evaluating to Schedule in PRs to Process Mar 27, 2026
@FernandoAndrade-NOAA FernandoAndrade-NOAA added the In Testing The PR that is currently in testing stages label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

In Testing The PR that is currently in testing stages No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.

Projects

Status: Schedule

Development

Successfully merging this pull request may close these issues.

Averaging for forecast hour zero incorrect when in IAU mode Remove Jet and C5 references from scripts and files

3 participants