Remove some cray pointers from mpp/ (part 1)#1793
Open
foxtran wants to merge 6 commits intoNOAA-GFDL:mainfrom
Open
Remove some cray pointers from mpp/ (part 1)#1793foxtran wants to merge 6 commits intoNOAA-GFDL:mainfrom
mpp/ (part 1)#1793foxtran wants to merge 6 commits intoNOAA-GFDL:mainfrom
Conversation
foxtran
requested review from
bensonr,
rem1776,
uramirez8707 and
vithikashah001
as code owners
foxtran
force-pushed
the
split-2/remove-cray-pointer
branch
from
bc3272a to
98e0648
Compare
foxtran
force-pushed
the
split-2/remove-cray-pointer
branch
from
98e0648 to
c9b36b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR I've replaced all cray pointers in
mpp_sum.inc,mpp_sum_ad.inc,mpp_transmit.inc,mpp_transmit_mpi.incto Fortran pointers that is possible with Fortran 2008 features.Related to #54
It is 4 of 53 commits. So, more will come once this will be merged. I do not remember everything since I rewrite it almost 2 months ago, so I'm picking only that part of work which I can keep in my fox head.
How Has This Been Tested?
I have raised compiler errors by excluding
-fcray-pointerflag during compilation of module. Then, in semi-automatic manner, I fixed all of them. No actual tests were running (I will let CI do it).Checklist:
make distcheckpasses