Skip to content

Remove some cray pointers from mpp/ (part 1) #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
foxtran wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Remove some cray pointers from mpp/ (part 1) #1793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e44d8e8
Avoid cray pointers in mpp_sum.inc
foxtran Sep 10, 2025
bb0a3e5
Avoid cray pointers in mpp_sum_ad.inc
foxtran Sep 10, 2025
f3eccf2
Replace cray pointers with pointers with Fortran 2008 semantic in mpp…
foxtran Sep 10, 2025
236bb34
Avoid cray pointers in mpp_transmit_mpi.fh
foxtran Sep 10, 2025
c9b36b7
Use Fortran standartized way to compare pointers
foxtran Nov 20, 2025
87b9c66
Use contiguous for multidimensional arrays
foxtran Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions mpp/include/mpp_sum.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,12 @@
!#######################################################################
!> Sums 2d array across pes
subroutine MPP_SUM_2D_( a, length, pelist )
MPP_TYPE_, intent(inout) :: a(:,:) !< 2d array to sum
MPP_TYPE_, target, contiguous, intent(inout) :: a(:,:) !< 2d array to sum
integer, intent(in) :: length !< amount of indices in given 2d array
integer, intent(in), optional :: pelist(:) !< pelist to calculate sum across
MPP_TYPE_ :: a1D(length)
MPP_TYPE_, pointer :: a1D(:)

pointer( ptr, a1D )
ptr = LOC(a)
a1D(1:length) => a(:,:)
call mpp_sum( a1D, length, pelist )

return
Expand All @@ -56,13 +55,12 @@
!#######################################################################
!> Sums 3d array across pes
subroutine MPP_SUM_3D_( a, length, pelist )
MPP_TYPE_, intent(inout) :: a(:,:,:) !< 3d array to sum
MPP_TYPE_, target, contiguous, intent(inout) :: a(:,:,:) !< 3d array to sum
integer, intent(in) :: length !< amount of indices in given 3d array
integer, intent(in), optional :: pelist(:) !< pelist to calculate sum across
MPP_TYPE_ :: a1D(length)
MPP_TYPE_, pointer :: a1D(:)

pointer( ptr, a1D )
ptr = LOC(a)
a1D(1:length) => a(:,:,:)
call mpp_sum( a1D, length, pelist )

return
Expand All @@ -71,13 +69,12 @@
!#######################################################################
!> Sums 4d array across pes
subroutine MPP_SUM_4D_( a, length, pelist )
MPP_TYPE_, intent(inout) :: a(:,:,:,:) !< 4d array to sum
MPP_TYPE_, target, contiguous, intent(inout) :: a(:,:,:,:) !< 4d array to sum
integer, intent(in) :: length !< amount of indices in given 4d array
integer, intent(in), optional :: pelist(:) !< pelist to calculate sum across
MPP_TYPE_ :: a1D(length)
MPP_TYPE_, pointer :: a1D(:)

pointer( ptr, a1D )
ptr = LOC(a)
a1D(1:length) => a(:,:,:,:)
call mpp_sum( a1D, length, pelist )

return
Expand All @@ -86,13 +83,12 @@
!#######################################################################
!> Sums 5d array across pes
subroutine MPP_SUM_5D_( a, length, pelist )
MPP_TYPE_, intent(inout) :: a(:,:,:,:,:) !< 5d array to sum
MPP_TYPE_, target, contiguous, intent(inout) :: a(:,:,:,:,:) !< 5d array to sum
integer, intent(in) :: length !< amount of indices in given 5d array
integer, intent(in), optional :: pelist(:) !< pelist to calculate sum across
MPP_TYPE_ :: a1D(length)
MPP_TYPE_, pointer :: a1D(:)

pointer( ptr, a1D )
ptr = LOC(a)
a1D(1:length) => a(:,:,:,:,:)
call mpp_sum( a1D, length, pelist )

return
Expand Down
28 changes: 12 additions & 16 deletions mpp/include/mpp_sum_ad.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,12 @@
!#######################################################################
!> Sums 2d array across pes
subroutine MPP_SUM_2D_AD_( a, length, pelist )
MPP_TYPE_, intent(inout) :: a(:,:) !< 2d array to sum
MPP_TYPE_, target, contiguous, intent(inout) :: a(:,:) !< 2d array to sum
integer, intent(in) :: length !< amount of indices in given 2d array
integer, intent(in), optional :: pelist(:) !< pelist to calculate sum across
MPP_TYPE_ :: a1D(length)
MPP_TYPE_, pointer :: a1D(:)

pointer( ptr, a1D )
ptr = LOC(a)
a1D(1:length) => a(:,:)
call mpp_sum_ad( a1D, length, pelist )

return
Expand All @@ -57,13 +56,12 @@
!#######################################################################
!> Sums 3d array across pes
subroutine MPP_SUM_3D_AD_( a, length, pelist )
MPP_TYPE_, intent(inout) :: a(:,:,:) !< 3d array to sum
MPP_TYPE_, target, contiguous, intent(inout) :: a(:,:,:) !< 3d array to sum
integer, intent(in) :: length !< amount of indices in given 3d array
integer, intent(in), optional :: pelist(:) !< pelist to calculate sum across
MPP_TYPE_ :: a1D(length)
MPP_TYPE_, pointer :: a1D(:)

pointer( ptr, a1D )
ptr = LOC(a)
a1D(1:length) => a(:,:,:)
call mpp_sum_ad( a1D, length, pelist )

return
Expand All @@ -72,13 +70,12 @@
!#######################################################################
!> Sums 4d array across pes
subroutine MPP_SUM_4D_AD_( a, length, pelist )
MPP_TYPE_, intent(inout) :: a(:,:,:,:) !< 4d array to sum
MPP_TYPE_, target, contiguous, intent(inout) :: a(:,:,:,:) !< 4d array to sum
integer, intent(in) :: length !< amount of indices in given 4d array
integer, intent(in), optional :: pelist(:) !< pelist to calculate sum across
MPP_TYPE_ :: a1D(length)
MPP_TYPE_, pointer :: a1D(:)

pointer( ptr, a1D )
ptr = LOC(a)
a1D(1:length) => a(:,:,:,:)
call mpp_sum_ad( a1D, length, pelist )

return
Expand All @@ -87,13 +84,12 @@
!#######################################################################
!> Sums 5d array across pes
subroutine MPP_SUM_5D_AD_( a, length, pelist )
MPP_TYPE_, intent(inout) :: a(:,:,:,:,:) !< 5d array to sum
MPP_TYPE_, target, contiguous, intent(inout) :: a(:,:,:,:,:) !< 5d array to sum
integer, intent(in) :: length !< amount of indices in given 5d array
integer, intent(in), optional :: pelist(:) !< pelist to calculate sum across
MPP_TYPE_ :: a1D(length)
MPP_TYPE_, pointer :: a1D(:)

pointer( ptr, a1D )
ptr = LOC(a)
a1D(1:length) => a(:,:,:,:,:)
call mpp_sum_ad( a1D, length, pelist )

return
Expand Down
Loading
Loading