grid utils radius changes with GFS_CONSTANTS#1867
Merged
Merged
Conversation
JustinPerket
force-pushed
the
jp/gfs_radius_fix
branch
from
f4dc2bb to
b85ec90
Compare
bensonr
reviewed
May 14, 2026
Comment on lines
+18
to
+23
|
|
||
| #ifdef GFS_CONSTANTS | ||
| #define RADIUS (6371200.) | ||
| #else | ||
| #define RADIUS (6371000.) | ||
| #endif |
Contributor
There was a problem hiding this comment.
@JustinPerket - please add documentation stating which reference file the constants came from.
Contributor
Author
There was a problem hiding this comment.
I now have a comment matching the extant usage of Earth radius in FMSconstants and *.fh headers. Is that sufficient?
bensonr
approved these changes
May 27, 2026
JustinPerket
requested review from
rem1776,
uramirez8707 and
vithikashah001
as code owners
uramirez8707
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Suggested fix of #1866
It is failing workflow for some reason, so I'm putting it in draft
Checklist:
make distcheckpasses