Skip to content

grid utils radius changes with GFS_CONSTANTS #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vithikashah001 merged 5 commits into from
Jun 1, 2026
Merged

grid utils radius changes with GFS_CONSTANTS #1867

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
caa8b1c
grid utils radius changes with GFS_CONSTANTS
JustinPerket May 6, 2026
b85ec90
remove comment
JustinPerket May 6, 2026
e85998a
re-add comment to doc link with .fh headers
JustinPerket May 26, 2026
89824c5
linting fix
JustinPerket May 26, 2026
1659c98
Merge branch 'NOAA-GFDL:main' into jp/gfs_radius_fix
JustinPerket May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions grid_utils/constant.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@
* PARTICULAR PURPOSE. See the License for the specific language
* governing permissions and limitations under the License.
***********************************************************************/

#ifdef GFS_CONSTANTS
#define RADIUS (6371200.)
#else
#define RADIUS (6371000.)
#endif
Copy link
Copy Markdown
Contributor

@bensonr bensonr May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JustinPerket - please add documentation stating which reference file the constants came from.

Copy link
Copy Markdown
Contributor Author

@JustinPerket JustinPerket May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now have a comment matching the extant usage of Earth radius in FMSconstants and *.fh headers. Is that sufficient?

#define STRING 255

#define EPSLN8 (1.e-8)
Expand Down
Loading