Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
========================================
Coverage 84.22% 84.23%
========================================
Files 70 71 +1
Lines 4773 4978 +205
========================================
+ Hits 4020 4193 +173
- Misses 753 785 +32
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
I think this file needs to be updated. (Don't know if that will happen in another PR or not)
- still some references to
Dockerfile-ppp - instructions need to be updated to reflect this repo
There was a problem hiding this comment.
Good catch, I made some new changes
|
|
||
| env: | ||
| REGISTRY: ghcr.io | ||
| IMAGE_NAME: "noaa-gfdl/ubuntu-20-frecli-2025" |
There was a problem hiding this comment.
will this image name update with getting the new tag as well or is this something that's manually changed?
There was a problem hiding this comment.
Currently this is manually set
ceblanton
left a comment
ceblanton
left a comment
There was a problem hiding this comment.
Looking good but some still some ppp references in there.
How do we know if the pipeline works? Can we run the update_container_image action before we merge it?
| - NOAA-GFDL | ||
| dependencies: | ||
| - noaa-gfdl::hsm | ||
| - noaa-gfdl::fre-cli ==2025.04 |
There was a problem hiding this comment.
We want this fre-cli tag to be equal to the one that the action is triggering on.
There was a problem hiding this comment.
Great catch, this is an obvious one I missed
There was a problem hiding this comment.
Added a change to auto-update this when a new fre-cli tag is pushed
3 participants
This pull request contains fre-cli container files being moved from the HPC-ME repository.