Merged
Conversation
So that the "cylc lint" step works.
It would be better to not depend on fre-cli, and when the remaining app/ scripts are moved to fre-cli, we can do that.
…pp rename-split calls
10 tasks
and remove the rename-split tasks
singhd789
reviewed
Mar 25, 2026
singhd789
reviewed
Mar 25, 2026
ilaflott
approved these changes
Mar 31, 2026
Member
ilaflott
left a comment
There was a problem hiding this comment.
approving, but real quick, at least clean up create_test_conda_env a tad more for the removed code that no longer needs pylinting or pytesting
Member
|
this will partially address #177 , for removing routines from |
singhd789
reviewed
Mar 31, 2026
Ciheim
reviewed
Mar 31, 2026
- removed rose-suite.conf from gitigore - expanded flow.cylc command call for clarity - updated inline doc for clarity
Contributor
Author
|
I see what you mean, Ian. You approved but it's not a green light to merge. |
singhd789
approved these changes
Mar 31, 2026
Contributor
singhd789
left a comment
There was a problem hiding this comment.
Besides my comment/confusion about the packages in environment.yaml, I think it looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Remove the long-maligned Rose app rename-split and instead use the fre-cli rename-split.
Issue ticket number and link (if applicable)
Checklist before requesting a review
Manual Pipeline Run Details
Was the manual pipeline (
test_cloud_runner) triggered for this PR?Result of manual pipeline run:
(Paste relevant logs, output, or a link to the workflow run here)
How to trigger the manual pipeline:
The
test_cloud_runnerpipeline is not automatically associated as a required check with the PR; it must be triggered to test changes in a full post-processing run.To trigger the manual pipeline:
Follow the link to the
test_cloud_runneractions tab hereClick the dropdown "Run workflow":
a. If trying to merge from a branch on fre-workflows: choose branch from the first drop down, leave the next 2 inputs blank, and choose the fre-cli branch to test
b. If trying to merge from a fre-workflows fork: can skip first branch selection, input the fork name (ex: [user]/fre-workflows), input the fork's branch name, and choose the fre-cli branch to test
Click "Run workflow"
Note: you may need to reload the page to see your running workflow.