Skip to content

Use fre-cli rename-split#210

Merged
ceblanton merged 26 commits intomainfrom
rename-split
Mar 31, 2026
Merged

Use fre-cli rename-split#210
ceblanton merged 26 commits intomainfrom
rename-split

Conversation

@ceblanton
Copy link
Copy Markdown
Contributor

@ceblanton ceblanton commented Mar 10, 2026

Describe your changes

Remove the long-maligned Rose app rename-split and instead use the fre-cli rename-split.

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

Manual Pipeline Run Details

Was the manual pipeline (test_cloud_runner) triggered for this PR?

  • Yes
  • No

Result of manual pipeline run:

(Paste relevant logs, output, or a link to the workflow run here)

How to trigger the manual pipeline:

The test_cloud_runner pipeline is not automatically associated as a required check with the PR; it must be triggered to test changes in a full post-processing run.

To trigger the manual pipeline:

  1. Follow the link to the test_cloud_runner actions tab here

    • you should see "This workflow has a workflow_dispatch event trigger"
  2. Click the dropdown "Run workflow":

    a. If trying to merge from a branch on fre-workflows: choose branch from the first drop down, leave the next 2 inputs blank, and choose the fre-cli branch to test

    b. If trying to merge from a fre-workflows fork: can skip first branch selection, input the fork name (ex: [user]/fre-workflows), input the fork's branch name, and choose the fre-cli branch to test

  3. Click "Run workflow"

Note: you may need to reload the page to see your running workflow.

@ceblanton ceblanton requested review from ilaflott and singhd789 March 31, 2026 13:42
Copy link
Copy Markdown
Member

@ilaflott ilaflott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, but real quick, at least clean up create_test_conda_env a tad more for the removed code that no longer needs pylinting or pytesting

@ilaflott
Copy link
Copy Markdown
Member

this will partially address #177 , for removing routines from app/: combine-timeavgs, make-timeavgs, rename-split-to-pp

- removed rose-suite.conf from gitigore
- expanded flow.cylc command call for clarity
- updated inline doc for clarity
@ceblanton
Copy link
Copy Markdown
Contributor Author

I see what you mean, Ian. You approved but it's not a green light to merge.

Copy link
Copy Markdown
Contributor

@singhd789 singhd789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my comment/confusion about the packages in environment.yaml, I think it looks good

@ceblanton ceblanton merged commit bbbf65b into main Mar 31, 2026
1 check passed
@ceblanton ceblanton deleted the rename-split branch March 31, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants