Skip to content

Sign the workbook: Divyansh Pal - #17

Merged
geetxnshgoyal merged 2 commits into
NST-DEVFORGE:mainfrom
Di-vyansh:sign/Di-vyansh
Sep 23, 2026
Merged

geetxnshgoyal merged 2 commits into
NST-DEVFORGE:mainfrom
Di-vyansh:sign/Di-vyansh

Conversation

@Di-vyansh

@Di-vyansh Di-vyansh commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Signing the workbook

Name: Divyansh Pal
GitHub username: Di-vyansh

Checklist

  • I worked on a branch (sign/Di-vyansh), not on main
  • Files changed shows exactly one file: signatures/Di-vyansh.md
  • The - **GitHub:** Di-vyansh line matches my account
  • I read the README steps top to bottom

Which step did you have to look up?

@geetxnshgoyal

Copy link
Copy Markdown
Member

Hi @Di-vyansh 👋 thanks for signing the workbook! The Validate signature check failed. Here's everything to fix in one go:

  • The first line still says # Your Name. Replace Your Name with your real name, for example # Asha Rao (keep the # ).
  • The GitHub line must be exactly - **GitHub:** @Di-vyansh (with the @ and a space after the colon). Yours is - **GitHub:** @your-github-username.
  • I'm here to still has the template text. Write your own line.

How to fix it (in your clone, on the same branch as this PR):

# edit signatures/Di-vyansh.md and fix the lines above, then:
git add -A
git commit -m "Fix signature"
git push

Your finished file should look like this:

# Your Real Name

- **GitHub:** @Di-vyansh
- **Batch:** 2026
- **I'm here to:** your own line
- **One thing I've built:** a link, or nothing yet

Push to this same PR. Don't open a new one. The check re-runs by itself, and a governance reviewer is requested once it's green. Stuck? See Stuck? in the README or ask in the club group.

@geetxnshgoyal
geetxnshgoyal requested review from a team, luvyarana and saurabhyuvi14-ai and removed request for a team September 22, 2026 08:48
@Di-vyansh Di-vyansh closed this Sep 22, 2026
@Di-vyansh Di-vyansh reopened this Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

✅ @Di-vyansh, your signature passed the check. The automatic merge didn't go through, so a council member will merge it shortly.

A few polish tips for next time (no need to change this PR):

  • Your goal is quite short. Next time, say what you want to learn or build; it helps us match you with the right issues.

@geetxnshgoyal geetxnshgoyal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, Divyansh, the format is spot on. One tip: http://127.0.0.1:8080/... is a localhost address — it only works on your own machine, so nobody else can open it. Next time link a deployed URL (Vercel, Netlify, GitHub Pages) or the GitHub repo.

Approved and merged. ✅ Next: open the workbook, submit milestone 1 with this PR's link, and write your reflection.

@geetxnshgoyal
geetxnshgoyal merged commit 93dd207 into NST-DEVFORGE:main Sep 23, 2026
4 checks passed
geetxnshgoyal added a commit that referenced this pull request Sep 23, 2026
GitHub treats a PR whose branch carries an older copy of a workflow file
as one that modifies workflows, and then refuses to let GITHUB_TOKEN
merge it — stranding every fork made before the change. That bit #17, #14
and #7 today.

Only .github/workflows is restricted, so the logic moves to
.github/scripts/ (validate-signature.sh, workbook-bot.js) and the
workflow becomes a thin runner. Editing the logic from now on leaves
existing forks mergeable.

Also folds in #63: on a 403 the bot explains the stale fork and how to
sync it, instead of a vague hand-off to the council.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants