Skip to content

Sign the workbook: Ejaz Ahamed Khan - #7

Merged
geetxnshgoyal merged 2 commits into
NST-DEVFORGE:mainfrom
ejazahamed08:sign/ejazahamed08
Sep 23, 2026
Merged

geetxnshgoyal merged 2 commits into
NST-DEVFORGE:mainfrom
ejazahamed08:sign/ejazahamed08

Conversation

@ejazahamed08

@ejazahamed08 ejazahamed08 commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Signing the workbook

Name: Ejaz Ahaned Khan
GitHub username: ejazahamed08

Checklist

  • [] I worked on a branch (sign/ejazahamed08), not on main
  • [] Files changed shows exactly one file: signatures/ejazahamed08.md
  • [] The - **GitHub:** @ejazahamed08 line matches my account
  • [] I read the README steps top to bottom

Which step did you have to look up?

How to create a pull request from cli but it told me to do it on github by "creating pull request"

@ejazahamed08 ejazahamed08 changed the title Address review Signing the workbook: Ejaz Ahamed Khan Sep 21, 2026
@ejazahamed08 ejazahamed08 changed the title Signing the workbook: Ejaz Ahamed Khan Sign the workbook: Ejaz Ahamed Khan Sep 21, 2026
@geetxnshgoyal

Copy link
Copy Markdown
Member

Hi @ejazahamed08 👋 thanks for signing the workbook! The Validate signature check failed. Here's everything to fix in one go:

  • The first line must be your name after a # , like # Asha Rao. Yours is EJAZ AHAMED KHAN.

How to fix it (in your clone, on the same branch as this PR):

# edit signatures/ejazahamed08.md and fix the lines above, then:
git add -A
git commit -m "Fix signature"
git push

Your finished file should look like this:

# Your Real Name

- **GitHub:** @ejazahamed08
- **Batch:** 2026
- **I'm here to:** your own line
- **One thing I've built:** a link, or nothing yet

Push to this same PR. Don't open a new one. The check re-runs by itself, and a governance reviewer is requested once it's green. Stuck? See Stuck? in the README or ask in the club group.

@geetxnshgoyal
geetxnshgoyal requested review from a team, luvyarana and saurabhyuvi14-ai and removed request for a team September 22, 2026 08:48
@ejazahamed08
ejazahamed08 requested a review from a team as a code owner September 22, 2026 12:17
@geetxnshgoyal geetxnshgoyal reopened this Sep 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ @ejazahamed08, your signature passed the check. The automatic merge didn't go through, so a council member will merge it shortly.

A few polish tips for next time (no need to change this PR):

  • Your I'm here to line starts with "to", so it reads "I'm here to: to…". Drop the extra "to".

@geetxnshgoyal geetxnshgoyal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All correct now, Ejaz — thanks for fixing the heading. Small polish: "I'm here to: To learn…" repeats "to", and names read better in normal case ("Ejaz Ahamed Khan") than in capitals.

Approved and merged. ✅ Next: open the workbook, submit milestone 1 with this PR's link, and write your reflection.

@geetxnshgoyal
geetxnshgoyal merged commit 1bdfe13 into NST-DEVFORGE:main Sep 23, 2026
3 checks passed
geetxnshgoyal added a commit that referenced this pull request Sep 23, 2026
GitHub treats a PR whose branch carries an older copy of a workflow file
as one that modifies workflows, and then refuses to let GITHUB_TOKEN
merge it — stranding every fork made before the change. That bit #17, #14
and #7 today.

Only .github/workflows is restricted, so the logic moves to
.github/scripts/ (validate-signature.sh, workbook-bot.js) and the
workflow becomes a thin runner. Editing the logic from now on leaves
existing forks mergeable.

Also folds in #63: on a 403 the bot explains the stale fork and how to
sync it, instead of a vague hand-off to the council.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants