Skip to content

angr-management: init at 9.2.130 #360310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spencerpogo wants to merge 7 commits into from
Closed

angr-management: init at 9.2.130 #360310

spencerpogo wants to merge 7 commits into from
+196 −0

Conversation

@spencerpogo
Copy link
Contributor

@spencerpogo spencerpogo commented Nov 30, 2024 •
edited
Loading

https://github.com/angr/angr-management

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 30, 2024
@nix-owners nix-owners bot requested a review from natsukium November 30, 2024 05:47
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Nov 30, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 30, 2024
@spencerpogo
Copy link
Contributor Author

spencerpogo commented Nov 30, 2024 

--------- Impacted packages on 'x86_64-linux' ---------
17 packages added:
angr-management (init at 9.2.130) python311Packages.binsync (init at 5.2.0) python311Packages.cmake-build-extension (init at 0.6.1) python311Packages.ghidra-bri
dge (init at 1.0.0) python311Packages.jfx-bridge (init at 1.0.0) python311Packages.libbs (init at 2.8.0) python311Packages.pyhidra (init at 1.3.0) python311Pack
ages.pyqodeng (init at 0.0.11) python311Packages.pyside6-qtads (init at 4.3.1.1) python312Packages.binsync (init at 5.2.0) python312Packages.cmake-build-extensi
on (init at 0.6.1) python312Packages.ghidra-bridge (init at 1.0.0) python312Packages.jfx-bridge (init at 1.0.0) python312Packages.libbs (init at 2.8.0) python31
2Packages.pyhidra (init at 1.3.0) python312Packages.pyqodeng (init at 0.0.11) python312Packages.pyside6-qtads (init at 4.3.1.1)

6 packages updated:
python3.11-angr python3.11-angrcli python3.11-angrop python3.12-angr python3.12-angrcli python3.12-angrop

--------- Report for 'x86_64-linux' ---------
46 packages built:
angr-management angr-management.dist python311Packages.angr python311Packages.angr.dist python311Packages.angrcli python311Packages.angrcli.dist python311Packages.angrop python311Packages.angrop.dist python311Packages.binsync python311Packages.binsync.dist python311Packages.cmake-build-extension python311Packages.cmake-build-extension.dist python311Packages.ghidra-bridge python311Packages.ghidra-bridge.dist python311Packages.jfx-bridge python311Packages.jfx-bridge.dist python311Packages.libbs python311Packages.libbs.dist python311Packages.pyhidra python311Packages.pyhidra.dist python311Packages.pyqodeng python311Packages.pyqodeng.dist python311Packages.pyside6-qtads python311Packages.pyside6-qtads.dist python312Packages.angr python312Packages.angr.dist python312Packages.angrcli python312Packages.angrcli.dist python312Packages.angrop python312Packages.angrop.dist python312Packages.binsync python312Packages.binsync.dist python312Packages.cmake-build-extension python312Packages.cmake-build-extension.dist python312Packages.ghidra-bridge python312Packages.ghidra-bridge.dist python312Packages.jfx-bridge python312Packages.jfx-bridge.dist python312Packages.libbs python312Packages.libbs.dist python312Packages.pyhidra python312Packages.pyhidra.dist python312Packages.pyqodeng python312Packages.pyqodeng.dist python312Packages.pyside6-qtads python312Packages.pyside6-qtads.dist

@spencerpogo
Copy link
Contributor Author

spencerpogo commented Nov 30, 2024

@ofborg build angr-management

@nixos-discourse
Copy link

nixos-discourse commented Nov 30, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4898

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 30, 2024
@spencerpogo
Copy link
Contributor Author

spencerpogo commented Dec 1, 2024

  • Fixed merge conflicts
  • Removing first-time contribution label (this is my first PR since I updated my username)

@spencerpogo spencerpogo removed the 12.first-time contribution This PR is the author's first one; please be gentle! label Dec 1, 2024
@spencerpogo spencerpogo requested a review from fabaff December 1, 2024 04:37
@spencerpogo spencerpogo removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 1, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 1, 2024
fabaff
fabaff reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments apply to file module.

pkgs/by-name/an/angr-management/package.nix Outdated
Copy link
Member

@fabaff fabaff Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the setup.cfg file should it be thefuzz[speedup]

SuperSandro2000
SuperSandro2000 reviewed Dec 9, 2024
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Dec 9, 2024
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Dec 9, 2024
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Dec 9, 2024
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Dec 9, 2024
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Dec 9, 2024
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Dec 9, 2024
View reviewed changes
@github-actions github-actions bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 22, 2025
@fabaff
Copy link
Member

fabaff commented Mar 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 360310

x86_64-linux

✅ 34 packages built:
  • angr-management
  • angr-management.dist
  • mov-cli
  • mov-cli.dist
  • python312Packages.binsync
  • python312Packages.binsync.dist
  • python312Packages.ipython-pygments-lexers
  • python312Packages.ipython-pygments-lexers.dist
  • python312Packages.pyqodeng-angr
  • python312Packages.pyqodeng-angr.dist
  • python312Packages.qtawesome
  • python312Packages.qtawesome.dist
  • spyder (python312Packages.spyder)
  • python312Packages.spyder-kernels
  • python312Packages.spyder-kernels.dist
  • spyder.dist (python312Packages.spyder.dist)
  • python312Packages.thefuzz
  • python312Packages.thefuzz.dist
  • python313Packages.binsync
  • python313Packages.binsync.dist
  • python313Packages.ipython-pygments-lexers
  • python313Packages.ipython-pygments-lexers.dist
  • python313Packages.qtawesome
  • python313Packages.qtawesome.dist
  • python313Packages.spyder
  • python313Packages.spyder-kernels
  • python313Packages.spyder-kernels.dist
  • python313Packages.spyder.dist
  • python313Packages.thefuzz
  • python313Packages.thefuzz.dist
  • rare
  • rare.dist
  • sublime-music
  • sublime-music.dist

@fabaff
Copy link
Member

fabaff commented Mar 23, 2025

angr-management works till one tries to open a file (seg fault).

@github-actions github-actions bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 23, 2025
@ConnorNelson
Copy link
Contributor

ConnorNelson commented Mar 27, 2025

angr-management works till one tries to open a file (seg fault).

It doesn't seem to segfault when I open a binary using this current version of the PR.

This is how I am testing it:
https://github.com/pwncollege/dojo/blob/ed640ba6bb65eadee9439bceee4c5c7ef101f5a1/workspace/flake.nix#L32
https://github.com/pwncollege/dojo/blob/ed640ba6bb65eadee9439bceee4c5c7ef101f5a1/workspace/additional/additional.nix#L40

In other words, I'm using nixos-24.11, and overlaying the angr-management from this PR. I don't know nix nearly well enough to understand how this might complicate understanding the issue. Does this imply some dependencies for angr-management are now coming from nixos-24.11 instead of master; I assume not?

I'm using X (not sure if somehow Wayland could cause issues?).

I also asked the maintainers of the angr-management project what they think might lead to a segfault when opening a binary; they think a good place to start looking might be in qt (e.g. a version mismatch between qt and what is expected by https://github.com/mborgerson/pyside6_qtads for instance). They said the stack trace of the segfault would be very helpful.

@fabaff
Copy link
Member

fabaff commented Mar 27, 2025

Let me see what I can do about the stacktrace.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@ConnorNelson
Copy link
Contributor

ConnorNelson commented Apr 4, 2025

Let me see what I can do about the stacktrace.

Hey, any updates? Still haven't been able to reproduce. It seems to open programs for analysis fine.

@spencerpogo spencerpogo marked this pull request as ready for review April 4, 2025 01:32
@ConnorNelson
Copy link
Contributor

ConnorNelson commented Apr 24, 2025

@fabaff Just following up, what can we do to get this merged?

@fabaff fabaff mentioned this pull request Sep 28, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 22, 2025
timschumi
timschumi reviewed Dec 19, 2025
View reviewed changes
Copy link
Member

@timschumi timschumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package works fine for me without any apparent crashes, so just marking some things that I had to do to get it to compile a year later.

pkgs/by-name/an/angr-management/package.nix

python3.pkgs.buildPythonApplication rec {
pname = "angr-management";
version = "9.2.147";
Copy link
Member

@timschumi timschumi Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be 9.2.154 now to match the version of angr that we currently use.

pkgs/by-name/an/angr-management/package.nix
pyzmq
traitlets
]
++ angr.optional-dependencies.AngrDB
Copy link
Member

@timschumi timschumi Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AngrDB is lowercase now.

pkgs/development/python-modules/pyqodeng-angr/default.nix

dependencies = [
pygments
future
Copy link
Member

@timschumi timschumi Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

future no longer works with python3.13, so this needs angr/pyqodeng#15 (either in patch form or by waiting for a release).

Copy link
Member

@timschumi timschumi Dec 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that pyqodeng-angr got broken out into a new PR and merged, so this should be fixed in the existing package instead.

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 19, 2025
@timschumi timschumi mentioned this pull request Jan 6, 2026
Open
@fabaff fabaff mentioned this pull request Jan 6, 2026
Merged
13 tasks
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 10, 2026

#477533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@natsukium natsukium Awaiting requested review from natsukium

@fabaff fabaff Awaiting requested review from fabaff

+2 more reviewers

@ConnorNelson ConnorNelson ConnorNelson left review comments

@timschumi timschumi timschumi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@spencerpogo @nixos-discourse @SuperSandro2000 @fabaff @ConnorNelson @timschumi @wegank @NixOSInfra